Mailing List Archive

[Bug 3012] New: lsearch.c line 423 | g = string_fmt_append(g, "Library version: lsearch: Exim version %s\n", EXIM_VERSION_STR));
https://bugs.exim.org/show_bug.cgi?id=3012

Bug ID: 3012
Summary: lsearch.c line 423 | g = string_fmt_append(g, "Library
version: lsearch: Exim version %s\n",
EXIM_VERSION_STR));
Product: Exim
Version: 4.96
Hardware: x86
OS: Solaris
Status: NEW
Severity: bug
Priority: medium
Component: Lookups
Assignee: unallocated@exim.org
Reporter: lt@timmann.de
CC: exim-dev@lists.exim.org

Hi Exim-Team,
today I tried to upgrade an exim on a Solaris x86 host, but this error is not
system specific as it is a typo in lsearch.c .

The error I got was:

lsearch.c: In function ‘lsearch_version_report’:

lsearch.c:423:90: error: expected ‘;’ before ‘)’ token

423 | g = string_fmt_append(g, "Library version: lsearch: Exim version %s\n",
EXIM_VERSION_STR));

|
^

lsearch.c:423:90: error: expected statement before ‘)’ token

*** Error code 1

The following command caused the error:

/usr/bin/gcc -m64 -B/usr/ccs/bin/amd64 -DDYNLOOKUP -shared -rdynamic -fPIC
-D_XOPEN_SOURCE -D_XOPEN_SOURCE_EXTENDED=1 -D__EXTENSIONS__ -I/usr/include/pcre
-I/usr/include/pcre -I/usr/include/openssl
-I/usr/oracle/instantclient/18.3/sdk/include lsearch.c -o lsearch.so

make: Fatal error: Command failed for target `lsearch.so'

Current working directory
/opt/src/build/exim-4.96/build-SunOS5-5.11-i386/lookups

*** Error code 1

The following command caused the error:

cd lookups && make SHELL=/bin/sh AR="ar cq" CC="/usr/bin/gcc -m64
-B/usr/ccs/bin/amd64" CFLAGS="-D_XOPEN_SOURCE -D_XOPEN_SOURCE_EXTENDED=1
-D__EXTENSIONS__ -I/usr/include/pcre" \

CFLAGS_DYNAMIC="-shared -rdynamic -fPIC" HDRS="../version.h ../config.h
../dbfunctions.h ../exim.h ../functions.h ../globals.h ../hintsdb.h
../hintsdb_structs.h ../local_scan.h ../macros.h ../mytypes.h ../structs.h
../os.h" \

FE="@" RANLIB="@true" RM_COMMAND="/bin/rm" \

INCLUDE="-I/usr/include/pcre -I/usr/include/openssl
-I/usr/oracle/instantclient/18.3/sdk/include"

make: Fatal error: Command failed for target `buildlookups'

Current working directory /opt/src/build/exim-4.96/build-SunOS5-5.11-i386

*** Error code 1

The following command caused the error:

cd build-${build:-`/bin/sh scripts/os-type`-`/bin/sh
scripts/arch-type`}${EXIM_BUILD_SUFFIX:+.$EXIM_BUILD_SUFFIX}; make
SHELL=/bin/sh

make: Fatal error: Command failed for target `all'

The simple fix was:
- g = string_fmt_append(g, "Library version: lsearch: Exim version %s\n",
EXIM_VERSION_STR));
+ g = string_fmt_append(g, "Library version: lsearch: Exim version %s\n",
EXIM_VERSION_STR);

As it is not fixed even in git (as far as I saw) I was wondering why nobody
else hit this bug.

Greetings,
Lars

--
You are receiving this mail because:
You are on the CC list for the bug.

--
## subscription configuration (requires account):
## https://lists.exim.org/mailman3/postorius/lists/exim-dev.lists.exim.org/
## unsubscribe (doesn't require an account):
## exim-dev-unsubscribe@lists.exim.org
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/
Re: [Bug 3012] New: lsearch.c line 423 | g = string_fmt_append(g, "Library version: lsearch: Exim version %s\n", EXIM_VERSION_STR)); [ In reply to ]
On 24/07/2023 14:35, Exim Bugzilla via Exim-dev wrote:
> s it is not fixed even in git (as far as I saw) I was wondering why nobody
> else hit this bug.

You must be the only person compiling for dynamic lookups!
Thanks for spotting this.
--
Cheers,
Jeremy


--
## subscription configuration (requires account):
## https://lists.exim.org/mailman3/postorius/lists/exim-dev.lists.exim.org/
## unsubscribe (doesn't require an account):
## exim-dev-unsubscribe@lists.exim.org
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/