Mailing List Archive

https://bugs.exim.org/show_bug.cgi?id=2291

Andrew Aitchison <exim@aitchison.me.uk> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |exim@aitchison.me.uk

--- Comment #1 from Andrew Aitchison <exim@aitchison.me.uk> ---
"cppcheck --force" will do a static analysis for every* #ifdef'd path.

I have found it to occasionally miss some compilation errors on some compilers.

It is not quick - about 40sec for exim.h and I gave up after 9min on exim.c
but can be made to cache results which makes it two orders of magnitude faster.

It seems happy with our code style.

Is this useful ?

--
You are receiving this mail because:
You are on the CC list for the bug.
--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

https://bugs.exim.org/show_bug.cgi?id=2291

--- Comment #2 from Jeremy Harris <jgh146exb@wizmail.org> ---
Looks useful from the manpage, but I'm unclear that my test of it was useful -
exim.h was scanned in nothing flat, and exim.c didn't take all that long.

$ cppcheck --force --verbose exim.h
Checking exim.h ...
Defines:
Undefines:
Includes:
Platform:Native
Checking exim.h: USE_TDB...
$

--
You are receiving this mail because:
You are on the CC list for the bug.
--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

https://bugs.exim.org/show_bug.cgi?id=2291

--- Comment #3 from Andrew Aitchison <exim@aitchison.me.uk> ---
What version of cppcheck do you have ?

# /usr/bin/cppcheck --version
Cppcheck 2.8

# /usr/bin/cppcheck --force --verbose exim.h
Checking exim.h ...
Defines:
Undefines:
Includes:
Platform:Native
Checking exim.h: AUTH_HEIMDAL_GSSAPI...
Checking exim.h: COMPILE_UTILITY...
Checking exim.h: COMPILE_UTILITY;EM_VERSION_C;MACRO_PREDEF...
Checking exim.h: COMPILE_UTILITY;MACRO_PREDEF...
Checking exim.h: DISABLE_PRDR...
Checking exim.h: DISABLE_TLS...
Checking exim.h: DISABLE_TLS;LIBRESSL_VERSION_NUMBER;USE_OPENSSL...
functions.h:1237:0: error: failed to expand 'child_open_exim', Wrong number of
parameters for macro 'child_open_exim'. [preprocessorErrorDirective]
child_open_exim(int * fdptr, const uschar * purpose)
^
Checking exim.h: EDQUOT...
Checking exim.h: ENABLE_DISABLE_FSYNC...
Checking exim.h: EXIM_HAVE_INOTIFY...
Checking exim.h: EXIM_HAVE_INOTIFY;EXIM_HAVE_KEVENT...
Checking exim.h: EXIM_HAVE_KEVENT...
Checking exim.h: EXIM_HAVE_OPENAT;MACRO_PREDEF...
Checking exim.h: EXIM_HAVE_SHA3;HASH_H;SHA_OPENSSL...
Checking exim.h: EXIM_PERL...
Checking exim.h: EXIM_TFO_PROBE...
Checking exim.h: EXPAND_DLFUNC...
Checking exim.h: EXPAND_DLFUNC;LOOKUP_MODULE_DIR;USE_READLINE...
Checking exim.h: EXPERIMENTAL_ARC...
Checking exim.h: EXPERIMENTAL_BRIGHTMAIL...
Checking exim.h: EXPERIMENTAL_DCC...
Checking exim.h: EXPERIMENTAL_DSN_INFO...
Checking exim.h: EXPERIMENTAL_ESMTP_LIMITS...
Checking exim.h: EX_OK...
Checking exim.h: FUDGE_GETC_AND_FRIENDS...
Checking exim.h: HASH_H...
Checking exim.h: HASH_H;SHA_GCRYPT...
Checking exim.h: HASH_H;SHA_GNUTLS...
Checking exim.h: HASH_H;SHA_NATIVE...
Checking exim.h: HASH_H;SHA_OPENSSL...
Checking exim.h: HASH_H;SHA_POLARSSL...
Checking exim.h: HAVE_ICONV...
Checking exim.h: HAVE_IPV6...
Checking exim.h: HAVE_LOCAL_SCAN...
Checking exim.h: HAVE_NS_TYPE;NS_INADDRSZ;SUPPORT_SPF...
Checking exim.h: HAVE_SYS_MOUNT_H...
Checking exim.h: HAVE_SYS_STATFS_H;HAVE_SYS_VFS_H...
Checking exim.h: HAVE_SYS_STATVFS_H...
Checking exim.h: HAVE_SYS_VFS_H...
Checking exim.h: LIBRESSL_VERSION_NUMBER;USE_OPENSSL...
Checking exim.h: LOOKUP_IBASE...
Checking exim.h: LOOKUP_LDAP...
Checking exim.h: LOOKUP_LSEARCH;LOOKUP_NWILDLSEARCH;LOOKUP_WILDLSEARCH...
Checking exim.h: LOOKUP_MYSQL...
Checking exim.h: LOOKUP_NWILDLSEARCH;LOOKUP_WILDLSEARCH...
Checking exim.h: LOOKUP_ORACLE...
Checking exim.h: LOOKUP_PGSQL...
Checking exim.h: LOOKUP_REDIS...
Checking exim.h: LOOKUP_SQLITE...
Checking exim.h: MACRO_PREDEF...
Checking exim.h: MACRO_PREDEF;MEASURE_TIMING...
Checking exim.h: MAX_PATH_LEN...
Checking exim.h: MEASURE_TIMING...
Checking exim.h: NEED_H_ERRNO...
Checking exim.h: O_BINARY...
Checking exim.h: SUPPORT_DANE...
Checking exim.h: SUPPORT_DMARC...
Checking exim.h: SUPPORT_DMARC;SUPPORT_SPF...
Checking exim.h: SUPPORT_I18N...
Checking exim.h: SUPPORT_MOVE_FROZEN_MESSAGES...
Checking exim.h: SUPPORT_PROXY;SUPPORT_SOCKS...
Checking exim.h: SUPPORT_SPF...
Checking exim.h: SUPPORT_SRS...
Checking exim.h: TCP_CORK...
Checking exim.h: TCP_NOPUSH...
Checking exim.h: USE_GDBM...
Checking exim.h: USE_GNUTLS...
Checking exim.h: USE_OPENSSL...
Checking exim.h: USE_TCP_WRAPPERS...
Checking exim.h: USE_TDB...
Checking exim.h: WANT_DEEPER_PRINTF_CHECKS...
Checking exim.h: WHITELIST_D_MACROS...
Checking exim.h: WINDOWS...
Checking exim.h: WITH_CONTENT_SCAN...
Checking exim.h: __EXTENSIONS__;__sparc;__svr4__...
Checking exim.h: __GNUC__;__clang__...
Checking exim.h: __P...
Checking exim.h: __sparc;__svr4__...

--
You are receiving this mail because:
You are on the CC list for the bug.
--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

https://bugs.exim.org/show_bug.cgi?id=2291

--- Comment #4 from Jeremy Harris <jgh146exb@wizmail.org> ---
Cppcheck 2.7.4
from the Fedora repos, f36, fresh install

--
You are receiving this mail because:
You are on the CC list for the bug.
--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##