Mailing List Archive: Patch for rtp_analysis.c: delta

Hi,

I'm not subscribed to the list so please CC replies.

Below is a patch for a bug in rtp_analysis.c. The variable statinfo->delta_timestamp was not initialized in all the necessary cases. The function rtp_packet_save_payload uses this variable and the for loop on line 935 could use an old value and run an incorrect amount of times, e.g. a couple billion, which gets ethereal stuck. I can supply an example capture which causes it. The patch solves the problem.

--- gtk/rtp_analysis.c.old 2006-04-17 17:46:20.000000000 +0300
+++ gtk/rtp_analysis.c 2006-07-18 15:43:11.000000000 +0300
@@ -689,8 +689,8 @@
}
/* is it a packet with the mark bit set? */
if (rtpinfo->info_marker_set) {
+ statinfo->delta_timestamp = rtpinfo->info_timestamp - statinfo->timestamp;
if (rtpinfo->info_timestamp > statinfo->timestamp){
- statinfo->delta_timestamp = rtpinfo->info_timestamp - statinfo->timestamp;
statinfo->flags |= STAT_FLAG_MARKER;
}
else{

--
Alex Shnitman
Software Engineer
Mango DSP Ltd.
02-5885041

_______________________________________________
Ethereal-dev mailing list
Ethereal-dev@ethereal.com
http://www.ethereal.com/mailman/listinfo/ethereal-dev

On Tue, Jul 18, 2006 at 04:39:35PM +0300, Alex Shnitman wrote:
> Below is a patch for a bug in rtp_analysis.c. The variable statinfo->delta_timestamp was not initialized in all the necessary cases. The function rtp_packet_save_payload uses this variable and the for loop on line 935 could use an old value and run an incorrect amount of times, e.g. a couple billion, which gets ethereal stuck. I can supply an example capture which causes it. The patch solves the problem.

Committed revision 18798.
Thanks for your contribution!

Please note though, that your patch was not applyed to the Ethereal
sources but to the Wireshark sources as the Ethereal project has been
renamed. Please send further mail to wireshark-dev@wireshark.org and
have a look at www.wireshark.org to download a current snapshot of the
sources including your patch.

Ciao
Joerg
--
Joerg Mayer <jmayer@loplof.de>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.
_______________________________________________
Ethereal-dev mailing list
Ethereal-dev@ethereal.com
http://www.ethereal.com/mailman/listinfo/ethereal-dev