Mailing List Archive: [PATCH] packet_gsm_a.c, detach request message parsing error.

Hello,

I find a error in dtap_gmm_detach_req() function (packet_gsm_a.c).
"P-TMSI" and "P-TMSI Signature" are not a TV format, but a TLV format.

- Reference: 3GPP TS 24.008 v7.4.0 (2006-06), Mobile radio interface Layer 3
specification,
Core network protocols; Stage 3. ch 9.4.5 Detach Request.

http://www.3gpp.org/ftp/Specs/archive/24_series/24.008/24008-740.zip

Best Regards,
Kyoung-Hwan Lee.

Index: epan/dissectors/packet-gsm_a.c
===================================================================
--- epan/dissectors/packet-gsm_a.c (revision 18189)
+++ epan/dissectors/packet-gsm_a.c (working copy)
@@ -16436,9 +16436,9 @@

ELEM_OPT_TV( 0x25 , BSSAP_PDU_TYPE_DTAP, DE_GMM_CAUSE , "" );

- ELEM_OPT_TV( 0x18 , BSSAP_PDU_TYPE_DTAP, DE_MID , " - P-TMSI" );
+ ELEM_OPT_TLV( 0x18 , BSSAP_PDU_TYPE_DTAP, DE_MID , " - P-TMSI" );

- ELEM_OPT_TV( 0x19 , BSSAP_PDU_TYPE_DTAP, DE_MID , " - P-TMSI Signature"
);
+ ELEM_OPT_TLV( 0x19 , BSSAP_PDU_TYPE_DTAP, DE_MID , " - P-TMSI
Signature" );

EXTRANEOUS_DATA_CHECK(curr_len, 0);
}

On Mon, Jun 19, 2006 at 05:01:21PM +0900, Kyoung-Hwan Lee wrote:
> I find a error in dtap_gmm_detach_req() function (packet_gsm_a.c).
> "P-TMSI" and "P-TMSI Signature" are not a TV format, but a TLV format.
>
> - Reference: 3GPP TS 24.008 v7.4.0 (2006-06), Mobile radio interface Layer 3
> specification,
> Core network protocols; Stage 3. ch 9.4.5 Detach Request.
>
> http://www.3gpp.org/ftp/Specs/archive/24_series/24.008/24008-740.zip

The development of EEthereal has been moved over to the name of
Wireshark - including new mailinglists etc. Your patch doesn't apply to
the Wireshark sources, so please get the current sources for wireshark
(www.wireshark.org), check whether your fix is still necessary and
recreate it.

Sorry for the delay in moderation, but the ethereal lists were basically
umoderated (i.e. all posts from non-members were held indefinitely)
since the move to wireshark.

Thanks for your contribution though!

ciao
Joerg

--
Joerg Mayer <jmayer@loplof.de>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.
_______________________________________________
Ethereal-dev mailing list
Ethereal-dev@ethereal.com
http://www.ethereal.com/mailman/listinfo/ethereal-dev