Mailing List Archive: Re: wireshark_0.99.2-1

The Debian package approval process turned up several source files in
the Wireshark distribution that don't have explicit licenses. With the
exception of in_cksum.h, is there any reason these shouldn't be GPLed?

> epan/in_cksum.h:
> no license info (but most probably BSD, like in_cksum.c)
>
> epan/dfilter/glib-util.c:
> epan/dfilter/glib-util.h:
> no license info, but glib- looks like it comes from GLIB, hence LGPL
>
> epan/dfilter/grammar.h:
> no license info (but most probably LGPL, like grammar.c)
>
> snprintf.h:
> no license info (but most probably GPL, like snprintf.c)

[ Do we still need snprintf*.[ch]? We appear to use g_snprintf()
everywhere. ]

> The remaining files without license are listed below; could you have
> a look at them ? I believe an email stating "those are under the same
> terms as Wireshark" would be enough, no need to roll a new tarball.
>
> editcap.c: missing license info
> merge.c: missing license info, but based on ethereal work
> mergecap.c: idem
> tap-funnel.c: no license
> epan/epan.c: no license
> epan/exceptions.h: no license info
> epan/dtd_grammar.h: no license info
> epan/dfilter/gencode.h: idem
>
> epan/dissectors/packet-bootparams.h: no license info
> epan/dissectors/packet-mount.h: no license info
> epan/dissectors/packet-nfs.h: no license info
> epan/dissectors/packet-nlm.h: no license info
> epan/dissectors/packet-x11-keysym.h: no license
> gtk/win32-file-dlg.h: no license
> tools/lemon/cppmagic.h: no license
>
> And then the one I don't know what to do with:
>
> epan/dissectors/packet-diameter-defs.h:
> * This file contains the static definitions of the Diameter base protocol
> * AVPs. If libxml is in the LD_LIBRARY_PATH, and dictionary.xml exists,
> * then it will not be used.
> *
> * $Id: packet-diameter-defs.h 17449 2006-03-02 21:19:25Z etxrab $
> * Generated: Fri Feb 23 13:04:15 2001
> * * Copyright (c) 2005 by Anders Broman <anders.broman@ericsson.com>

_______________________________________________
Ethereal-dev mailing list
Ethereal-dev@ethereal.com
http://www.ethereal.com/mailman/listinfo/ethereal-dev

On 7/19/06, Gerald Combs <gerald@wireshark.org> wrote:
> The Debian package approval process turned up several source files in
> the Wireshark distribution that don't have explicit licenses. With the
> exception of in_cksum.h, is there any reason these shouldn't be GPLed?

> > snprintf.h:
> > no license info (but most probably GPL, like snprintf.c)
>
> [ Do we still need snprintf*.[ch]? We appear to use g_snprintf()
> everywhere. ]

I dont think we do.

I just recompiled wireshark after removing all snprintf references
from the build and it appears to work fine.
(i dont compile with pcap nor do i compile with plugins but those
should be minor issues and easy to fix if required)

i have checked in a patch that removes out donated snprintf from the sources

many thanks for the debian people for pointing out this dead code
_______________________________________________
Ethereal-dev mailing list
Ethereal-dev@ethereal.com
http://www.ethereal.com/mailman/listinfo/ethereal-dev