Mailing List Archive

reading the drbd.c code I find ...
A couple minor items:

- the drbd_proc_get_info() code does not ever check not to overflow the
output buffer. Not a problem until you get a lot of devices and then ...

- block_id is not converted to wire protocol with cpu_to_be64() when
sending and receiving. Does not appear to matter now, but if we started
using more magic values than (-1LL) it would.

- dg
--
David Gould dg@example.com
SuSE, Inc., 580 2cd St. #210, Oakland, CA 94607 510.628.3380
As long as each individual is facing the TV tube alone, formal
freedom poses no threat to privilege. --Noam Chomsky
Re: reading the drbd.c code I find ... [ In reply to ]
Am Sam, 20 Mai 2000 schrieb dgould@example.com:
>A couple minor items:
>
>- the drbd_proc_get_info() code does not ever check not to overflow the
> output buffer. Not a problem until you get a lot of devices and then ...
>
There is a lot to do...

>- block_id is not converted to wire protocol with cpu_to_be64() when
> sending and receiving. Does not appear to matter now, but if we started
> using more magic values than (-1LL) it would.

You are right, it does not matter now, because the content of block_id
does not make any sense at the receiver's side (expect the magic value).
I am aware of that.

-Philipp
--
Want to try something new? Are you a Linux hacker?
Volunteer in testing mergemem!
(Get it from http://das.ist.org/mergemem)
-----
Philipp Reisner PGP: http://der.ist.org/~kde/pgp.asc