Mailing List Archive: FIXED Re: user_pref("mail.check_all_imap_folders_for

FIXED Re: user_pref("mail.check_all_imap_folders_for_new", true);

Apr 15, 2004, 3:42 PM

Post #1 of 10 (727 views)

I found it and fixed it :-)

Seems like mozilla doesn't like a final space before the closing ) in a
status response.

I've also cleaned up imapcommands to use the ci_write wrapper for
writing output to clients which helped with making dbmail's tcp
behaviour more compliant.

Mozilla/thunderbird will now behave as expected when checking all imap
folders.

Paul J Stevens wrote:
> More on this;
>
> I've fixed imapcommands to strictly use ci_write. The packet trace now
> looks real clean in terms of tcp. Still no luck though. I'll have to use
> another imap server as comparison. Mozilla apparently doesn't like
> something about dbmail's responses and just disconnects, period.
>
> Paul J Stevens wrote:
>
>> Following up on myself,
>>
>>
>> Looks like imapcommands.c writes after the client sends FIN packets. I
>> guess the ci_write patch should be expanded to include imapcommands as
>> well.
>>
>> Mozilla closes the connection by sending FIN after receiving response
>> to a command. If the server then wants to send OK tags after that the
>> client barfs and sends RST.
>>
>> I've attached a ethereal capture.
>>
>> Paul J Stevens wrote:
>>
>>>
>>> When I specify mentioned option in mozilla or thunderbird, the client
>>> will happily check all imap mailfolders on uw-imapd. However, this
>>> does not work for dbmail.
>>>
>>> This very annoying problem was identified today as being a dbmail
>>> issue, instead of a client issue.
>>>
>>> Looks like IMAPClientHandler bails out when it shouldn't. I'll see
>>> what I can find.
>>>
>>>
>>
>>
>> ------------------------------------------------------------------------
>>
>> _______________________________________________
>> Dbmail-dev mailing list
>> Dbmail-dev@dbmail.org
>> http://twister.fastxs.net/mailman/listinfo/dbmail-dev
>
>

--
________________________________________________________________
Paul Stevens mailto:paul@nfg.nl
NET FACILITIES GROUP PGP: finger paul@nfg.nl
The Netherlands________________________________http://www.nfg.nl

Re: FIXED Re: user_pref("mail.check_all_imap_folders_for_new", true); [ In reply to ]

matthew at zeut

Apr 15, 2004, 9:47 PM

Post #2 of 10 (725 views)

Permalink

YEAH!!!! I have been wondering for a while why Thunderbird wouldn't show
unread counts! Great work!

Matthew

Paul J Stevens wrote:

>
> I found it and fixed it :-)
>
> Seems like mozilla doesn't like a final space before the closing ) in
> a status response.
>
> I've also cleaned up imapcommands to use the ci_write wrapper for
> writing output to clients which helped with making dbmail's tcp
> behaviour more compliant.
>
> Mozilla/thunderbird will now behave as expected when checking all imap
> folders.

Re: FIXED Re: user_pref("mail.check_all_imap_folders_for_new", true); [ In reply to ]

paul at nfg

Apr 16, 2004, 2:32 AM

Post #3 of 10 (723 views)

Permalink

The experimental packages on debian.nfgd.net now contain this patch.

Matthew T. O'Connor wrote:
> YEAH!!!! I have been wondering for a while why Thunderbird wouldn't show
> unread counts! Great work!
>
> Matthew
>
> Paul J Stevens wrote:
>
>>
>> I found it and fixed it :-)
>>
>> Seems like mozilla doesn't like a final space before the closing ) in
>> a status response.
>>
>> I've also cleaned up imapcommands to use the ci_write wrapper for
>> writing output to clients which helped with making dbmail's tcp
>> behaviour more compliant.
>>
>> Mozilla/thunderbird will now behave as expected when checking all imap
>> folders.
>
>
>
> _______________________________________________
> Dbmail-dev mailing list
> Dbmail-dev@dbmail.org
> http://twister.fastxs.net/mailman/listinfo/dbmail-dev
>

--
________________________________________________________________
Paul Stevens paul@nfg.nl
NET FACILITIES GROUP GPG/PGP: 1024D/11F8CD31
The Netherlands_______________________________________www.nfg.nl

Re: FIXED Re: user_pref("mail.check_all_imap_folders_for_new", true); [ In reply to ]

ilja at ic-s

Apr 16, 2004, 6:07 AM

Post #4 of 10 (723 views)

Permalink

nice patch. It's applied in CVS

Ilja

On Fri, 2004-04-16 at 11:32, Paul J Stevens wrote:
> The experimental packages on debian.nfgd.net now contain this patch.
>
>
> Matthew T. O'Connor wrote:
> > YEAH!!!! I have been wondering for a while why Thunderbird wouldn't show
> > unread counts! Great work!
> >
> > Matthew
> >
> > Paul J Stevens wrote:
> >
> >>
> >> I found it and fixed it :-)
> >>
> >> Seems like mozilla doesn't like a final space before the closing ) in
> >> a status response.
> >>
> >> I've also cleaned up imapcommands to use the ci_write wrapper for
> >> writing output to clients which helped with making dbmail's tcp
> >> behaviour more compliant.
> >>
> >> Mozilla/thunderbird will now behave as expected when checking all imap
> >> folders.
> >
> >
> >
> > _______________________________________________
> > Dbmail-dev mailing list
> > Dbmail-dev@dbmail.org
> > http://twister.fastxs.net/mailman/listinfo/dbmail-dev
> >

Re: FIXED Re: user pref("mail.check_all_imap_folders_for_new", true); [ In reply to ]

matthew at zeut

Apr 16, 2004, 6:17 AM

Post #5 of 10 (718 views)

Permalink

On Friday 16 April 2004 09:07 am, Ilja Booij wrote:
> nice patch. It's applied in CVS

Now that this is fixed, what is the list of remaining showstoppers that is
preventing 2.0 from being released?

Re: FIXED Re: user pref("mail.check_all_imap_folders_for_new", true); [ In reply to ]

ilja at ic-s

Apr 16, 2004, 6:30 AM

Post #6 of 10 (723 views)

Permalink

On Fri, 2004-04-16 at 15:17, Matthew T. O'Connor wrote:
> On Friday 16 April 2004 09:07 am, Ilja Booij wrote:
> > nice patch. It's applied in CVS
>
> Now that this is fixed, what is the list of remaining showstoppers that is
> preventing 2.0 from being released?

2 problems:

1. Some messages get inserted with '\00'-characters. These messages then
get not parsed well.
2. Sometimes messages have empty bodies. This problem could have the
same cause as problem 1.

Paul J Stevens reported today that IMAP STATUS sometimes give wrong
results.

These are the problems that I know of. Problem 1 is a nasty one.. I've
been looking into it for some time now, but have not found the cause..

Ilja

Re: FIXED Re: user_pref("mail.check_all_imap_folders_for_new", true); [ In reply to ]

paul at nfg

Apr 16, 2004, 7:19 AM

Post #7 of 10 (727 views)

Permalink

Ilja Booij wrote:
> On Fri, 2004-04-16 at 15:17, Matthew T. O'Connor wrote:
>
>>On Friday 16 April 2004 09:07 am, Ilja Booij wrote:
>>
>>>nice patch. It's applied in CVS

great.

>>
>>Now that this is fixed, what is the list of remaining showstoppers that is
>>preventing 2.0 from being released?
>
>
> 2 problems:
>
> 1. Some messages get inserted with '\00'-characters. These messages then
> get not parsed well.

> 2. Sometimes messages have empty bodies. This problem could have the
> same cause as problem 1.

Problem 2 should be easily fixed. I like Anton's oracle patches: he
introduces a db_get_message(id) call that I feel is currently missing.
The way dbmail currently retreive a messages seems somewhat convoluted
to me. Or maybe I'm just dense :-)

> Paul J Stevens reported today that IMAP STATUS sometimes give wrong
> results.

Nothing critical I think. I have a couple of mailboxes that contain
messages with recent_flag set to 1. These show up with the status
command as expected, but when I select the mailbox they don't show up.
A closer look reveals they also have the deleted_flag set to 1, but the
are not removed by dbmail-maintenance. Could be the recent flag. I
haven't checked. Weird.

>
> These are the problems that I know of. Problem 1 is a nasty one.. I've
> been looking into it for some time now, but have not found the cause..
>
>
> Ilja
>
>
> _______________________________________________
> Dbmail-dev mailing list
> Dbmail-dev@dbmail.org
> http://twister.fastxs.net/mailman/listinfo/dbmail-dev
>

--
________________________________________________________________
Paul Stevens mailto:paul@nfg.nl
NET FACILITIES GROUP PGP: finger paul@nfg.nl
The Netherlands________________________________http://www.nfg.nl

Re: FIXED Re: user_pref("mail.check_all_imap_folders_for_new", true); [ In reply to ]

paul at nfg

Apr 17, 2004, 1:00 PM

Post #8 of 10 (723 views)

Permalink

Another problem solved it seems:

> Paul J Stevens reported today that IMAP STATUS sometimes give wrong
> results.

Folders can show unreads after checking their status, yet show *no*
unreads when selected. This happens when they have both their
recent_flag as well as their deleted_flag set.

This apparent inconsistency can be rectified in mozilla/tb by the
'compact folders' command which probably equals the expunge command.

--
________________________________________________________________
Paul Stevens mailto:paul@nfg.nl
NET FACILITIES GROUP PGP: finger paul@nfg.nl
The Netherlands________________________________http://www.nfg.nl

Re: FIXED Re: user_pref("mail.check_all_imap_folders_for_new", true); [ In reply to ]

ilja at ic-s

Apr 19, 2004, 3:27 AM

Post #9 of 10 (721 views)

Permalink

On Fri, 2004-04-16 at 16:19, Paul J Stevens wrote:
> Problem 2 should be easily fixed. I like Anton's oracle patches: he
> introduces a db_get_message(id) call that I feel is currently missing.
> The way dbmail currently retreive a messages seems somewhat convoluted
> to me. Or maybe I'm just dense :-)

I agree that this function makes things a bit easier, and should
probably be in DBMail. I'm wondering if it's an simple & easy patch,
that should be in 2.0...
>
> > Paul J Stevens reported today that IMAP STATUS sometimes give wrong
> > results.
>
> Nothing critical I think. I have a couple of mailboxes that contain
> messages with recent_flag set to 1. These show up with the status
> command as expected, but when I select the mailbox they don't show up.
> A closer look reveals they also have the deleted_flag set to 1, but the
> are not removed by dbmail-maintenance. Could be the recent flag. I
> haven't checked. Weird.
I'll have a look at this. It should be pretty easy to find.

Ilja

Re: FIXED Re: user_pref("mail.check_all_imap_folders_for_new", true); [ In reply to ]

aaron at serendipity

Apr 19, 2004, 1:14 PM

Post #10 of 10 (718 views)

Permalink

Yes, please! I started to write a frontend to dump messages out to mbox
format, and was thinking about making it a combined mbox import/export tool...
but stopped when I realized that there was no easy way to just grab a message
from the database.

Aaron

Ilja Booij <ilja@ic-s.nl> said:

>
> On Fri, 2004-04-16 at 16:19, Paul J Stevens wrote:
> > Problem 2 should be easily fixed. I like Anton's oracle patches: he
> > introduces a db_get_message(id) call that I feel is currently missing.
> > The way dbmail currently retreive a messages seems somewhat convoluted
> > to me. Or maybe I'm just dense :-)
>
> I agree that this function makes things a bit easier, and should
> probably be in DBMail. I'm wondering if it's an simple & easy patch,
> that should be in 2.0...
> >
> > > Paul J Stevens reported today that IMAP STATUS sometimes give wrong
> > > results.
> >
> > Nothing critical I think. I have a couple of mailboxes that contain
> > messages with recent_flag set to 1. These show up with the status
> > command as expected, but when I select the mailbox they don't show up.
> > A closer look reveals they also have the deleted_flag set to 1, but the
> > are not removed by dbmail-maintenance. Could be the recent flag. I
> > haven't checked. Weird.
> I'll have a look at this. It should be pretty easy to find.
>
> Ilja
>
>
> _______________________________________________
> Dbmail-dev mailing list
> Dbmail-dev@dbmail.org
> http://twister.fastxs.net/mailman/listinfo/dbmail-dev
>

--

Mailing List Archive

Mailing List Archive

Attached Files: