Mailing List Archive

Le 20/05/2010 12:30, Fabrice Lapeyrere a ?crit :
> hi everyone,
>
> thanks for the job, davical is just what i need, even if i have
> problems with freebusy feature and lightning.
>
> I looked into the source code and see in caldav-GET.php :
>
> line 23 : function obfuscate_event( $resource ) {
>
> line 117 : $vcal->AddComponent(obfuscated_event($resource));
> line 162 : $confidential = obfuscated_event($resources[0]);
>
> so I think it sould be with e "d"
>
> line 23 : function obfuscated_event( $resource ) {
>
> am I right ?
>
> thanks again
>
> Fabrice
To have free-busy informations from the caldav.php url, i have replaced
"DAV::read" by "urn:ietf:params:xml:ns:caldav:read-free-busy" in
caldav-PROPFIND.php in lines 134, 176, 220, 231.

is there any problem with that according that i've set read-free-busy as
a default ?

fabrice

On Thu, 2010-05-20 at 12:30 +0200, Fabrice Lapeyrere wrote:
> hi everyone,
>
> thanks for the job, davical is just what i need, even if i have problems
> with freebusy feature and lightning.
>
> I looked into the source code and see in caldav-GET.php :
>
> line 23 : function obfuscate_event( $resource ) {
>
> line 117 : $vcal->AddComponent(obfuscated_event($resource));
> line 162 : $confidential = obfuscated_event($resources[0]);
>
> so I think it sould be with e "d"
>
> line 23 : function obfuscated_event( $resource ) {
>
> am I right ?

Hi Fabrice,

Yes, you're correct. I also spotted this a couple of days ago when I
was starting to look at why events are not being obfuscated correctly...

Unfortunately I haven't figured out exactly why they aren't yet, but I'm
sure I'll find some time to nail it Real Soon :-)

Cheers,
Andrew.

--
------------------------------------------------------------------------
andrew (AT) morphoss (DOT) com +64(272)DEBIAN
Your talents will be recognized and suitably rewarded.
------------------------------------------------------------------------

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.morphoss.com/pipermail/davical-dev/attachments/20100521/5dc091f0/attachment.pgp>

On Thu, 2010-05-20 at 14:19 +0200, Fabrice Lapeyrere wrote:
> Le 20/05/2010 12:30, Fabrice Lapeyrere a ?crit :
> > hi everyone,
> >
> > thanks for the job, davical is just what i need, even if i have
> > problems with freebusy feature and lightning.
> >
> > I looked into the source code and see in caldav-GET.php :
> >
> > line 23 : function obfuscate_event( $resource ) {
> >
> > line 117 : $vcal->AddComponent(obfuscated_event($resource));
> > line 162 : $confidential = obfuscated_event($resources[0]);
> >
> > so I think it sould be with e "d"
> >
> > line 23 : function obfuscated_event( $resource ) {
> >
> > am I right ?
> >
> > thanks again
> >
> > Fabrice

> To have free-busy informations from the caldav.php url, i have replaced
> "DAV::read" by "urn:ietf:params:xml:ns:caldav:read-free-busy" in
> caldav-PROPFIND.php in lines 134, 176, 220, 231.
>
> is there any problem with that according that i've set read-free-busy as
> a default ?

Well, yes...

The intention of that code is that if the person *does not* have the
privilege to read the event, they will retrieve an obfuscated copy of
the event.

You are checking to see whether they *do* have privilege to view
free-busy, which we know they do since they made it past line 17...

It is normal for a person to have both DAV::read and
caldav:read-free-busy access at the same time.

I think the bug will be either in DAVResource::HavePrivilegeTo() or in
the privileges read in for the collection when the DAVResource is
initialised.

Cheers,
Andrew.

--
------------------------------------------------------------------------
andrew (AT) morphoss (DOT) com +64(272)DEBIAN
If you sow your wild oats, hope for a crop failure.
------------------------------------------------------------------------

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.morphoss.com/pipermail/davical-dev/attachments/20100521/dcb34432/attachment.pgp>