Mailing List Archive

[PATCH] libclamav: empty content-disposition causes crash
Hi there,

Please find attached a small patch against snapshot 20031009 (SF seem to be
having some problems else it would be against current CVS) which fixes a problem
in mbox.c insert() where an empty content-disposition causes a crash.

Also a fix for cases where header args flow to the next line. It seems that
inMimeHead is incorrectly set to TRUE and thus whole header lines are incorrectly
considered arguments rather than new headers e.g. consider this:

1: Content-Type:
2: base64
3: Content-Disposition:
4: attachment; filename="info.rtf"

Content-Type is set correctly but lines 3 & 4 are added as arguments with
messageAddArgument() at approx. line 530 of mbox.c since inMimeHead remains TRUE
after setting of Content-type and thus Content-Disposition is never actually set.


Regards,
Matt.
Re: [PATCH] libclamav: empty content-disposition causes crash [ In reply to ]
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Friday 10 Oct 2003 6:09 am, Matt Sullivan wrote:

> Also a fix for cases where header args flow to the next line.

A quick e-mail to me before undertaking this would have saved you so
much time since I could have told you it's already been done uploaded to CVS
some two or three weeks ago.

Please ensure you always work on the latest code to avoid duplicating
effort.

- -Nigel

- --
Nigel Horne. Arranger, Composer, Typesetter.
NJH Music, Barnsley, UK. ICQ#20252325
njh@despammed.com http://www.bandsman.co.uk
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE/hk35hTUd3VwpF6IRAieuAJ9Q3Q+o7iT4p1GC5Q22n4Tq2MQYJwCffzf+
AgXNWJn2Zn9r5zRB9aDG8Pc=
=eNaY
-----END PGP SIGNATURE-----
Re: [PATCH] libclamav: empty content-disposition causes crash [ In reply to ]
On Fri, 10 Oct 2003 at 07:13:05 +0100, Nigel Horne wrote:

> On Friday 10 Oct 2003 6:09 am, Matt Sullivan wrote:
>
> > Also a fix for cases where header args flow to the next line.
>
> A quick e-mail to me before undertaking this would have saved you so
> much time since I could have told you it's already been done uploaded to CVS
> some two or three weeks ago.

Take a chill pill, seriously.


> Please ensure you always work on the latest code to avoid duplicating
> effort.

Is the snapshot of 20031009 not the latest code?


Matt.