Mailing List Archive

[6894] cherokee/trunk/cherokee/handler_cgi_base.c: Memory leak fix.
Revision: 6894
http://svn.cherokee-project.com/changeset/6894
Author: alo
Date: 2011-10-07 23:01:51 +0200 (Fri, 07 Oct 2011)
Log Message:
-----------
Memory leak fix. Some memory could be leaked while adding headers to
the response of a fcgi, scgi, cgi or wsgi handler.

Modified Paths:
--------------
cherokee/trunk/cherokee/handler_cgi_base.c

Modified: cherokee/trunk/cherokee/handler_cgi_base.c
===================================================================
--- cherokee/trunk/cherokee/handler_cgi_base.c 2011-10-07 21:01:45 UTC (rev 6893)
+++ cherokee/trunk/cherokee/handler_cgi_base.c 2011-10-07 21:01:51 UTC (rev 6894)
@@ -1198,8 +1198,10 @@
cherokee_buffer_clean (outbuf);

ret = cherokee_handler_file_add_headers (cgi->file_handler, outbuf);
- if (ret != ret_ok)
+ if (ret != ret_ok) {
+ cherokee_buffer_mrproper (&cgi_header);
return ret_error;
+ }

/* Overwrite the handler properties
*/
@@ -1207,6 +1209,8 @@
conn->chunked_encoding = false;

mix_headers (outbuf, &cgi_header);
+
+ cherokee_buffer_mrproper (&cgi_header);
return ret_ok;
}