On Apr 9, 2009, at 10:27 AM, bugs@lists.bricolage.cc wrote:
> http://bugs.bricolage.cc/show_bug.cgi?id=1460
>
> --- Comment #1 from Scott Lanning <lannings@who.int> 2009-04-09
> 15:27:14 ---
> The up/down jumping problem has been fixed here:
> http://blog.gilluminate.com/2009/01/20/scriptaculous-autocomplete-page-jump-using-arrow-keys/
>
> In revision 8566, I used the solution from the comment by Janus
> Novak (cleaned
> a little because the forum apparently munged some of his code, plus
> he forgot
> to restart the "indicator" in getUpdatedChoices). It takes a good
> bit of hacky
> overriding code in lib.js, though, that will need to track any
> scriptaculous
> upgrade.
This is a concrete example of what David was saying about git helping
to maintain custom patches. Since scriptaculous is on GitHub, we can
fork it and commit our patches directly to our fork. Pulling updates
from the canonical repo is just point-and-click in the GitHub
interface. Then we can include our scriptaculous repo in the main
Bricolage repo as a submodule.
--
Marshall
> http://bugs.bricolage.cc/show_bug.cgi?id=1460
>
> --- Comment #1 from Scott Lanning <lannings@who.int> 2009-04-09
> 15:27:14 ---
> The up/down jumping problem has been fixed here:
> http://blog.gilluminate.com/2009/01/20/scriptaculous-autocomplete-page-jump-using-arrow-keys/
>
> In revision 8566, I used the solution from the comment by Janus
> Novak (cleaned
> a little because the forum apparently munged some of his code, plus
> he forgot
> to restart the "indicator" in getUpdatedChoices). It takes a good
> bit of hacky
> overriding code in lib.js, though, that will need to track any
> scriptaculous
> upgrade.
This is a concrete example of what David was saying about git helping
to maintain custom patches. Since scriptaculous is on GitHub, we can
fork it and commit our patches directly to our fork. Pulling updates
from the canonical repo is just point-and-click in the GitHub
interface. Then we can include our scriptaculous repo in the main
Bricolage repo as a submodule.
--
Marshall