Mailing List Archive: Fixing popup menu z-index issues

Fixing popup menu z-index issues

Apr 3, 2009, 4:37 PM

Post #1 of 4 (2735 views)

Hi,

Spent a bit of time looking into:

http://bugs.bricolage.cc/show_bug.cgi?id=1406

and I've come up with a somewhat hacky, but relatively simple fix that
fixes all the z-index issues with IE6/7 and if you let it run for all
browsers, it fixes the z-index breakage after any re-ordering.

I see from the bug report that Matt wasn't in favour of using such a
solution, so I haven't committed it. What's everyone think?

Patch is attached.

Adrian

Re: Fixing popup menu z-index issues [ In reply to ]

david at kineticode

Apr 3, 2009, 5:17 PM

Post #2 of 4 (2635 views)

Permalink

On Apr 3, 2009, at 4:37 PM, Adrian Yee wrote:

> Hi,
>
> Spent a bit of time looking into:
>
> http://bugs.bricolage.cc/show_bug.cgi?id=1406
>
> and I've come up with a somewhat hacky, but relatively simple fix
> that fixes all the z-index issues with IE6/7 and if you let it run
> for all browsers, it fixes the z-index breakage after any re-ordering.
>
> I see from the bug report that Matt wasn't in favour of using such a
> solution, so I haven't committed it. What's everyone think?

Hacky? Hell yes! But if it's the only thing that works, fine. Perhaps
Matt has other ideas, though.

Best,

David

Re: Fixing popup menu z-index issues [ In reply to ]

adeola at digitalcraftsmen

Apr 4, 2009, 12:56 AM

Post #3 of 4 (2639 views)

Permalink

On 4 Apr 2009, at 01:17, "David E. Wheeler" <david@kineticode.com>
wrote:

> On Apr 3, 2009, at 4:37 PM, Adrian Yee wrote:
>
>> Hi,
>>
>> Spent a bit of time looking into:
>>
>> http://bugs.bricolage.cc/show_bug.cgi?id=1406
>>
>> and I've come up with a somewhat hacky, but relatively simple fix
>> that fixes all the z-index issues with IE6/7 and if you let it run
>> for all browsers, it fixes the z-index breakage after any re-
>> ordering.
>>
>> I see from the bug report that Matt wasn't in favour of using such
>> a solution, so I haven't committed it. What's everyone think?
>
> Hacky? Hell yes! But if it's the only thing that works, fine.
> Perhaps Matt has other ideas, though.

It's probably because we're using Prototype so everything draggable /
should/ have a dragEnd event which is where the z-index fixing should
be done.

Haven't had a chance to look at this but I'm think this should be a
trivial fix.

Regards,

Adeola

Re: Fixing popup menu z-index issues [ In reply to ]

rolfm at denison

Apr 6, 2009, 6:30 AM

Post #4 of 4 (2617 views)

Permalink

On Apr 3, 2009, at 8:17 PM, David E. Wheeler wrote:

> On Apr 3, 2009, at 4:37 PM, Adrian Yee wrote:
>
>> Hi,
>>
>> Spent a bit of time looking into:
>>
>> http://bugs.bricolage.cc/show_bug.cgi?id=1406
>>
>> and I've come up with a somewhat hacky, but relatively simple fix
>> that fixes all the z-index issues with IE6/7 and if you let it run
>> for all browsers, it fixes the z-index breakage after any re-
>> ordering.
>>
>> I see from the bug report that Matt wasn't in favour of using such
>> a solution, so I haven't committed it. What's everyone think?
>
> Hacky? Hell yes! But if it's the only thing that works, fine.
> Perhaps Matt has other ideas, though.

At this point I'm all in favor of committing that if you haven't
already. Ultimately, the solution will be reworking the interface,
but I just won't have it done anytime soon. It's too big.

-Matt

Mailing List Archive

Mailing List Archive

Attached Files: