Mailing List Archive

[Bricolage #277] PUBLISH_RELATED_FAIL_BEHAVIOR behaves inconsistently
// Add your reply above here
==================================================
Nick Legg updated this ticket at August 2nd, 2011 @ 07:57 PM

I'm having some trouble with PUBLISH_RELATED_FAIL_BEHAVIOR and publishing stories. There are two different ways to publish via the UI: from my Workspace and/or a Desk or from within the Edit Profile on the story I want to publish.

**Workspace/Desk**:

*CASE 1* - If PUBLISH_RELATED_FAIL_BEHAVIOR = warn, I receive a nice Ajax popup that tells me I cannot publish my story because one of its related stories is checked out. Shouldn't this only happen when PUBLISH_RELATED_FAIL_BEHAVIOR = fail? Furthermore, the publish job for the story I want to publish is not created - so I might as well be on the "fail" setting.

*CASE 2* - If PUBLISH_RELATED_FAIL_BEHAVIOR = fail, the story "fades" off the Workspace/Desk, but no job is ever created. Upon refreshing the Workspace/Desk, the story is back. Apparently the error is silent, which is really misleading.

**Edit Profile**:

*CASE 3* - If PUBLISH_RELATED_FAIL_BEHAVIOR = warn, I receive a 500 error page after performing a Checkin & Publish. No publish job is not created. Here's the error log entry:
[Tue Aug 02 19:36:39 2011] [error] [client xxx.xxx.xxx.xxx] Can't use string ("Some of the related assets were ") as an ARRAY ref while "strict refs" in use at /usr/local/bricolage/lib/Bric/App/Callback/Desk.pm line 377, <GEN13> line 3153.\n, referer: https://bric.denison.edu/workflow/profile/story/21641/?checkout=1
[/usr/local/bricolage/lib/Bric/App/Handler.pm:383]
[/usr/local/share/perl5/Params/CallbackRequest.pm:310]
[/usr/local/share/perl5/MasonX/Interp/WithCallbacks.pm:119]
[/usr/local/share/perl5/HTML/Mason/ApacheHandler.pm:868]
[/usr/local/share/perl5/HTML/Mason/ApacheHandler.pm:822]
[/usr/local/bricolage/lib/Bric/App/Handler.pm:308]
[-e:0]

*CASE 4* - If PUBLISH_RELATED_FAIL_BEHAVIOR = fail, I'm kicked out to my Workspace where I see the following error message at the top (the story gets checked in but doesn't publish, of course):
Story "Catalog Builder" saved and checked in to "Ucomm".
Cannot auto-publish related story "Political Science" because it is checked out.
Publish aborted due to errors above. Please fix the above problems and try again.

The fourth case behaves as expected, but the first three do not. For 1 and 2, the publish job should always be created and execute normally if PUBLISH_RELATED_FAIL_BEHAVIOR = warn; additionally, the user should be given some kind of warning message. For 3, the user should be presented with an error along the same lines as the one received in 4 (or, perhaps better, the error popup used in case 1).
--------------------------------------------------------------------------------

Assigned: Bugs (at bricolage)
State: new
View this ticket online: http://bricolage.lighthouseapp.com/projects/29601/tickets/277-publish_related_fail_behavior-behaves-inconsistently

Stop being notified of this ticket's changes: http://bricolage.lighthouseapp.com/watching/9a5aa53ab1426026e1d7876f419088672f6de42d
Update your Profile: http://bricolage.lighthouseapp.com/profile
Support: support@lighthouseapp.com or http://help.lighthouseapp.com
[Bricolage #277] PUBLISH_RELATED_FAIL_BEHAVIOR behaves inconsistently [ In reply to ]
// Add your reply above here
==================================================
theory updated this ticket at August 16th, 2011 @ 07:15 AM
* Assigned user changed from "Bugs (at bricolage)" to "theory"
* Milestone changed from "" to "2.0.2"
* State changed from "new" to "open"
Fixed the ajax bit in ca5f60ff338263875bfad7b467e0ab6fee730d02. Will figure out the non-ajax scenarios tomorrow or later this week.
--------------------------------------------------------------------------------

Assigned: theory
State: open
Milestone: 2.0.2
View this ticket online: http://bricolage.lighthouseapp.com/projects/29601/tickets/277-publish_related_fail_behavior-behaves-inconsistently

Stop being notified of this ticket's changes: http://bricolage.lighthouseapp.com/watching/9a5aa53ab1426026e1d7876f419088672f6de42d
Update your Profile: http://bricolage.lighthouseapp.com/profile
Support: support@lighthouseapp.com or http://help.lighthouseapp.com
[Bricolage #277] PUBLISH_RELATED_FAIL_BEHAVIOR behaves inconsistently [ In reply to ]
// Add your reply above here
==================================================
theory updated this ticket at August 17th, 2011 @ 05:43 AM
* State changed from "open" to "resolved"
Okay, I believe this is fixed. If you want to patch an existing installation of 2.0, you'll need to apply all of these:


* [[5d442c517ecb9f5ad12bb0015f0e524a6d126254](https://github.com/bricoleurs/bricolage/commit/5d442c517ecb9f5ad12bb0015f0e524a6d126254.diff)
* [835b0b8a9189753fd4ad64c6b52bd895dea9f55a](https://github.com/bricoleurs/bricolage/commit/835b0b8a9189753fd4ad64c6b52bd895dea9f55a.diff)
* [adb204561191a1ee8766dc8f5446c88540a0c1c3](https://github.com/bricoleurs/bricolage/commit/adb204561191a1ee8766dc8f5446c88540a0c1c3.diff)
* [438aba5c162bd0b94c521ada79fcb5cb7092cf48](https://github.com/bricoleurs/bricolage/commit/438aba5c162bd0b94c521ada79fcb5cb7092cf48.diff)
* [74b39e626e2c47a6134638829420544b3973f53c](https://github.com/bricoleurs/bricolage/commit/.diff)
* [b8f4919598d8a3270636f79dd3504e06a7892412](https://github.com/bricoleurs/bricolage/commit/74b39e626e2c47a6134638829420544b3973f53c.diff)

While I think these fixes address all known issues, it wouldn't surprise me to see new ones pup up, because this code is just a disaster, and there are, of course, no tests. Ideally the whole system would be re-thought and re-architected. Any suck^^^^volunteers?
--------------------------------------------------------------------------------

Assigned: theory
State: resolved
Milestone: 2.0.2
View this ticket online: http://bricolage.lighthouseapp.com/projects/29601/tickets/277-publish_related_fail_behavior-behaves-inconsistently

Stop being notified of this ticket's changes: http://bricolage.lighthouseapp.com/watching/9a5aa53ab1426026e1d7876f419088672f6de42d
Update your Profile: http://bricolage.lighthouseapp.com/profile
Support: support@lighthouseapp.com or http://help.lighthouseapp.com
[Bricolage #277] PUBLISH_RELATED_FAIL_BEHAVIOR behaves inconsistently [ In reply to ]
// Add your reply above here
==================================================
theory updated this ticket at August 17th, 2011 @ 05:45 AM

Better list of patch links:


* [5d442c517ecb9f5ad12bb0015f0e524a6d126254](https://github.com/bricoleurs/bricolage/commit/5d442c517ecb9f5ad12bb0015f0e524a6d126254.diff)
* [835b0b8a9189753fd4ad64c6b52bd895dea9f55a](https://github.com/bricoleurs/bricolage/commit/835b0b8a9189753fd4ad64c6b52bd895dea9f55a.diff)
* [adb204561191a1ee8766dc8f5446c88540a0c1c3](https://github.com/bricoleurs/bricolage/commit/adb204561191a1ee8766dc8f5446c88540a0c1c3.diff)
* [438aba5c162bd0b94c521ada79fcb5cb7092cf48](https://github.com/bricoleurs/bricolage/commit/438aba5c162bd0b94c521ada79fcb5cb7092cf48.diff)
* [74b39e626e2c47a6134638829420544b3973f53c](https://github.com/bricoleurs/bricolage/commit/74b39e626e2c47a6134638829420544b3973f53c.diff)
* [b8f4919598d8a3270636f79dd3504e06a7892412](https://github.com/bricoleurs/bricolage/commit/74b39e626e2c47a6134638829420544b3973f53c.diff)
--------------------------------------------------------------------------------

Assigned: theory
State: resolved
Milestone: 2.0.2
View this ticket online: http://bricolage.lighthouseapp.com/projects/29601/tickets/277-publish_related_fail_behavior-behaves-inconsistently

Stop being notified of this ticket's changes: http://bricolage.lighthouseapp.com/watching/9a5aa53ab1426026e1d7876f419088672f6de42d
Update your Profile: http://bricolage.lighthouseapp.com/profile
Support: support@lighthouseapp.com or http://help.lighthouseapp.com