Mailing List Archive: Bugfix for mod

Hello *

I've made a Bugfix in mod_backhand.c (Release 1.1.0).

We're using Backhand with the "RedirectToIP" Option, but with the
Redirection Backhand "forgot" the Querystring (URL encoded CGI Params) in the
Location Header / Redirection URL.

Insert the following few Lines in mod_backhand.c after Line #549 to fix
this Bug (or is it a "Feature" ? :=)

--- snip ---

...

} else {
const char *rhost = ap_table_get(r->notes,
"Backhand-Redirect-Host");
if(!rhost) rhost=serverstats[remote_machine.id].hostname;
ap_snprintf(buffer, RBUFLEN, "http://%s%s%s", rhost, portstring,
r->filename);
}

/* BUGFIXING */
if ( r->args != NULL ) /* If we've get a Query String */
{
ap_snprintf(buffer, RBUFLEN, "%s?%s",
buffer, r->args);
}

--- snip ---

Best Reguard

Juergen Brunk
juergen.brunk@gmx.de

--
Sent through GMX FreeMail - http://www.gmx.net

Jürgen,

This was definitely not an intended "feature" :-) It was an oversight on my
part... Thank you for the patch, it has been applied to the CVS tree and will
be incorporated into the next release.

Jürgen Brunk wrote:
> I've made a Bugfix in mod_backhand.c (Release 1.1.0).
>
> We're using Backhand with the "RedirectToIP" Option, but with the
> Redirection Backhand "forgot" the Querystring (URL encoded CGI Params) in the
> Location Header / Redirection URL.
>
> Insert the following few Lines in mod_backhand.c after Line #549 to fix
> this Bug (or is it a "Feature" ? :=)

--
Theo Schlossnagle
1024D/A8EBCF8F/13BD 8C08 6BE2 629A 527E 2DC2 72C2 AD05 A8EB CF8F
2047R/33131B65/71 F7 95 64 49 76 5D BA 3D 90 B9 9F BE 27 24 E7