Mailing List Archive

Re: svn commit: r1908060 - in /httpd/httpd/trunk/test/modules: http1/htdocs/cgi/ http2/ http2/htdocs/cgi/ md/ tls/ tls/htdocs/a.mod-tls.test/ tls/htdocs/b.mod-tls.test/
[resent to dev@]

On Sat, Mar 04, 2023 at 01:40:39PM -0000, icing@apache.org wrote:
> Author: icing
> Date: Sat Mar 4 13:40:38 2023
> New Revision: 1908060
>
> URL: http://svn.apache.org/viewvc?rev=1908060&view=rev
> Log:
> Test case updates related to macOS ventura changes:
>
> - python 3.11 deprecates the `cg` module, replacing
> url query and multipart form-data handling with new code
> - adaptions to changes in openssl/curl behaviours
> - all mod_tls test cases now have prefix `test_tls_` for
> easier scoping.

This seems to be failing:

https://github.com/apache/httpd/actions/runs/4341851149/jobs/7581956398

1) Maybe some new pypi requirement or something? Looks like the CGI
scripts are now giving 500 errors.

2) What is the path to the relevant error_log when running those tests,
we can tweak the config to grab that file and upload it for easy
diagnosis.
Re: svn commit: r1908060 - in /httpd/httpd/trunk/test/modules: http1/htdocs/cgi/ http2/ http2/htdocs/cgi/ md/ tls/ tls/htdocs/a.mod-tls.test/ tls/htdocs/b.mod-tls.test/ [ In reply to ]
> Am 06.03.2023 um 17:53 schrieb Joe Orton <jorton@redhat.com>:
>
> [resent to dev@]
>
> On Sat, Mar 04, 2023 at 01:40:39PM -0000, icing@apache.org wrote:
>> Author: icing
>> Date: Sat Mar 4 13:40:38 2023
>> New Revision: 1908060
>>
>> URL: http://svn.apache.org/viewvc?rev=1908060&view=rev
>> Log:
>> Test case updates related to macOS ventura changes:
>>
>> - python 3.11 deprecates the `cg` module, replacing
>> url query and multipart form-data handling with new code
>> - adaptions to changes in openssl/curl behaviours
>> - all mod_tls test cases now have prefix `test_tls_` for
>> easier scoping.
>
> This seems to be failing:
>
> https://github.com/apache/httpd/actions/runs/4341851149/jobs/7581956398
>
> 1) Maybe some new pypi requirement or something? Looks like the CGI
> scripts are now giving 500 errors.

Yes, for the deprecated `cgi` python module, the `multipart` module
is recommended by the PyGods to replace parts of it. I have no idea
how that is named on ubuntu-latest.


> 2) What is the path to the relevant error_log when running those tests,
> we can tweak the config to grab that file and upload it for easy
> diagnosis.

The server error log on all pytests is found in test/gen/apache/logs/error_log. It is cleared on test start.

Kind Regards,
Stefan
Re: svn commit: r1908060 - in /httpd/httpd/trunk/test/modules: http1/htdocs/cgi/ http2/ http2/htdocs/cgi/ md/ tls/ tls/htdocs/a.mod-tls.test/ tls/htdocs/b.mod-tls.test/ [ In reply to ]
On 3/7/23 9:15 AM, Stefan Eissing via dev wrote:
>
>
>> Am 06.03.2023 um 17:53 schrieb Joe Orton <jorton@redhat.com>:
>>
>> [resent to dev@]
>>
>> On Sat, Mar 04, 2023 at 01:40:39PM -0000, icing@apache.org wrote:
>>> Author: icing
>>> Date: Sat Mar 4 13:40:38 2023
>>> New Revision: 1908060
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1908060&view=rev
>>> Log:
>>> Test case updates related to macOS ventura changes:
>>>
>>> - python 3.11 deprecates the `cg` module, replacing
>>> url query and multipart form-data handling with new code
>>> - adaptions to changes in openssl/curl behaviours
>>> - all mod_tls test cases now have prefix `test_tls_` for
>>> easier scoping.
>>
>> This seems to be failing:
>>
>> https://github.com/apache/httpd/actions/runs/4341851149/jobs/7581956398
>>
>> 1) Maybe some new pypi requirement or something? Looks like the CGI
>> scripts are now giving 500 errors.
>
> Yes, for the deprecated `cgi` python module, the `multipart` module
> is recommended by the PyGods to replace parts of it. I have no idea
> how that is named on ubuntu-latest.

I would try python3-multipart.

Regards

RĂ¼diger
Re: svn commit: r1908060 - in /httpd/httpd/trunk/test/modules: http1/htdocs/cgi/ http2/ http2/htdocs/cgi/ md/ tls/ tls/htdocs/a.mod-tls.test/ tls/htdocs/b.mod-tls.test/ [ In reply to ]
On Tue, Mar 07, 2023 at 09:15:59AM +0100, Stefan Eissing via dev wrote:
>
>
> > Am 06.03.2023 um 17:53 schrieb Joe Orton <jorton@redhat.com>:
> >
> > [resent to dev@]
> >
> > On Sat, Mar 04, 2023 at 01:40:39PM -0000, icing@apache.org wrote:
> >> Author: icing
> >> Date: Sat Mar 4 13:40:38 2023
> >> New Revision: 1908060
> >>
> >> URL: http://svn.apache.org/viewvc?rev=1908060&view=rev
> >> Log:
> >> Test case updates related to macOS ventura changes:
> >>
> >> - python 3.11 deprecates the `cg` module, replacing
> >> url query and multipart form-data handling with new code
> >> - adaptions to changes in openssl/curl behaviours
> >> - all mod_tls test cases now have prefix `test_tls_` for
> >> easier scoping.
> >
> > This seems to be failing:
> >
> > https://github.com/apache/httpd/actions/runs/4341851149/jobs/7581956398
> >
> > 1) Maybe some new pypi requirement or something? Looks like the CGI
> > scripts are now giving 500 errors.
>
> Yes, for the deprecated `cgi` python module, the `multipart` module
> is recommended by the PyGods to replace parts of it. I have no idea
> how that is named on ubuntu-latest.

It exists but it is prehistoric or something completely different to
what is in pypi as "multipart" now - apt-get logs say:

Setting up python3-multipart (0.0.5-2) ...

which is not listed here: https://pypi.org/project/multipart/#history

The new error_log is:

[Tue Mar 07 09:34:12.322270 2023] [cgid:error] [pid 51124:tid 139809792149056] [client 127.0.0.1:34504] AH01215: stderr from /home/runner/work/httpd/httpd/test/gen/apache/htdocs/b.mod-tls.test/vars.py: AttributeError: module 'multipart' has no attribute 'parse_form_data'

maybe we should "pip install" the deps here rather than relying on
Ubuntu packages.

> > 2) What is the path to the relevant error_log when running those tests,
> > we can tweak the config to grab that file and upload it for easy
> > diagnosis.
>
> The server error log on all pytests is found in test/gen/apache/logs/error_log. It is cleared on test start.

Thanks, that works at least.

Regards, Joe
Re: svn commit: r1908060 - in /httpd/httpd/trunk/test/modules: http1/htdocs/cgi/ http2/ http2/htdocs/cgi/ md/ tls/ tls/htdocs/a.mod-tls.test/ tls/htdocs/b.mod-tls.test/ [ In reply to ]
On 3/7/23 11:04 AM, Joe Orton wrote:
> On Tue, Mar 07, 2023 at 09:15:59AM +0100, Stefan Eissing via dev wrote:
>>
>>
>>> Am 06.03.2023 um 17:53 schrieb Joe Orton <jorton@redhat.com>:
>>>
>>> [resent to dev@]
>>>
>>> On Sat, Mar 04, 2023 at 01:40:39PM -0000, icing@apache.org wrote:
>>>> Author: icing
>>>> Date: Sat Mar 4 13:40:38 2023
>>>> New Revision: 1908060
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1908060&view=rev
>>>> Log:
>>>> Test case updates related to macOS ventura changes:
>>>>
>>>> - python 3.11 deprecates the `cg` module, replacing
>>>> url query and multipart form-data handling with new code
>>>> - adaptions to changes in openssl/curl behaviours
>>>> - all mod_tls test cases now have prefix `test_tls_` for
>>>> easier scoping.
>>>
>>> This seems to be failing:
>>>
>>> https://github.com/apache/httpd/actions/runs/4341851149/jobs/7581956398
>>>
>>> 1) Maybe some new pypi requirement or something? Looks like the CGI
>>> scripts are now giving 500 errors.
>>
>> Yes, for the deprecated `cgi` python module, the `multipart` module
>> is recommended by the PyGods to replace parts of it. I have no idea
>> how that is named on ubuntu-latest.
>
> It exists but it is prehistoric or something completely different to
> what is in pypi as "multipart" now - apt-get logs say:
>
> Setting up python3-multipart (0.0.5-2) ...
>
> which is not listed here: https://pypi.org/project/multipart/#history
>
> The new error_log is:
>
> [Tue Mar 07 09:34:12.322270 2023] [cgid:error] [pid 51124:tid 139809792149056] [client 127.0.0.1:34504] AH01215: stderr from /home/runner/work/httpd/httpd/test/gen/apache/htdocs/b.mod-tls.test/vars.py: AttributeError: module 'multipart' has no attribute 'parse_form_data'
>
> maybe we should "pip install" the deps here rather than relying on
> Ubuntu packages.

+1

Regards

RĂ¼diger