Mailing List Archive

On Fri, Jul 31, 2020 at 3:37 PM Rainer Jung <rainer.jung@kippdata.de> wrote:
>
> Since there wasn't yet any reaction to Daniel's question: Is anybody
> right now working on more warnings fixes for Windows?
>
> The most prominent one (missing APLOGNo number = missing macro argument)
> IMHO was already fixed by Christophe in r1880438. Anything else worth
> waiting for or are we (is Daniel) good to go for 2.4.46?

I think we are OK to T&R again.

>
> Concerning lua I'd say the fix(es) for 5.4.0 need a bit more testing.

+1


Regards;
Yann.

On Fri, Jul 31, 2020 at 9:37 AM Rainer Jung <rainer.jung@kippdata.de> wrote:
>
> Since there wasn't yet any reaction to Daniel's question: Is anybody
> right now working on more warnings fixes for Windows?
>

Not me. I don't think we should wait on them.

> The most prominent one (missing APLOGNo number = missing macro argument)
> IMHO was already fixed by Christophe in r1880438. Anything else worth
> waiting for or are we (is Daniel) good to go for 2.4.46?

Good to go from my POV.

> Concerning lua I'd say the fix(es) for 5.4.0 need a bit more testing.

+1

Le 31/07/2020 à 15:36, Rainer Jung a écrit :
> Since there wasn't yet any reaction to Daniel's question: Is anybody
> right now working on more warnings fixes for Windows?
>
> The most prominent one (missing APLOGNo number = missing macro
> argument) IMHO was already fixed by Christophe in r1880438. Anything
> else worth waiting for or are we (is Daniel) good to go for 2.4.46?
>
> Concerning lua I'd say the fix(es) for 5.4.0 need a bit more testing.
>
> Regards,
>
> Rainer
>
> Am 30.07.2020 um 22:26 schrieb Daniel Ruggeri:
>> Hi, all;
>>     I thank everyone for their testing and quick feedback. While we had
>> enough votes and positive feedback, we have some easily fixable warnings
>> which have precedence for holding up a release.
>>
>>     To that end, I will close this vote and declare 2.4.45 dead on
>> the vine.
>>
>>     I will roll 2.4.46 when we are all buttoned up with the warnings.
>
IMHO, good to go as-is.

The warning with VC built on Windows are mostly related to int vs
size_t. Not really an issue for me.
They should be fixed whenever possible, but it can wait.

Some can be triggered by gcc with -Wextra.
This could maybe be added in the maintainer built.

CJ

+1

> On Jul 31, 2020, at 9:41 AM, Eric Covener <covener@gmail.com> wrote:
>
> On Fri, Jul 31, 2020 at 9:37 AM Rainer Jung <rainer.jung@kippdata.de> wrote:
>>
>> Since there wasn't yet any reaction to Daniel's question: Is anybody
>> right now working on more warnings fixes for Windows?
>>
>
> Not me. I don't think we should wait on them.
>
>> The most prominent one (missing APLOGNo number = missing macro argument)
>> IMHO was already fixed by Christophe in r1880438. Anything else worth
>> waiting for or are we (is Daniel) good to go for 2.4.46?
>
> Good to go from my POV.
>
>> Concerning lua I'd say the fix(es) for 5.4.0 need a bit more testing.
>
> +1

Rainer Jung in gmane.comp.apache.devel (Fri, 31 Jul 2020 15:36:16
+0200):
>Since there wasn't yet any reaction to Daniel's question: Is anybody
>right now working on more warnings fixes for Windows?

AFAIK, Steffen is not working on them and nobody else from the
Apachelounge or Apachehaus community.

>The most prominent one (missing APLOGNo number = missing macro argument)
>IMHO was already fixed by Christophe in r1880438. Anything else worth
>waiting for or are we (is Daniel) good to go for 2.4.46?

I had alredy built and tested 2.4.45 for Windows my self. If the APLOGNO
fix is there it is a +1 for 2.4.46 as well.
--
Jan

Since here were lots of "good-to-go, let's roll" one note though: the
current CHANGES does not yet a section for 2.4.46, cause normally
APLOGNO doesn't get noted on CHANGES. In this case it might be something
like

*) mod_proxy_fcgi: Fix build on Windows.

and credits for Eric (who fixed it on trunk) oand/or Christophe, who
backported it.

Best regards,

Rainer

Am 31.07.2020 um 15:36 schrieb Rainer Jung:
> Since there wasn't yet any reaction to Daniel's question: Is anybody
> right now working on more warnings fixes for Windows?
>
> The most prominent one (missing APLOGNo number = missing macro argument)
> IMHO was already fixed by Christophe in r1880438. Anything else worth
> waiting for or are we (is Daniel) good to go for 2.4.46?
>
> Concerning lua I'd say the fix(es) for 5.4.0 need a bit more testing.
>
> Regards,
>
> Rainer
>
> Am 30.07.2020 um 22:26 schrieb Daniel Ruggeri:
>> Hi, all;
>>     I thank everyone for their testing and quick feedback. While we had
>> enough votes and positive feedback, we have some easily fixable warnings
>> which have precedence for holding up a release.
>>
>>     To that end, I will close this vote and declare 2.4.45 dead on the
>> vine.
>>
>>     I will roll 2.4.46 when we are all buttoned up with the warnings.

Below said : *) mod_proxy_fcgi: Fix build on Windows

Not agree, just say what really happened.

Better : *) mod_proxy_fcgi: Fix missing macro argument

No, not a fix for build on windows., was/is building fine. APLOGNO is used on all platforms, only a list of warnings from my Windows build was showing a APLOGNO warning.


------------ Begin Message ------------
B Group: gmane.comp.apache.devel
MsgID: <81701411-6eea-85cb-4f3f-eef114069308@kippdata.de>

Since here were lots of "good-to-go, let's roll" one note though: the
current CHANGES does not yet a section for 2.4.46, cause normally
APLOGNO doesn't get noted on CHANGES. In this case it might be something
like

*) mod_proxy_fcgi: Fix build on Windows.

and credits for Eric (who fixed it on trunk) oand/or Christophe, who
backported it.

Best regards,

Rainer

Am 31.07.2020 um 15:36 schrieb Rainer Jung:
>Since there wasn't yet any reaction to Daniel's question: Is anybody
>right now working on more warnings fixes for Windows?
>
>The most prominent one (missing APLOGNo number =)
>IMHO was already fixed by Christophe in r1880438. Anything else worth
>waiting for or are we (is Daniel) good to go for 2.4.46?
>
>Concerning lua I'd say the fix(es) for 5.4.0 need a bit more testing.
>
>Regards,
>
>Rainer
>
>Am 30.07.2020 um 22:26 schrieb Daniel Ruggeri:
>>Hi, all;
>> I thank everyone for their testing and quick feedback. While we had
>>enough votes and positive feedback, we have some easily fixable warnings
>>which have precedence for holding up a release.
>>
>> To that end, I will close this vote and declare 2.4.45 dead on the
>>vine.
>>
>> I will roll 2.4.46 when we are all buttoned up with the warnings.



------------- End Message -------------

Agreed - thank you (everyone) for the quick rally to fix this and for
confirming we don't have other work needing to be done. I apologize for
taking almost 24 hours to ACK and get us moving again.

I've updated CHANGES and will send a VOTE shortly

--
Daniel Ruggeri

On 7/31/2020 1:28 PM, Rainer Jung wrote:
> Since here were lots of "good-to-go, let's roll" one note though: the
> current CHANGES does not yet a section for 2.4.46, cause normally
> APLOGNO doesn't get noted on CHANGES. In this case it might be
> something like
>
>   *) mod_proxy_fcgi: Fix build on Windows.
>
> and credits for Eric (who fixed it on trunk) oand/or Christophe, who
> backported it.
>
> Best regards,
>
> Rainer
>
> Am 31.07.2020 um 15:36 schrieb Rainer Jung:
>> Since there wasn't yet any reaction to Daniel's question: Is anybody
>> right now working on more warnings fixes for Windows?
>>
>> The most prominent one (missing APLOGNo number = missing macro
>> argument) IMHO was already fixed by Christophe in r1880438. Anything
>> else worth waiting for or are we (is Daniel) good to go for 2.4.46?
>>
>> Concerning lua I'd say the fix(es) for 5.4.0 need a bit more testing.
>>
>> Regards,
>>
>> Rainer
>>
>> Am 30.07.2020 um 22:26 schrieb Daniel Ruggeri:
>>> Hi, all;
>>>     I thank everyone for their testing and quick feedback. While we had
>>> enough votes and positive feedback, we have some easily fixable
>>> warnings
>>> which have precedence for holding up a release.
>>>
>>>     To that end, I will close this vote and declare 2.4.45 dead on
>>> the vine.
>>>
>>>     I will roll 2.4.46 when we are all buttoned up with the warnings.