Mailing List Archive

>
>
> Eww, I noticed summink more fundamental than just religious issues...
>
> Notice something r0ng about this line?
>
> ...
> if ((r->finfo.st_mode == 0 || (r->path_info && *r->path_info)) {

Well, I inherited the "r->finfo.st_mode == 0", and I must say that I haven't
entirely decided what it means. So if it is that you doubt, feel free.
Otherwise I see nothing wrong.

> ...
>
> Ay [feeling like someone must have pointed this out before now...]

--
Ben Laurie Phone: +44 (181) 994 6435
Freelance Consultant Fax: +44 (181) 994 6472
and Technical Director Email: ben@algroup.co.uk
A.L. Digital Ltd,
London, England.

>
> > > if ((r->finfo.st_mode == 0 || (r->path_info && *r->path_info)) {
> >
> > Well, I inherited the "r->finfo.st_mode == 0", and I must say that I haven't
> > entirely decided what it means. So if it is that you doubt, feel free.
> > Otherwise I see nothing wrong.
>
> It doesn't compile. The () pairing is rong.

Sabotage!

Actually, this is most odd. The extra bracket (the first one) is NOT PRESENT
in the original patch (on my machine). The line reads:

if (r->finfo.st_mode == 0 || (r->path_info && *r->path_info)) {

in the original. How on Earth did that extra bracket get there? Obviously
it was not present when I generated the patch, I compiled and tested it!
And it certainly isn't there now. But it is there in the patches dir.
Did someone helpfully "correct" it?

> > Ben Laurie Phone: +44 (181) 994 6435
>
> Ay.

--
Ben Laurie Phone: +44 (181) 994 6435
Freelance Consultant Fax: +44 (181) 994 6472
and Technical Director Email: ben@algroup.co.uk
A.L. Digital Ltd,
London, England.

FYI, if r->finf.st_mode is zero, then the file is just not there (it's
already been checked in directory_walk, and there's no reason to stat
the thing again).

rst

> > if ((r->finfo.st_mode == 0 || (r->path_info && *r->path_info)) {
>
> Well, I inherited the "r->finfo.st_mode == 0", and I must say that I haven't
> entirely decided what it means. So if it is that you doubt, feel free.
> Otherwise I see nothing wrong.

It doesn't compile. The () pairing is rong.

> Ben Laurie Phone: +44 (181) 994 6435

Ay.