Mailing List Archive

[Bug 67860] mod_tls: Fails to build with rustls_ffi 0.11.0
https://bz.apache.org/bugzilla/show_bug.cgi?id=67860

Bernard Spil <brnrd@freebsd.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
OS| |All
Summary|mod_http |mod_tls: Fails to build
| |with rustls_ffi 0.11.0

--- Comment #1 from Bernard Spil <brnrd@freebsd.org> ---
There's been some juggling of names between rustls_ffi 0.10.0 and 0.11.0, the
mod_tls module fails to build

```
./tls_cert.h:196:11: error: unknown type name 'rustls_client_cert_verifier'
const rustls_client_cert_verifier **pverifier);
^
./tls_cert.h:209:11: error: unknown type name
'rustls_client_cert_verifier_optional'
const rustls_client_cert_verifier_optional **pverifier);
^
tls_cert.c:452:11: error: unknown type name 'rustls_client_cert_verifier'
const rustls_client_cert_verifier *client_verifier;
^

tls_cert.c:453:11: error:
unknown type name 'rustls_client_cert_verifier_optional'
const rustls_client_cert_verifier_optional *client_verifier_opt;
^
tls_cert.c:461:9: warning: implicit declaration of function
'rustls_client_cert_verifier_free' is invalid in C99
[-Wimplicit-function-declaration]

rustls_client_cert_verifier_free(entry->client_verifier);
^
tls_cert.c:465:9: warning: implicit declaration of function
'rustls_client_cert_verifier_optional_free' is invalid in C99
[-Wimplicit-function-declaration]

rustls_client_cert_verifier_optional_free(entry->client_verifier_opt);
^
tls_cert.c:517:11: error: unknown type name 'rustls_client_cert_verifier'
const rustls_client_cert_verifier **pverifier)

^


tls_cert.c:527:34: warning: implicit declaration of function
'rustls_client_cert_verifier_new' is invalid in C99
[-Wimplicit-function-declaration]
entry->client_verifier = rustls_client_cert_verifier_new(store);
^
tls_cert.c:543:11: error: unknown type name
'rustls_client_cert_verifier_optional'
const rustls_client_cert_verifier_optional **pverifier)
^
tls_cert.c:553:38: warning: implicit declaration of function
'rustls_client_cert_verifier_optional_new' is invalid in C99
[-Wimplicit-function-declaration]
entry->client_verifier_opt =
rustls_client_cert_verifier_optional_new(store);

^

4 warnings and 6
errors generated.
```

From the https://github.com/rustls/rustls-ffi/blob/main/CHANGELOG.md


rustls_client_cert_verifier became
rustls_allow_any_authenticated_client_verifier and must be constructed from a
rustls_allow_any_authenticated_client_builder.
rustls_client_cert_verifier_optional became
rustls_allow_any_anonymous_or_authenticated_client_verifier and must be
constructed from a rustls_allow_any_anonymous_or_authenticated_client_builder.

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 67860] mod_tls: Fails to build with rustls_ffi 0.11.0 [ In reply to ]
https://bz.apache.org/bugzilla/show_bug.cgi?id=67860

Bernard Spil <brnrd@freebsd.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |icing@apache.org

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 67860] mod_tls: Fails to build with rustls_ffi 0.11.0 [ In reply to ]
https://bz.apache.org/bugzilla/show_bug.cgi?id=67860

--- Comment #2 from Stefan Eissing <stefan@eissing.org> ---
Have they broken the API again?

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 67860] mod_tls: Fails to build with rustls_ffi 0.11.0 [ In reply to ]
https://bz.apache.org/bugzilla/show_bug.cgi?id=67860

--- Comment #3 from Bernard Spil <brnrd@freebsd.org> ---
Looks like it.

Builds OK with rustls_ffi 0.10.0.

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 67860] mod_tls: Fails to build with rustls_ffi 0.11.0 [ In reply to ]
https://bz.apache.org/bugzilla/show_bug.cgi?id=67860

--- Comment #4 from Stefan Eissing <stefan@eissing.org> ---
I think we skip v0.11.0 and see what new name changes v0.12.0 brings.

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org