Mailing List Archive: [PATCH] [LIBELF] Print phdr addresses when loading

[PATCH] [LIBELF] Print phdr addresses when loading

Feb 9, 2007, 12:24 PM

Post #1 of 3 (51 views)

# HG changeset patch
# User Hollis Blanchard <hollisb@us.ibm.com>
# Date 1171052336 21600
# Node ID bbbbab538b8802fde10139f0c2ae7307c1ecf812
# Parent f63c8b64840956b95a911387e1de6f76bd3dc3d5
[LIBELF] Print phdr addresses when loading.
Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com>

diff -r f63c8b648409 -r bbbbab538b88 xen/common/libelf/libelf-loader.c
--- a/xen/common/libelf/libelf-loader.c Wed Feb 07 18:53:37 2007 -0600
+++ b/xen/common/libelf/libelf-loader.c Fri Feb 09 14:18:56 2007 -0600
@@ -128,6 +128,8 @@ void elf_load_binary(struct elf_binary *
filesz = elf_uval(elf, phdr, p_filesz);
memsz = elf_uval(elf, phdr, p_memsz);
dest = elf_get_ptr(elf, paddr);
+ elf_msg(elf, "%s: phdr %" PRIu64 " at 0x%p -> 0x%p\n",
+ __func__, i, dest, dest + filesz);
memcpy(dest, elf->image + offset, filesz);
memset(dest + filesz, 0, memsz - filesz);
}

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH] [LIBELF] Print phdr addresses when loading [ In reply to ]

kraxel at suse

Feb 12, 2007, 3:05 AM

Post #2 of 3 (50 views)

Permalink

Hollis Blanchard wrote:
> # HG changeset patch
> # User Hollis Blanchard <hollisb@us.ibm.com>
> # Date 1171052336 21600
> # Node ID bbbbab538b8802fde10139f0c2ae7307c1ecf812
> # Parent f63c8b64840956b95a911387e1de6f76bd3dc3d5
> [LIBELF] Print phdr addresses when loading.

elf_parse_binary() prints them already ...
Why print them again?

cheers,
Gerd

--
Gerd Hoffmann <kraxel@suse.de>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH] [LIBELF] Print phdr addresses when loading [ In reply to ]

hollisb at us

Feb 12, 2007, 8:46 AM

Post #3 of 3 (50 views)

Permalink

On Mon, 2007-02-12 at 11:05 +0100, Gerd Hoffmann wrote:
> Hollis Blanchard wrote:
> > # HG changeset patch
> > # User Hollis Blanchard <hollisb@us.ibm.com>
> > # Date 1171052336 21600
> > # Node ID bbbbab538b8802fde10139f0c2ae7307c1ecf812
> > # Parent f63c8b64840956b95a911387e1de6f76bd3dc3d5
> > [LIBELF] Print phdr addresses when loading.
>
> elf_parse_binary() prints them already ...
> Why print them again?

It's not just the address contained in the phdr; it's the address the
phdr is being loaded at. Seeing the calculation of elf_get_ptr() is
important.

--
Hollis Blanchard
IBM Linux Technology Center

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel