Advanced
Mailing List Archive

Mailing List Archive

  1. Home >
  2. Xen>
  3. Devel
[HVM][XENOPROFILE][PATCH] fix reversed test for mode function
thomas.woller at amd
Nov 30, 2006, 2:16 PM
Post #1 of 2 (36 views)
Permalink
Keir,
This patch fixes incorrect logic in the recently added
xenoprofile_get_mode() function.
On HVM guests the !guest_mode(regs) test will always succeed, so move
the is_hvm_vcpu() test first.
This change allows modes other than 2 to be returned properly for
xenoprofile for HVM guests.

Signed-off-by: Tom Woller <thomas.woller@amd.com>
Please apply to xen-unstable.hg.

--Tom

Attached Files:

Re: [HVM][XENOPROFILE][PATCH] fix reversed test for mode function [ In reply to ]
keir at xensource
Dec 1, 2006, 12:54 AM
Post #2 of 2 (37 views)
Permalink
On 30/11/06 9:16 pm, "Woller, Thomas" <thomas.woller@amd.com> wrote:

> This patch fixes incorrect logic in the recently added
> xenoprofile_get_mode() function.
> On HVM guests the !guest_mode(regs) test will always succeed, so move
> the is_hvm_vcpu() test first.
> This change allows modes other than 2 to be returned properly for
> xenoprofile for HVM guests.
>
> Signed-off-by: Tom Woller <thomas.woller@amd.com>
> Please apply to xen-unstable.hg.

This is wrong. The actual problem is that you should be passing
guest_cpu_user_regs() to xenoprofile_get_mode(). I'll fix that.

-- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

©2024 GT.net. A Gossamer Threads company.
5th Floor, 455 Granville St., Vancouver, BC V6C 1T1, Canada | Legal