Mailing List Archive: [PATCH][TOOLS] Fix typo in error

[PATCH][TOOLS] Fix typo in error

Nov 14, 2006, 4:34 PM

Post #1 of 3 (63 views)

We increase reservations by exentes not pages.

Signed-off-by: Jimi Xenidis <jimix@watson.ibm.com>

--
diff -r e7a54ea14057 tools/libxc/xc_domain.c
--- a/tools/libxc/xc_domain.c Mon Nov 13 12:35:17 2006 -0600
+++ b/tools/libxc/xc_domain.c Tue Nov 14 18:34:15 2006 -0500
@@ -352,7 +352,7 @@ int xc_domain_memory_increase_reservatio
if ( err >= 0 )
{
DPRINTF("Failed allocation for dom %d: "
- "%ld pages order %d addr_bits %d\n",
+ "%ld extents of order %d addr_bits %d\n",
domid, nr_extents, extent_order, address_bits);
errno = ENOMEM;
err = -1;
@@ -390,7 +390,7 @@ int xc_domain_memory_decrease_reservatio

if ( err >= 0 )
{
- DPRINTF("Failed deallocation for dom %d: %ld pages order %d\n",
+ DPRINTF("Failed deallocation for dom %d: %ld extents of order %d\n",
domid, nr_extents, extent_order);
errno = EINVAL;
err = -1;
@@ -421,7 +421,7 @@ int xc_domain_memory_populate_physmap(in

if ( err >= 0 )
{
- DPRINTF("Failed allocation for dom %d: %ld pages order %d\n",
+ DPRINTF("Failed allocation for dom %d: %ld externs of order %d\n",
domid, nr_extents, extent_order);
errno = EBUSY;
err = -1;

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH][TOOLS] Fix typo in error [ In reply to ]

russell.blaine at sun

Nov 14, 2006, 4:39 PM

Post #2 of 3 (60 views)

Permalink

The third diff has "externs" instead of "extents" - was that intentional?

Jimi Xenidis wrote:
> We increase reservations by exentes not pages.
>
> Signed-off-by: Jimi Xenidis <jimix@watson.ibm.com>
>
> --
> diff -r e7a54ea14057 tools/libxc/xc_domain.c
> --- a/tools/libxc/xc_domain.c Mon Nov 13 12:35:17 2006 -0600
> +++ b/tools/libxc/xc_domain.c Tue Nov 14 18:34:15 2006 -0500
> @@ -352,7 +352,7 @@ int xc_domain_memory_increase_reservatio
> if ( err >= 0 )
> {
> DPRINTF("Failed allocation for dom %d: "
> - "%ld pages order %d addr_bits %d\n",
> + "%ld extents of order %d addr_bits %d\n",
> domid, nr_extents, extent_order, address_bits);
> errno = ENOMEM;
> err = -1;
> @@ -390,7 +390,7 @@ int xc_domain_memory_decrease_reservatio
>
> if ( err >= 0 )
> {
> - DPRINTF("Failed deallocation for dom %d: %ld pages order %d\n",
> + DPRINTF("Failed deallocation for dom %d: %ld extents of order %d\n",
> domid, nr_extents, extent_order);
> errno = EINVAL;
> err = -1;
> @@ -421,7 +421,7 @@ int xc_domain_memory_populate_physmap(in
>
> if ( err >= 0 )
> {
> - DPRINTF("Failed allocation for dom %d: %ld pages order %d\n",
> + DPRINTF("Failed allocation for dom %d: %ld externs of order %d\n",
> domid, nr_extents, extent_order);
> errno = EBUSY;
> err = -1;
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

--

-----------------------------------------------------
Russ Blaine | Solaris Kernel | russell.blaine@sun.com

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH][TOOLS] Fix typo in error [ In reply to ]

jimix at watson

Nov 14, 2006, 4:41 PM

Post #3 of 3 (61 views)

Permalink

On Nov 14, 2006, at 6:39 PM, Russ Blaine wrote:

> The third diff has "externs" instead of "extents" - was that
> intentional?

Good eye, no its my typo, fingers remember better than my brain
sometimes ;-)

>
> Jimi Xenidis wrote:
>> We increase reservations by exentes not pages.
>> Signed-off-by: Jimi Xenidis <jimix@watson.ibm.com>
>> --
>> diff -r e7a54ea14057 tools/libxc/xc_domain.c
>> --- a/tools/libxc/xc_domain.c Mon Nov 13 12:35:17 2006 -0600
>> +++ b/tools/libxc/xc_domain.c Tue Nov 14 18:34:15 2006 -0500
>> @@ -352,7 +352,7 @@ int xc_domain_memory_increase_reservatio
>> if ( err >= 0 )
>> {
>> DPRINTF("Failed allocation for dom %d: "
>> - "%ld pages order %d addr_bits %d\n",
>> + "%ld extents of order %d addr_bits %d\n",
>> domid, nr_extents, extent_order, address_bits);
>> errno = ENOMEM;
>> err = -1;
>> @@ -390,7 +390,7 @@ int xc_domain_memory_decrease_reservatio
>> if ( err >= 0 )
>> {
>> - DPRINTF("Failed deallocation for dom %d: %ld pages order %
>> d\n",
>> + DPRINTF("Failed deallocation for dom %d: %ld extents of
>> order %d\n",
>> domid, nr_extents, extent_order);
>> errno = EINVAL;
>> err = -1;
>> @@ -421,7 +421,7 @@ int xc_domain_memory_populate_physmap(in
>> if ( err >= 0 )
>> {
>> - DPRINTF("Failed allocation for dom %d: %ld pages order %d
>> \n",
>> + DPRINTF("Failed allocation for dom %d: %ld externs of
>> order %d\n",
>> domid, nr_extents, extent_order);
>> errno = EBUSY;
>> err = -1;
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xensource.com
>> http://lists.xensource.com/xen-devel
>
> --
>
> -----------------------------------------------------
> Russ Blaine | Solaris Kernel | russell.blaine@sun.com

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel