Mailing List Archive

[PATCH v2 08/13] tools/xenstore: remove unused events list
struct watch contains an used struct list_head events. Remove it.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
tools/xenstore/xenstored_watch.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/tools/xenstore/xenstored_watch.c b/tools/xenstore/xenstored_watch.c
index e8eb35de02..4195c59e17 100644
--- a/tools/xenstore/xenstored_watch.c
+++ b/tools/xenstore/xenstored_watch.c
@@ -36,9 +36,6 @@ struct watch
/* Watches on this connection */
struct list_head list;

- /* Current outstanding events applying to this watch. */
- struct list_head events;
-
/* Offset into path for skipping prefix (used for relative paths). */
unsigned int prefix_len;

@@ -205,8 +202,6 @@ static struct watch *add_watch(struct connection *conn, char *path, char *token,

watch->prefix_len = relative ? strlen(get_implicit_path(conn)) + 1 : 0;

- INIT_LIST_HEAD(&watch->events);
-
domain_watch_inc(conn);
list_add_tail(&watch->list, &conn->watches);
talloc_set_destructor(watch, destroy_watch);
--
2.35.3
Re: [PATCH v2 08/13] tools/xenstore: remove unused events list [ In reply to ]
Hi Juergen,

On 30/03/2023 09:50, Juergen Gross wrote:
> struct watch contains an used struct list_head events. Remove it.

Typo: s/used/unused/?

>
> Signed-off-by: Juergen Gross <jgross@suse.com>

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

> ---
> tools/xenstore/xenstored_watch.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/tools/xenstore/xenstored_watch.c b/tools/xenstore/xenstored_watch.c
> index e8eb35de02..4195c59e17 100644
> --- a/tools/xenstore/xenstored_watch.c
> +++ b/tools/xenstore/xenstored_watch.c
> @@ -36,9 +36,6 @@ struct watch
> /* Watches on this connection */
> struct list_head list;
>
> - /* Current outstanding events applying to this watch. */
> - struct list_head events;
> -
> /* Offset into path for skipping prefix (used for relative paths). */
> unsigned int prefix_len;
>
> @@ -205,8 +202,6 @@ static struct watch *add_watch(struct connection *conn, char *path, char *token,
>
> watch->prefix_len = relative ? strlen(get_implicit_path(conn)) + 1 : 0;
>
> - INIT_LIST_HEAD(&watch->events);
> -
> domain_watch_inc(conn);
> list_add_tail(&watch->list, &conn->watches);
> talloc_set_destructor(watch, destroy_watch);

--
Julien Grall
Re: [PATCH v2 08/13] tools/xenstore: remove unused events list [ In reply to ]
On 03.05.23 15:08, Julien Grall wrote:
> Hi Juergen,
>
> On 30/03/2023 09:50, Juergen Gross wrote:
>> struct watch contains an used struct list_head events. Remove it.
>
> Typo: s/used/unused/?

Yes.

>
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>
> Acked-by: Julien Grall <jgrall@amazon.com>

Thanks,


Juergen