Mailing List Archive

[PATCH v2 07/17] xen/device-tree: Add dt_property_read_u32_array helper
Based on tag Linux v5.14.2 commit bbdd3de144fc142f2f4b9834c9241cc4e7f3d3fc

Import the Linux helper of_property_read_u32_array. This function find
and read an array of 32 bit integers from a property.

Signed-off-by: Rahul Singh <rahul.singh@arm.com>
---
Change in v2: Patch introduced in v2
---
xen/include/xen/device_tree.h | 31 ++++++++++++++++++++++++++++++-
1 file changed, 30 insertions(+), 1 deletion(-)

diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h
index 1693fb8e8c..497144b8a7 100644
--- a/xen/include/xen/device_tree.h
+++ b/xen/include/xen/device_tree.h
@@ -366,7 +366,6 @@ bool_t dt_property_read_u32(const struct dt_device_node *np,
bool_t dt_property_read_u64(const struct dt_device_node *np,
const char *name, u64 *out_value);

-
/**
* dt_property_read_variable_u32_array - Find and read an array of 32 bit
* integers from a property, with bounds on the minimum and maximum array size.
@@ -392,6 +391,36 @@ int dt_property_read_variable_u32_array(const struct dt_device_node *np,
const char *propname, u32 *out_values,
size_t sz_min, size_t sz_max);

+/**
+ * dt_property_read_u32_array - Find and read an array of 32 bit integers
+ * from a property.
+ *
+ * @np: device node from which the property value is to be read.
+ * @propname: name of the property to be searched.
+ * @out_values: pointer to return value, modified only if return value is 0.
+ * @sz: number of array elements to read
+ *
+ * Search for a property in a device node and read 32-bit value(s) from
+ * it.
+ *
+ * Return: 0 on success, -EINVAL if the property does not exist,
+ * -ENODATA if property does not have a value, and -EOVERFLOW if the
+ * property data isn't large enough.
+ *
+ * The out_values is modified only if a valid u32 value can be decoded.
+ */
+static inline int dt_property_read_u32_array(const struct dt_device_node *np,
+ const char *propname,
+ u32 *out_values, size_t sz)
+{
+ int ret = dt_property_read_variable_u32_array(np, propname, out_values,
+ sz, 0);
+ if ( ret >= 0 )
+ return 0;
+ else
+ return ret;
+}
+
/**
* dt_property_read_bool - Check if a property exists
* @np: node to get the value
--
2.17.1
Re: [PATCH v2 07/17] xen/device-tree: Add dt_property_read_u32_array helper [ In reply to ]
On Wed, 22 Sep 2021, Rahul Singh wrote:
> Based on tag Linux v5.14.2 commit bbdd3de144fc142f2f4b9834c9241cc4e7f3d3fc

Please use a commit it from Linux upstream, not stable


> Import the Linux helper of_property_read_u32_array. This function find
> and read an array of 32 bit integers from a property.
>
> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
> ---
> Change in v2: Patch introduced in v2
> ---
> xen/include/xen/device_tree.h | 31 ++++++++++++++++++++++++++++++-
> 1 file changed, 30 insertions(+), 1 deletion(-)
>
> diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h
> index 1693fb8e8c..497144b8a7 100644
> --- a/xen/include/xen/device_tree.h
> +++ b/xen/include/xen/device_tree.h
> @@ -366,7 +366,6 @@ bool_t dt_property_read_u32(const struct dt_device_node *np,
> bool_t dt_property_read_u64(const struct dt_device_node *np,
> const char *name, u64 *out_value);
>
> -
> /**
> * dt_property_read_variable_u32_array - Find and read an array of 32 bit
> * integers from a property, with bounds on the minimum and maximum array size.

Spurious change


> @@ -392,6 +391,36 @@ int dt_property_read_variable_u32_array(const struct dt_device_node *np,
> const char *propname, u32 *out_values,
> size_t sz_min, size_t sz_max);
>
> +/**
> + * dt_property_read_u32_array - Find and read an array of 32 bit integers
> + * from a property.
> + *
> + * @np: device node from which the property value is to be read.
> + * @propname: name of the property to be searched.
> + * @out_values: pointer to return value, modified only if return value is 0.
> + * @sz: number of array elements to read
> + *
> + * Search for a property in a device node and read 32-bit value(s) from
> + * it.
> + *
> + * Return: 0 on success, -EINVAL if the property does not exist,
> + * -ENODATA if property does not have a value, and -EOVERFLOW if the
> + * property data isn't large enough.
> + *
> + * The out_values is modified only if a valid u32 value can be decoded.
> + */
> +static inline int dt_property_read_u32_array(const struct dt_device_node *np,
> + const char *propname,
> + u32 *out_values, size_t sz)
> +{
> + int ret = dt_property_read_variable_u32_array(np, propname, out_values,
> + sz, 0);
> + if ( ret >= 0 )
> + return 0;
> + else
> + return ret;
> +}
> +
> /**
> * dt_property_read_bool - Check if a property exists
> * @np: node to get the value
> --
> 2.17.1
>