Mailing List Archive: [PATCH 3/9] xen/arm: introduce CONFIG_STATIC

[PATCH 3/9] xen/arm: introduce CONFIG_STATIC_ALLOCATION

Jun 6, 2021, 7:43 PM

Post #1 of 4 (30 views)

For now, since the feature of Domain on Static Allocation is only supported
on ARM Architecture, this commit introduces new CONFIG_STATIC_ALLOCATION to
avoid bringing dead codes in other archs.

Signed-off-by: Penny Zheng <penny.zheng@arm.com>
---
changes v2:
- new commit
---
xen/arch/arm/Kconfig | 3 +++
1 file changed, 3 insertions(+)

diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
index ecfa6822e4..f165db8ecd 100644
--- a/xen/arch/arm/Kconfig
+++ b/xen/arch/arm/Kconfig
@@ -278,6 +278,9 @@ config ARM64_ERRATUM_1286807

If unsure, say Y.

+config STATIC_ALLOCATION
+ def_bool y
+
endmenu

config ARM64_HARDEN_BRANCH_PREDICTOR
--
2.25.1

Re: [PATCH 3/9] xen/arm: introduce CONFIG_STATIC_ALLOCATION [ In reply to ]

jbeulich at suse

Jun 6, 2021, 11:17 PM

Post #2 of 4 (30 views)

Permalink

On 07.06.2021 04:43, Penny Zheng wrote:
> --- a/xen/arch/arm/Kconfig
> +++ b/xen/arch/arm/Kconfig
> @@ -278,6 +278,9 @@ config ARM64_ERRATUM_1286807
>
> If unsure, say Y.
>
> +config STATIC_ALLOCATION
> + def_bool y
> +
> endmenu
>
> config ARM64_HARDEN_BRANCH_PREDICTOR

Nit: While this and the following option exhibit bad indentation,
everything up from here looks to be fine, and that's what you want
to take as reference when adding a new option.

Jan

Re: [PATCH 3/9] xen/arm: introduce CONFIG_STATIC_ALLOCATION [ In reply to ]

julien at xen

Jun 30, 2021, 10:45 AM

Post #3 of 4 (28 views)

Permalink

Hi Penny,

On 07/06/2021 03:43, Penny Zheng wrote:
> For now, since the feature of Domain on Static Allocation is only supported
> on ARM Architecture, this commit introduces new CONFIG_STATIC_ALLOCATION to
> avoid bringing dead codes in other archs.

Similarly to patch #2, I think it would be better to introduce this
Kconfig when it is used or after the common code is introduced. This
would prevent dead Kconfig.

Cheers,

> Signed-off-by: Penny Zheng <penny.zheng@arm.com>
> ---
> changes v2:
> - new commit
> ---
> xen/arch/arm/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> index ecfa6822e4..f165db8ecd 100644
> --- a/xen/arch/arm/Kconfig
> +++ b/xen/arch/arm/Kconfig
> @@ -278,6 +278,9 @@ config ARM64_ERRATUM_1286807
>
> If unsure, say Y.
>
> +config STATIC_ALLOCATION
> + def_bool y
> +
> endmenu
>
> config ARM64_HARDEN_BRANCH_PREDICTOR
>

--
Julien Grall

RE: [PATCH 3/9] xen/arm: introduce CONFIG_STATIC_ALLOCATION [ In reply to ]

Penny.Zheng at arm

Jul 4, 2021, 8:16 PM

Post #4 of 4 (28 views)

Permalink

Hi Julien

> -----Original Message-----
> From: Julien Grall <julien@xen.org>
> Sent: Thursday, July 1, 2021 1:45 AM
> To: Penny Zheng <Penny.Zheng@arm.com>; xen-devel@lists.xenproject.org;
> sstabellini@kernel.org; jbeulich@suse.com
> Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>; Wei Chen
> <Wei.Chen@arm.com>
> Subject: Re: [PATCH 3/9] xen/arm: introduce CONFIG_STATIC_ALLOCATION
>
> Hi Penny,
>
> On 07/06/2021 03:43, Penny Zheng wrote:
> > For now, since the feature of Domain on Static Allocation is only
> > supported on ARM Architecture, this commit introduces new
> > CONFIG_STATIC_ALLOCATION to avoid bringing dead codes in other archs.
>
> Similarly to patch #2, I think it would be better to introduce this Kconfig when
> it is used or after the common code is introduced. This would prevent dead
> Kconfig.
>

sure, I'll remove this commit, and combine it with the codes where this config is firstly used.

Cheers

> Cheers,
>
> > Signed-off-by: Penny Zheng <penny.zheng@arm.com>
> > ---
> > changes v2:
> > - new commit
> > ---
> > xen/arch/arm/Kconfig | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index
> > ecfa6822e4..f165db8ecd 100644
> > --- a/xen/arch/arm/Kconfig
> > +++ b/xen/arch/arm/Kconfig
> > @@ -278,6 +278,9 @@ config ARM64_ERRATUM_1286807
> >
> > If unsure, say Y.
> >
> > +config STATIC_ALLOCATION
> > + def_bool y
> > +
> > endmenu
> >
> > config ARM64_HARDEN_BRANCH_PREDICTOR
> >
>
> --
> Julien Grall

--
Penny Zheng