Mailing List Archive

[PATCH 2/3] firmware/shim: drop XEN_CONFIG_EXPERT uses
As of commit d155e4aef35c ("xen: Allow EXPERT mode to be selected from
the menuconfig directly") EXPERT is a regular config option.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/tools/firmware/xen-dir/Makefile
+++ b/tools/firmware/xen-dir/Makefile
@@ -74,10 +74,10 @@ $(D): linkfarm.stamp
$(MAKE) -C $(D)/xen distclean

$(D)/xen/.config: $(D)
- $(MAKE) -C $(@D) KBUILD_DEFCONFIG=pvshim_defconfig XEN_CONFIG_EXPERT=y defconfig
+ $(MAKE) -C $(@D) KBUILD_DEFCONFIG=pvshim_defconfig defconfig

xen-shim: $(D)/xen/.config
- $(MAKE) -C $(<D) build XEN_CONFIG_EXPERT=y
+ $(MAKE) -C $(<D) build
ln -sf $(D)/xen/xen $@
ln -sf $(D)/xen/xen-syms $@-syms
Re: [PATCH 2/3] firmware/shim: drop XEN_CONFIG_EXPERT uses [ In reply to ]
On Fri, Apr 30, 2021 at 04:44:21PM +0200, Jan Beulich wrote:
> As of commit d155e4aef35c ("xen: Allow EXPERT mode to be selected from
> the menuconfig directly") EXPERT is a regular config option.

Might be worth mentioning that the default pvshim config already have
EXPERT selected.

> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Roger Pau Monné <rogerpau@citrix.com>

Thanks, Roger.
Re: [PATCH 2/3] firmware/shim: drop XEN_CONFIG_EXPERT uses [ In reply to ]
On 25.05.2021 16:14, Roger Pau Monné wrote:
> On Fri, Apr 30, 2021 at 04:44:21PM +0200, Jan Beulich wrote:
>> As of commit d155e4aef35c ("xen: Allow EXPERT mode to be selected from
>> the menuconfig directly") EXPERT is a regular config option.
>
> Might be worth mentioning that the default pvshim config already have
> EXPERT selected.

That's not really related, as what the patch is removing is stale
regardless of config, but I've added a remark.

>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> Acked-by: Roger Pau Monné <rogerpau@citrix.com>

Thanks.

Jan