Mailing List Archive

[PATCH] xenstat_netbsd: remove usused code
From: Manuel Bouyer <bouyer@netbsd.org>

remove PROCNETDEV_HEADER[] and read_attributes_vbd(), gcc complains that they
are unused

Signed-off-by: Manuel Bouyer <bouyer@netbsd.org>
---
tools/libs/stat/xenstat_netbsd.c | 11 -----------
1 file changed, 11 deletions(-)

diff --git a/tools/libs/stat/xenstat_netbsd.c b/tools/libs/stat/xenstat_netbsd.c
index 6e9d6aee10..64eda9e1ae 100644
--- a/tools/libs/stat/xenstat_netbsd.c
+++ b/tools/libs/stat/xenstat_netbsd.c
@@ -55,11 +55,6 @@ get_priv_data(xenstat_handle *handle)
}

/* Expected format of /proc/net/dev */
-static const char PROCNETDEV_HEADER[] =
- "Inter-| Receive |"
- " Transmit\n"
- " face |bytes packets errs drop fifo frame compressed multicast|"
- "bytes packets errs drop fifo colls carrier compressed\n";

/* Collect information about networks */
int xenstat_collect_networks(xenstat_node * node)
@@ -76,12 +71,6 @@ void xenstat_uninit_networks(xenstat_handle * handle)
fclose(priv->procnetdev);
}

-static int read_attributes_vbd(const char *vbd_directory, const char *what, char *ret, int cap)
-{
- /* XXX implement */
- return 0;
-}
-
/* Collect information about VBDs */
int xenstat_collect_vbds(xenstat_node * node)
{
--
2.29.2
Re: [PATCH] xenstat_netbsd: remove usused code [ In reply to ]
On Tue, Jan 12, 2021 at 07:12:42PM +0100, Manuel Bouyer wrote:
> From: Manuel Bouyer <bouyer@netbsd.org>
>
> remove PROCNETDEV_HEADER[] and read_attributes_vbd(), gcc complains that they
> are unused
>
> Signed-off-by: Manuel Bouyer <bouyer@netbsd.org>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.