Mailing List Archive

commit 6d317b10f8e4cbc8092c00ce462d79f13e3ca4f6
Author: Michal Orzel <michal.orzel@amd.com>
AuthorDate: Thu Feb 2 09:49:05 2023 +0100
Commit: Julien Grall <jgrall@amazon.com>
CommitDate: Wed Feb 8 13:57:57 2023 +0000

xen/arm: Add support for booting gzip compressed uImages

At the moment, Xen does not support booting gzip compressed uImages.
This is because we are trying to decompress the kernel before probing
the u-boot header. This leads to a failure as the header always appears
at the top of the image (and therefore obscuring the gzip header).

Move the call to kernel_uimage_probe before kernel_decompress and make
the function self-containing by taking the following actions:
- take a pointer to struct bootmodule as a parameter,
- check the comp field of a u-boot header to determine compression type,
- in case of compressed image, call kernel_decompress passing uImage
header size as an offset to gzip header,
- set up zimage.{kernel_addr,len} accordingly,
- return -ENOENT in case of a u-boot header not found to distinguish it
amongst other return values and make it the only case for falling
through to try to probe other image types.

Modify kernel_decompress to take an additional parameter being an offset
to a gzip header from start address. This is needed so that a function
can first operate on a region containing actually compressed kernel (in case
of compressed uImage, size of u-boot header is an offset to a gzip header)
and then at the end pass the entire region (as it was before taking an offset
into account) to fw_unreserved_regions for freeing.

This approach avoids splitting the uImage probing into 2 stages (executed
before and after decompression) which otherwise would be necessary to
properly parse header, update boot module start and size before
decompression and update zimage.{kernel_addr,len} afterwards.

Remove the limitation from the booting.txt documentation.

Signed-off-by: Michal Orzel <michal.orzel@amd.com>
Reviewwed-by: Julien Grall <jgrall@amazon.com>
---
docs/misc/arm/booting.txt | 3 --
xen/arch/arm/kernel.c | 83 +++++++++++++++++++++++++++++++++++++++++------
2 files changed, 73 insertions(+), 13 deletions(-)

diff --git a/docs/misc/arm/booting.txt b/docs/misc/arm/booting.txt
index bd7bfe7f28..02f7bb65ec 100644
--- a/docs/misc/arm/booting.txt
+++ b/docs/misc/arm/booting.txt
@@ -50,9 +50,6 @@ Also, it is to be noted that if user provides the legacy image header on
top of zImage or Image header, then Xen uses the attributes of legacy
image header to determine the load address, entry point, etc.

-Known limitation: compressed kernels with a uboot headers are not
-working.
-

Firmware/bootloader requirements
--------------------------------
diff --git a/xen/arch/arm/kernel.c b/xen/arch/arm/kernel.c
index 068fbf88e4..ca5318515e 100644
--- a/xen/arch/arm/kernel.c
+++ b/xen/arch/arm/kernel.c
@@ -191,7 +191,7 @@ static __init uint32_t output_length(char *image, unsigned long image_len)
return *(uint32_t *)&image[image_len - 4];
}

-static __init int kernel_decompress(struct bootmodule *mod)
+static __init int kernel_decompress(struct bootmodule *mod, uint32_t offset)
{
char *output, *input;
char magic[2];
@@ -204,6 +204,17 @@ static __init int kernel_decompress(struct bootmodule *mod)
paddr_t addr = mod->start;
paddr_t size = mod->size;

+ if ( size < offset )
+ return -EINVAL;
+
+ /*
+ * It might be that gzip header does not appear at the start address
+ * (e.g. in case of compressed uImage) so take into account offset to
+ * gzip header.
+ */
+ addr += offset;
+ size -= offset;
+
if ( size < 2 )
return -EINVAL;

@@ -250,6 +261,14 @@ static __init int kernel_decompress(struct bootmodule *mod)
for ( ; i < (1 << kernel_order_out); i++ )
free_domheap_page(pages + i);

+ /*
+ * When freeing the kernel, we need to pass the module start address and
+ * size as they were before taking an offset to gzip header into account,
+ * so that the entire region will be freed.
+ */
+ addr -= offset;
+ size += offset;
+
/*
* Free the original kernel, update the pointers to the
* decompressed kernel
@@ -265,11 +284,14 @@ static __init int kernel_decompress(struct bootmodule *mod)
#define IH_ARCH_ARM 2 /* ARM */
#define IH_ARCH_ARM64 22 /* ARM64 */

+/* uImage Compression Types */
+#define IH_COMP_GZIP 1
+
/*
* Check if the image is a uImage and setup kernel_info
*/
static int __init kernel_uimage_probe(struct kernel_info *info,
- paddr_t addr, paddr_t size)
+ struct bootmodule *mod)
{
struct {
__be32 magic; /* Image Header Magic Number */
@@ -287,20 +309,30 @@ static int __init kernel_uimage_probe(struct kernel_info *info,
} uimage;

uint32_t len;
+ paddr_t addr = mod->start;
+ paddr_t size = mod->size;

if ( size < sizeof(uimage) )
- return -EINVAL;
+ return -ENOENT;

copy_from_paddr(&uimage, addr, sizeof(uimage));

if ( be32_to_cpu(uimage.magic) != UIMAGE_MAGIC )
- return -EINVAL;
+ return -ENOENT;

len = be32_to_cpu(uimage.size);

if ( len > size - sizeof(uimage) )
return -EINVAL;

+ /* Only gzip compression is supported. */
+ if ( uimage.comp && uimage.comp != IH_COMP_GZIP )
+ {
+ printk(XENLOG_ERR
+ "Unsupported uImage compression type %"PRIu8"\n", uimage.comp);
+ return -EOPNOTSUPP;
+ }
+
info->zimage.start = be32_to_cpu(uimage.load);
info->entry = be32_to_cpu(uimage.ep);

@@ -330,8 +362,27 @@ static int __init kernel_uimage_probe(struct kernel_info *info,
return -EINVAL;
}

- info->zimage.kernel_addr = addr + sizeof(uimage);
- info->zimage.len = len;
+ if ( uimage.comp )
+ {
+ int rc;
+
+ /*
+ * In case of a compressed uImage, the gzip header is right after
+ * the u-boot header, so pass sizeof(uimage) as an offset to gzip
+ * header.
+ */
+ rc = kernel_decompress(mod, sizeof(uimage));
+ if ( rc )
+ return rc;
+
+ info->zimage.kernel_addr = mod->start;
+ info->zimage.len = mod->size;
+ }
+ else
+ {
+ info->zimage.kernel_addr = addr + sizeof(uimage);
+ info->zimage.len = len;
+ }

info->load = kernel_zimage_load;

@@ -561,8 +612,22 @@ int __init kernel_probe(struct kernel_info *info,
printk("Loading ramdisk from boot module @ %"PRIpaddr"\n",
info->initrd_bootmodule->start);

- /* if it is a gzip'ed image, 32bit or 64bit, uncompress it */
- rc = kernel_decompress(mod);
+ /*
+ * uImage header always appears at the top of the image (even compressed),
+ * so it needs to be probed first. Note that in case of compressed uImage,
+ * kernel_decompress is called from kernel_uimage_probe making the function
+ * self-containing (i.e. fall through only in case of a header not found).
+ */
+ rc = kernel_uimage_probe(info, mod);
+ if ( rc != -ENOENT )
+ return rc;
+
+ /*
+ * If it is a gzip'ed image, 32bit or 64bit, uncompress it.
+ * At this point, gzip header appears (if at all) at the top of the image,
+ * so pass 0 as an offset.
+ */
+ rc = kernel_decompress(mod, 0);
if ( rc && rc != -EINVAL )
return rc;

@@ -570,8 +635,6 @@ int __init kernel_probe(struct kernel_info *info,
rc = kernel_zimage64_probe(info, mod->start, mod->size);
if (rc < 0)
#endif
- rc = kernel_uimage_probe(info, mod->start, mod->size);
- if (rc < 0)
rc = kernel_zimage32_probe(info, mod->start, mod->size);

return rc;
--
generated by git-patchbot for /home/xen/git/xen.git#master