Mailing List Archive

commit b9adcb5ab910b61e5332728bd248906e68a45900
Author: Xenia Ragiadakou <burzalodowa@gmail.com>
AuthorDate: Fri Feb 3 21:09:08 2023 +0200
Commit: Julien Grall <jgrall@amazon.com>
CommitDate: Wed Feb 8 08:33:25 2023 +0000

xen/device_tree: remove incorrect and unused dt_irq() and dt_irq_flags() macros

Macro dt_irq() is broken because the macro parameter has the same name with
the struct dt_irq member "irq".
Macro dt_irq_flags() is broken as well because struct dt_irq has no member
named "flags".

Since no one seems to have ever tried to use them and eventually stumble upon
the issues above, remove them instead of fixing them.

Fixes: 886f34045bf0 ("xen/arm: Add helpers to retrieve an interrupt description from the device tree")
Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>
Acked-by: Julien Grall <jgrall@amazon.com>
---
xen/include/xen/device_tree.h | 3 ---
1 file changed, 3 deletions(-)

diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h
index 7839a199e3..19a74909ce 100644
--- a/xen/include/xen/device_tree.h
+++ b/xen/include/xen/device_tree.h
@@ -159,9 +159,6 @@ struct dt_raw_irq {
u32 specifier[DT_MAX_IRQ_SPEC];
};

-#define dt_irq(irq) ((irq)->irq)
-#define dt_irq_flags(irq) ((irq)->flags)
-
typedef int (*device_tree_node_func)(const void *fdt,
int node, const char *name, int depth,
u32 address_cells, u32 size_cells,
--
generated by git-patchbot for /home/xen/git/xen.git#master