Mailing List Archive

commit 43b5d7b14c569e2deaf6a2863cfa44351061ad80
Author: Jan Beulich <jbeulich@suse.com>
AuthorDate: Thu Dec 22 10:08:31 2022 +0100
Commit: Jan Beulich <jbeulich@suse.com>
CommitDate: Thu Dec 22 10:08:31 2022 +0100

x86/shadow: don't open-code copy_domain_page()

Let's use the library-like function that we have.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
xen/arch/x86/mm/shadow/common.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/xen/arch/x86/mm/shadow/common.c b/xen/arch/x86/mm/shadow/common.c
index b0ef574890..e1db6cf890 100644
--- a/xen/arch/x86/mm/shadow/common.c
+++ b/xen/arch/x86/mm/shadow/common.c
@@ -450,7 +450,6 @@ static void _sh_resync(struct vcpu *v, mfn_t gmfn,
static void oos_hash_add(struct vcpu *v, mfn_t gmfn)
{
int i, idx, oidx, swap = 0;
- void *gptr, *gsnpptr;
mfn_t *oos = v->arch.paging.shadow.oos;
mfn_t *oos_snapshot = v->arch.paging.shadow.oos_snapshot;
struct oos_fixup *oos_fixup = v->arch.paging.shadow.oos_fixup;
@@ -483,11 +482,7 @@ static void oos_hash_add(struct vcpu *v, mfn_t gmfn)
if ( swap )
SWAP(oos_snapshot[idx], oos_snapshot[oidx]);

- gptr = map_domain_page(oos[oidx]);
- gsnpptr = map_domain_page(oos_snapshot[oidx]);
- memcpy(gsnpptr, gptr, PAGE_SIZE);
- unmap_domain_page(gptr);
- unmap_domain_page(gsnpptr);
+ copy_domain_page(oos_snapshot[oidx], oos[oidx]);
}

/* Remove an MFN from the list of out-of-sync guest pagetables */
--
generated by git-patchbot for /home/xen/git/xen.git#master