Mailing List Archive

[xen master] tools/ocaml/xenstored: Use ocamldep -sort for linking order
commit 4a259353238d308a41541370ea7cc222a879ddd3
Author: Edwin Török <edvin.torok@citrix.com>
AuthorDate: Fri Dec 16 18:25:11 2022 +0000
Commit: Andrew Cooper <andrew.cooper3@citrix.com>
CommitDate: Mon Dec 19 19:31:26 2022 +0000

tools/ocaml/xenstored: Use ocamldep -sort for linking order

The manually established link order is fragile to code changes. Use ocamldep
to calculate the appropriate link order.

No functional change.

Signed-off-by: Edwin Török <edvin.torok@citrix.com>
Acked-by: Christian Lindig <christian.lindig@citrix.com>
---
tools/ocaml/xenstored/Makefile | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/tools/ocaml/xenstored/Makefile b/tools/ocaml/xenstored/Makefile
index 6f7333926e..e8aaecf2e6 100644
--- a/tools/ocaml/xenstored/Makefile
+++ b/tools/ocaml/xenstored/Makefile
@@ -72,7 +72,11 @@ XENSTOREDLIBS = \
PROGRAMS = oxenstored

oxenstored_LIBS = $(XENSTOREDLIBS)
-oxenstored_OBJS = $(OBJS)
+# use ocamldep to figure out link order, otherwise the Makefile would have
+# to be continously adjusted for security patches that introduce new
+# dependencies between files
+oxenstored_MLSORTED = $(shell $(OCAMLDEP) -sort $(OBJS:=.ml))
+oxenstored_OBJS = $(oxenstored_MLSORTED:.ml=)

OCAML_PROGRAM = oxenstored

--
generated by git-patchbot for /home/xen/git/xen.git#master