Mailing List Archive

commit d87c5166daee1f9e1570961b2d204a4a2570acf5
Author: Jan Beulich <jbeulich@suse.com>
AuthorDate: Fri Aug 7 13:12:21 2020 +0200
Commit: Jan Beulich <jbeulich@suse.com>
CommitDate: Fri Aug 7 13:12:21 2020 +0200

build: correctly report non-empty section sizes upon .o -> .init.o conversion

The originally used sed expression converted not just multiple leading
zeroes (as intended), but also trailing ones, rendering the error
message somewhat confusing. Collapse zeroes in just the one place where
we need them collapsed, and leave objdump's output as is for all other
purposes.

Fixes: 48115d14743e ("Move more kernel decompression bits to .init.* sections")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
xen/Rules.mk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/Rules.mk b/xen/Rules.mk
index 62e9fabe7a..e90a03d116 100644
--- a/xen/Rules.mk
+++ b/xen/Rules.mk
@@ -185,11 +185,11 @@ cmd_cc_o_S = $(CC) $(a_flags) -c $< -o $@

quiet_cmd_obj_init_o = INIT_O $@
define cmd_obj_init_o
- $(OBJDUMP) -h $< | sed -n '/[0-9]/{s,00*,0,g;p;}' | while read idx name sz rest; do \
+ $(OBJDUMP) -h $< | while read idx name sz rest; do \
case "$$name" in \
.*.local) ;; \
.text|.text.*|.data|.data.*|.bss) \
- test $$sz != 0 || continue; \
+ test $$(echo $$sz | sed 's,00*,0,') != 0 || continue; \
echo "Error: size of $<:$$name is 0x$$sz" >&2; \
exit $$(expr $$idx + 1);; \
esac; \
--
generated by git-patchbot for /home/xen/git/xen.git#master