Mailing List Archive

commit 5132a0a37190b73c99dbbecf48dc4fb214feaf14
Author: Jan Beulich <jbeulich@suse.com>
AuthorDate: Fri Aug 7 13:12:00 2020 +0200
Commit: Jan Beulich <jbeulich@suse.com>
CommitDate: Fri Aug 7 13:12:00 2020 +0200

build: work around bash issue

Older bash (observed with 3.2.57(2)) fails to honor "set -e" for certain
built-in commands ("while" here), despite the command's status correctly
being non-zero. The subsequent objcopy invocation now being separated by
a semicolon results in no failure. Insert an explicit "exit" (replacing
; by && ought to be another possible workaround).

Fixes: e321576f4047 ("xen/build: start using if_changed")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
xen/Rules.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/Rules.mk b/xen/Rules.mk
index ebfd40caff..62e9fabe7a 100644
--- a/xen/Rules.mk
+++ b/xen/Rules.mk
@@ -193,7 +193,7 @@ define cmd_obj_init_o
echo "Error: size of $<:$$name is 0x$$sz" >&2; \
exit $$(expr $$idx + 1);; \
esac; \
- done; \
+ done || exit $$?; \
$(OBJCOPY) $(foreach s,$(SPECIAL_DATA_SECTIONS),--rename-section .$(s)=.init.$(s)) $< $@
endef

--
generated by git-patchbot for /home/xen/git/xen.git#master