Mailing List Archive

[xen staging] passthrough: drop break statement following c/s cd7dedad820
commit 79cf0989175c16994efc1f152eef07bb48cb98df
Author: Igor Druzhinin <igor.druzhinin@citrix.com>
AuthorDate: Thu Dec 5 13:31:03 2019 +0100
Commit: Jan Beulich <jbeulich@suse.com>
CommitDate: Thu Dec 5 13:31:03 2019 +0100

passthrough: drop break statement following c/s cd7dedad820

The locking responsibilities have changed and a premature break in
this section now causes the following assertion:

Assertion '!preempt_count()' failed at preempt.c:36

Reported-by: Sander Eikelenboom <linux@eikelenboom.it>
Suggested-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Igor Druzhinin <igor.druzhinin@citrix.com>
Reviewed-by: Paul Durrant <pdurrant@amazon.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
xen/drivers/passthrough/pci.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
index ced0c28e4f..c07a63981a 100644
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -1705,7 +1705,6 @@ int iommu_do_pci_domctl(
seg, bus, PCI_SLOT(devfn), PCI_FUNC(devfn));
ret = -EINVAL;
}
- break;
}
else if ( !ret )
ret = assign_device(d, seg, bus, devfn, flags);
--
generated by git-patchbot for /home/xen/git/xen.git#staging

_______________________________________________
Xen-changelog mailing list
Xen-changelog@lists.xenproject.org
https://lists.xenproject.org/xen-changelog