Mailing List Archive

Small BC breaking change to LinksUpdate
Hello,

This email is to inform you of a small backwards-incompatible change to LinksUpdate class in MediaWiki core.
LinksUpdate::getTriggeringUser method will start returning an instance of UserIdentity instead of a User object
as of [1]. All 2 known usages of this method are satisfied with UserIdentity interface, and going through a full
deprecation process here would require renaming the method and will just cause more pain to extension
developers.

Best regards.
Petr Pchelko
Staff Software Engineer
Platform Engineering at WMF

1.https://gerrit.wikimedia.org/r/c/mediawiki/core/+/698820 <https://gerrit.wikimedia.org/r/c/mediawiki/core/+/698820>
Re: Small BC breaking change to LinksUpdate [ In reply to ]
Hello Petr, thanks for the update, I think I have experienced a similar issue with the method WikiPage -> getCreator() (upgrading from 1.35 to 1.36) kind regards (Thomas) Sent: Monday, September 13, 2021 at 8:24 PM
From: "Petr Pchelko" <ppchelko@wikimedia.org>
To: "For developers discussing technical aspects and organization of Wikimedia projects" <wikitech-l@lists.wikimedia.org>
Subject: [Wikitech-l] Small BC breaking change to LinksUpdate Hello, This email is to inform you of a small backwards-incompatible change to LinksUpdate class in MediaWiki core. LinksUpdate::getTriggeringUser method will start returning an instance of UserIdentity instead of a User object as of [1]. All 2 known usages of this method are satisfied with UserIdentity interface, and going through a full deprecation process here would require renaming the method and will just cause more pain to extension developers. Best regards. Petr Pchelko Staff Software Engineer Platform Engineering at WMF 1.https://gerrit.wikimedia.org/r/c/mediawiki/core/+/698820"]https://gerrit.wikimedia.org/r/c/mediawiki/core/+/698820 _______________________________________________ Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org To unsubscribe send an email to wikitech-l-leave@lists.wikimedia.org https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/"]https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/