Mailing List Archive

Hi,

On Fri, 2021-08-13 at 09:14 +0200, tdvit@mail.com wrote:
> Hello, I have just updated this extension
>  
> https://www.mediawiki.org/wiki/Extension:CIForms
>  
> and the related github repository.
> However, to update the code on gerrit here
>  
> https://gerrit.wikimedia.org/g/mediawiki/extensions/CIForms
>  
> I would need a code-reviewer. Anyone willing to help with this ?

Is this about
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CIForms/+/663043
as that is the only open changeset listed under
https://gerrit.wikimedia.org/r/q/project:mediawiki/extensions/CIForms ?

I wonder if it makes sense to change the repository in Gerrit from
"Merge review" to "Open push", assuming you are the sole developer?
That would allow you to directly push (if I understand correctly).

Such changes should likely go directly into Gerrit, without having to
fork a mirrored copy of the codebase on GitHub.

Cheers,
andre

--
Andre Klapper (he/him) | Bugwrangler / Developer Advocate
https://blogs.gnome.org/aklapper/
_______________________________________________
Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
To unsubscribe send an email to wikitech-l-leave@lists.wikimedia.org
https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/

Hi,
you can +2 it, I guess.

But I would like to point you to read some docs. :)

https://www.mediawiki.org/wiki/Manual:Coding_conventions/PHP for coding convention and https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines for how-to format a commit message.

If you have any questions, be free to ask me or anyone else here.

Best regards,
Zoran
_______________________________________________
Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
To unsubscribe send an email to wikitech-l-leave@lists.wikimedia.org
https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/

Hi,

On 8/13/21 6:21 AM, Andre Klapper wrote:
> Is this about
> https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CIForms/+/663043
> as that is the only open changeset listed under
> https://gerrit.wikimedia.org/r/q/project:mediawiki/extensions/CIForms ?
>
> I wonder if it makes sense to change the repository in Gerrit from
> "Merge review" to "Open push", assuming you are the sole developer?
> That would allow you to directly push (if I understand correctly).

As a policy reason, we don't allow master/main of MediaWiki
extensions/skins to be open push because it prevents having a space to
discuss the pushed commit. Also, it bypasses any configured CI,
potentially leaving the repo in a broken state.

However, if you're the sole/primary developer of an extension/skin, it's
totally fine to just +2 your own change right after uploading it.

-- Legoktm
_______________________________________________
Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
To unsubscribe send an email to wikitech-l-leave@lists.wikimedia.org
https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/

hello, thanks a lot for all your feedback. So I have learned how to submit using "+2" (and I have updated successfully the repository) I have also asked to change the repository from "Merge review" to "Open push" here https://www.mediawiki.org/wiki/Gerrit/New_repositories/Requests"]https://www.mediawiki.org/wiki/Gerrit/New_repositories/Requests I understand that with it I could directly push, although I don't think by now is strictly necessary. I have also reformatted the code which is now here https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/CIForms/+/3046f62eab32c3dfa0cacf3a11445c936d71451c"]https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/CIForms/+/3046f62eab32c3dfa0cacf3a11445c936d71451c however, I have two issues: 1) when I use the command git clone "https://gerrit.wikimedia.org/r/mediawiki/extensions/CIForms"]https://gerrit.wikimedia.org/r/mediawiki/extensions/CIForms" it also downloads the .git folder, how can I avoid that or to cancel it from the remote folder ? 2) from this page https://www.mediawiki.org/wiki/Special:ExtensionDistributor/CIForms"]https://www.mediawiki.org/wiki/Special:ExtensionDistributor/CIForms it does not download the updated repository, which is the purpose I aimed for: how can I fix/update it ? thanks (Thomas) Sent: Saturday, August 14, 2021 at 7:46 AM
From: "Kunal Mehta" <legoktm@debian.org>
To: wikitech-l@lists.wikimedia.org
Subject: [Wikitech-l] Re: reviewer for extension Hi,

On 8/13/21 6:21 AM, Andre Klapper wrote:
> Is this about
> https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CIForms/+/663043"]https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CIForms/+/663043
> as that is the only open changeset listed under
> https://gerrit.wikimedia.org/r/q/project:mediawiki/extensions/CIForms"]https://gerrit.wikimedia.org/r/q/project:mediawiki/extensions/CIForms ?
>
> I wonder if it makes sense to change the repository in Gerrit from
> "Merge review" to "Open push", assuming you are the sole developer?
> That would allow you to directly push (if I understand correctly).

As a policy reason, we don&#39;t allow master/main of MediaWiki
extensions/skins to be open push because it prevents having a space to
discuss the pushed commit. Also, it bypasses any configured CI,
potentially leaving the repo in a broken state.

However, if you&#39;re the sole/primary developer of an extension/skin, it&#39;s
totally fine to just +2 your own change right after uploading it.

-- Legoktm
_______________________________________________
Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
To unsubscribe send an email to wikitech-l-leave@lists.wikimedia.org
https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/"]https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/