Mailing List Archive: Add nuke_limited counter(Number of times reached nuke

Add nuke_limited counter(Number of times reached nuke_limit.)

Feb 15, 2018, 10:42 PM

Post #1 of 4 (729 views)

Hi,

I got a strange error the other day.
Status code is 200, but body was incomplete.
This error occurred because nuke_limit was reached.(It does not 503,
because beresp.do_stream=true is default)
I think this error is hard to notice.
I would like to add a new counter to make notice it.

https://github.com/xcir/varnish-cache/commit/3a1f45d05dcdc0d22a71148c25ae2dedcf93e6ea

I think it can see that need to increase nuke_limit by this counter.
Can I get your opinion?

Regards,
--
Shohei Tanaka(@xcir)
http://blog.xcir.net/ (JP)
_______________________________________________
varnish-misc mailing list
varnish-misc@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-misc

Re: Add nuke_limited counter(Number of times reached nuke_limit.) [ In reply to ]

dridi at varni

Feb 16, 2018, 12:21 AM

Post #2 of 4 (727 views)

Permalink

On Fri, Feb 16, 2018 at 7:42 AM, kokoniimasu <kokoniimasu@gmail.com> wrote:
> Hi,
>
> I got a strange error the other day.
> Status code is 200, but body was incomplete.
> This error occurred because nuke_limit was reached.(It does not 503,
> because beresp.do_stream=true is default)
> I think this error is hard to notice.
> I would like to add a new counter to make notice it.
>
> https://github.com/xcir/varnish-cache/commit/3a1f45d05dcdc0d22a71148c25ae2dedcf93e6ea
>
> I think it can see that need to increase nuke_limit by this counter.
> Can I get your opinion?

Hi,

Sounds like a great idea to me, the patch looks good too!

Dridi
_______________________________________________
varnish-misc mailing list
varnish-misc@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-misc

Re: Add nuke_limited counter(Number of times reached nuke_limit.) [ In reply to ]

kokoniimasu at gmail

Feb 16, 2018, 1:56 AM

Post #3 of 4 (727 views)

Permalink

Hi, Dridi.

Thank you for your comment!
I will create pull-request.

2018-02-16 17:21 GMT+09:00 Dridi Boukelmoune <dridi@varni.sh>:
> On Fri, Feb 16, 2018 at 7:42 AM, kokoniimasu <kokoniimasu@gmail.com> wrote:
>> Hi,
>>
>> I got a strange error the other day.
>> Status code is 200, but body was incomplete.
>> This error occurred because nuke_limit was reached.(It does not 503,
>> because beresp.do_stream=true is default)
>> I think this error is hard to notice.
>> I would like to add a new counter to make notice it.
>>
>> https://github.com/xcir/varnish-cache/commit/3a1f45d05dcdc0d22a71148c25ae2dedcf93e6ea
>>
>> I think it can see that need to increase nuke_limit by this counter.
>> Can I get your opinion?
>
> Hi,
>
> Sounds like a great idea to me, the patch looks good too!
>
> Dridi
_______________________________________________
varnish-misc mailing list
varnish-misc@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-misc

Re: Add nuke_limited counter(Number of times reached nuke_limit.) [ In reply to ]

dridi at varni

Feb 16, 2018, 2:10 AM

Post #4 of 4 (727 views)

Permalink

On Fri, Feb 16, 2018 at 10:56 AM, kokoniimasu <kokoniimasu@gmail.com> wrote:
> Hi, Dridi.
>
> Thank you for your comment!
> I will create pull-request.

You may want to name the counter n_lru_limited or something similar to
be consistent with related counters.

Cheers
_______________________________________________
varnish-misc mailing list
varnish-misc@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-misc