Mailing List Archive

On Monday, June 13, 2022 at 8:43:56 AM UTC-7 figaro wrote:

> Trunk has the following in wiki.css:
> @import url(code.css);
>
> and already since the earliest version:
> https://trac.edgewall.org/browser/trunk/htdocs/css/wiki.css?rev=4795
>
> However the import of CSS files degrades performance (
> https://stackoverflow.com/questions/10036977/best-way-to-include-css-why-use-import)
> and it is the only occurrence in our code base.
>
> Is there a reason why it is still present?
>
>
> -- figaro
>

There are few instances:
$ git grep "@import"
doc/utils/tracsphinx.css:@import url("sphinxdoc.css");
trac/htdocs/css/report.css:@import url(code.css);
trac/htdocs/css/ticket.css:@import url(code.css);
trac/htdocs/css/wiki.css:@import url(code.css);

We could consider concatenating all of the stylesheets. We have an open
issue for that but it needs more work.
https://trac.edgewall.org/ticket/9936

Ryan

--
You received this message because you are subscribed to the Google Groups "Trac Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to trac-users+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/trac-users/babfb169-9133-454f-8800-b227f5e1e533n%40googlegroups.com.

Ok, will have a look and do some more tests. There is also HTTP/2 and
caching which I expect will make structural code changes regarding the CSS
imports to have a marginal performance impact.

On Tuesday, 14 June 2022 at 00:54:41 UTC+2 RjOllos wrote:

> On Monday, June 13, 2022 at 8:43:56 AM UTC-7 figaro wrote:
>
>> Trunk has the following in wiki.css:
>> @import url(code.css);
>>
>> and already since the earliest version:
>> https://trac.edgewall.org/browser/trunk/htdocs/css/wiki.css?rev=4795
>>
>> However the import of CSS files degrades performance (
>> https://stackoverflow.com/questions/10036977/best-way-to-include-css-why-use-import)
>> and it is the only occurrence in our code base.
>>
>> Is there a reason why it is still present?
>>
>>
>> -- figaro
>>
>
> There are few instances:
> $ git grep "@import"
> doc/utils/tracsphinx.css:@import url("sphinxdoc.css");
> trac/htdocs/css/report.css:@import url(code.css);
> trac/htdocs/css/ticket.css:@import url(code.css);
> trac/htdocs/css/wiki.css:@import url(code.css);
>
> We could consider concatenating all of the stylesheets. We have an open
> issue for that but it needs more work.
> https://trac.edgewall.org/ticket/9936
>
> Ryan
>

--
You received this message because you are subscribed to the Google Groups "Trac Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to trac-users+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/trac-users/d3398673-beae-43ad-ad3b-2af06a439508n%40googlegroups.com.