Mailing List Archive

Re: Regarding: Question on menu/Makefile
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Here is the strange thing. I changed the Makefile back, and even after a make clean and then
make didn't get the error. I then extracted the 3.54 to a different directory, and ran the make
in the menu directory, and get the error message.

libmenu/help.c:17:57: error: loadfile.h: No such file or directory
libmenu/help.c: In function 'showhelp':
libmenu/help.c:99: warning: implicit declaration of function 'loadfile'
make: *** [libmenu/help.o] Error 1

The loadfile.h is in the include/syslinux directory, and that is why I added it to the Makefile to
get it to compile without the error.

CFLAGS = $(M32) -mregparm=3 -DREGPARM=3 -W -Wall -march=i386 -Os -fomit-frame-pointer -I$(LUDIR)/include -I$(COM32DIR)/include -I$(COM32DIR)/include/syslinux -Ilibmenu -D__COM32__

The addition of the -I$(COM32DIR)/include/syslinux then includes that directory as well.

So, the error would not occur if at some point the libmenu/help.o had been already compiled.




On 24 Dec 2007 at 13:45, Geert Stappers wrote:

Date sent: Mon, 24 Dec 2007 13:45:12 +0100
From: Geert Stappers <stappers@stappers.nl>
To: "Michael D. Setzer II" <mikes@kuentos.guam.net>
Subject: Regarding: [syslinux] Question on menu/Makefile

> Op 24-12-2007 om 21:18 schreef Michael D. Setzer II:
> >
> > Was just working with the latest 3.54, and find that the Makefile in the menu
> > directory didn't work until I added the /include/syslinux to the file.
> >
> >
> >
> > < CFLAGS = $(M32) -mregparm=3 -DREGPARM=3 -W -Wall -
> > march=i386 -Os -fomit-frame-pointer -I$(LUDIR)/include -
> > I$(COM32DIR)/include -I$(COM32DIR)/include/syslinux -Ilibmenu -
> > D__COM32__
> > - ---
> > > CFLAGS = $(M32) -mregparm=3 -DREGPARM=3 -W -Wall -
> > march=i386 -Os -fomit-frame-pointer -I$(LUDIR)/include -
> > I$(COM32DIR)/include -Ilibmenu -D__COM32__
> >
>
> Please generate the patch with
>
> diff -u originalfile modifiedfile
>
>
> Or even better with `git diff`
>
> Thanks
>
>
> Cheers
> Geert Stappers


+----------------------------------------------------------+
Michael D. Setzer II - Computer Science Instructor
Guam Community College Computer Center
mailto:mikes@kuentos.guam.net
mailto:msetzerii@gmail.com
http://www.guam.net/home/mikes
Guam - Where America's Day Begins
+----------------------------------------------------------+

http://setiathome.berkeley.edu (Original)
Number of Seti Units Returned: 19,471
Processing time: 32 years, 290 days, 12 hours, 58 minutes
(Total Hours: 287,489)

BOINC@HOME CREDITS
SETI 4,313,454.285347 | EINSTEIN 1,305,752.338610 | ROSETTA 333,703.797336


-----BEGIN PGP SIGNATURE-----
Version: PGP 6.5.8 -- QDPGP 2.61c
Comment: http://community.wow.net/grt/qdpgp.html

iQA/AwUBR28ymyzGQcr/2AKZEQJ+XgCgzYLB8VCDDt1irFq+7LgK/6nMBMAAnAie
Uyev5bNBohoWTNDAfNihWhIk
=J4Kt
-----END PGP SIGNATURE-----

_______________________________________________
SYSLINUX mailing list
Submissions to SYSLINUX@zytor.com
Unsubscribe or set options at:
http://www.zytor.com/mailman/listinfo/syslinux
Please do not send private replies to mailing list traffic.
Re: Regarding: Question on menu/Makefile [ In reply to ]
Michael D. Setzer II wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Here is the strange thing. I changed the Makefile back, and even after a make clean and then
> make didn't get the error. I then extracted the 3.54 to a different directory, and ran the make
> in the menu directory, and get the error message.
>
> libmenu/help.c:17:57: error: loadfile.h: No such file or directory
> libmenu/help.c: In function 'showhelp':
> libmenu/help.c:99: warning: implicit declaration of function 'loadfile'
> make: *** [libmenu/help.o] Error 1
>
> The loadfile.h is in the include/syslinux directory, and that is why I added it to the Makefile to
> get it to compile without the error.
>
> CFLAGS = $(M32) -mregparm=3 -DREGPARM=3 -W -Wall -march=i386 -Os -fomit-frame-pointer -I$(LUDIR)/include -I$(COM32DIR)/include -I$(COM32DIR)/include/syslinux -Ilibmenu -D__COM32__
>
> The addition of the -I$(COM32DIR)/include/syslinux then includes that directory as well.
>
> So, the error would not occur if at some point the libmenu/help.o had been already compiled.
>

Right, that makes sense.

The right thing to do would be to explicitly add syslinux/ to the
#include directives for headers that have moved into the syslinux/
namespace.

-hpa

_______________________________________________
SYSLINUX mailing list
Submissions to SYSLINUX@zytor.com
Unsubscribe or set options at:
http://www.zytor.com/mailman/listinfo/syslinux
Please do not send private replies to mailing list traffic.