Mailing List Archive: SA perl requirements

SA perl requirements

Jan 14, 2020, 6:29 AM

Post #1 of 3 (268 views)

I've been meaning to ask the maintainers, according to the requirements
listed in the INSTALL file

Required Perl Interpreter
-------------------------

Perl 5.8.1 or a later version is required.
Preferred versions are 5.8.8, or 5.10.1 or later.

Yet it actually requires 5.10+ because of FromNameSpoof.pm

FromNameSpoof.pm uses the defined-or operator on line 265 (//=) and nested
(possessive) quantifiers ([\w\-\.]++)\b/i) on line 352.

Now fixing the source to work with 5.8x isn't a big deal but should the
requirements not reflected the need for perl 5.10 or should those line be
changed to comply with the stated 5.8.8 above?

I know to fix this before running make test, but the errors this produces
during make test could be quite confusing if you just ran into it.

Rick

Re: SA perl requirements [ In reply to ]

kmcgrail at apache

Jan 14, 2020, 6:30 PM

Post #2 of 3 (264 views)

Permalink

Hi Rick,

Thanks very much for pointing that out. I did not know about that minimum
perl requirement in the INSTALL file.

However, the 3.4 branch is EOL and we are moving on to the 4.0 branch which
requires Perl 5.14.0+ (see
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7615). So I've
clarified that in the trunk's INSTALL file and noted that 5.10.1 is
required in 3.4 svn.

Regards,
KAM

--
Kevin A. McGrail
Member, Apache Software Foundation
Chair Emeritus Apache SpamAssassin Project
https://www.linkedin.com/in/kmcgrail - 703.798.0171

On Tue, Jan 14, 2020 at 9:29 AM Rick Cooper <rcooper@dwford.com> wrote:

> I've been meaning to ask the maintainers, according to the requirements
> listed in the INSTALL file
>
> Required Perl Interpreter
> -------------------------
>
> Perl 5.8.1 or a later version is required.
> Preferred versions are 5.8.8, or 5.10.1 or later.
>
> Yet it actually requires 5.10+ because of FromNameSpoof.pm
>
> FromNameSpoof.pm uses the defined-or operator on line 265 (//=) and nested
> (possessive) quantifiers ([\w\-\.]++)\b/i) on line 352.
>
> Now fixing the source to work with 5.8x isn't a big deal but should the
> requirements not reflected the need for perl 5.10 or should those line be
> changed to comply with the stated 5.8.8 above?
>
> I know to fix this before running make test, but the errors this produces
> during make test could be quite confusing if you just ran into it.
>
> Rick
>

Re: SA perl requirements [ In reply to ]

hege at hege

Jan 14, 2020, 11:37 PM

Post #3 of 3 (262 views)

Permalink

On Tue, Jan 14, 2020 at 09:30:26PM -0500, Kevin A. McGrail wrote:
>
> and noted that 5.10.1 is required in 3.4 svn.?

As FromNameSpoof is not even enabled by default, this is pretty much
pointless to do and should be mentioned in v342.pre instead. 3.4 branch as
is should and will support older Perl, of course it's silly to run such old
ones.