Mailing List Archive

Removing code "for the moment" should not be a thing, as a failing test
makes no difference to anyone. Now there is a possibility that the whole
thing is forgotten, and no one puts the code back. Please keep such things
uncommitted and simply work on a fix in personal repo.


On Sat, May 29, 2021 at 07:51:18PM -0000, gbechis@apache.org wrote:
> Author: gbechis
> Date: Sat May 29 19:51:18 2021
> New Revision: 1890313
>
> URL: http://svn.apache.org/viewvc?rev=1890313&view=rev
> Log:
> disable a test for the moment,
> regression test fails if GeoIP2 module cannot be initialized.
>
> Modified:
> spamassassin/trunk/t/all_modules.t
>
> Modified: spamassassin/trunk/t/all_modules.t
> URL: http://svn.apache.org/viewvc/spamassassin/trunk/t/all_modules.t?rev=1890313&r1=1890312&r2=1890313&view=diff
> ==============================================================================
> --- spamassassin/trunk/t/all_modules.t (original)
> +++ spamassassin/trunk/t/all_modules.t Sat May 29 19:51:18 2021
> @@ -4,7 +4,7 @@ use lib '.'; use lib 't';
> use SATest; sa_t_init("all_modules");
>
> use Test::More;
> -plan tests => 7;
> +plan tests => 6;
>
> # ---------------------------------------------------------------------------
>
> @@ -81,7 +81,6 @@ tstprefs("
> q{ Use of uninitialized }, 'uninitialized',
> q{ warn: }, 'warn',
> q{ SpamAssassin failed to parse line }, 'parse',
> - '/ at .* line \d+/', 'warn',
> );
>
> if (conf_bool('run_net_tests')) {
>