Mailing List Archive

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "rt".

The branch, 5.0/fix-initially-rolled-up-widgets has been created
at b4f65a887ee42f9bc2ade3da6800ad5eef61c56a (commit)

- Log -----------------------------------------------------------------
commit b4f65a887ee42f9bc2ade3da6800ad5eef61c56a
Author: sunnavy <sunnavy@bestpractical.com>
Date: Thu Aug 4 00:39:47 2022 +0800

Remove the broken "hidden" class for initially rolled-up widgets

The "hidden" class came from RT 4, as we migrated to bootstrap in RT 5,
where the presence and absence of "show" class is used to toggle the
visibility of widgets, the "hidden" class is not needed any more.

Even worse, as the "hidden" class is not automatially removed on toggle,
if widgets are initially rolled-up, they will never show up, like the
"Scrips and Recipients" widget on ticket update page, when
$SimplifiedRecipients is set to true.

diff --git a/share/html/Widgets/TitleBoxStart b/share/html/Widgets/TitleBoxStart
index eb2b033a6e..9936364ca3 100644
--- a/share/html/Widgets/TitleBoxStart
+++ b/share/html/Widgets/TitleBoxStart
@@ -62,7 +62,7 @@
<% $titleright %><% $titleright_raw |n%><% $titleright_href ? "</a>" : '' |n%>\
</span>
</div>
- <div class="titlebox-content collapse <% $bodyclass %><% $rolledup ? " hidden" : " show"%><% " $content_class" || '' %>" id="<% $tid %>">
+ <div class="titlebox-content collapse <% $bodyclass %><% $rolledup ? "" : " show"%><% " $content_class" || '' %>" id="<% $tid %>">
<div class="card-body">
<%ARGS>
$class => ''

-----------------------------------------------------------------------


hooks/post-receive
--
rt
_______________________________________________
rt-commit mailing list
rt-commit@lists.bestpractical.com
https://lists.bestpractical.com/mailman/listinfo/rt-commit