Mailing List Archive

rt branch, 4.4/chart-group-by-custom-roles, repushed
The branch 4.4/chart-group-by-custom-roles was deleted and repushed:
was 15be5bba0e5978073e4ebeaaf21ae72d0c5d1a1e
now 19f954c329614992907a16ca62bf3fb1a87c65fb

1: 71f5c46866 = 1: c5b647ec47 Add grouping by custom roles for ticket search charts
2: 15be5bba0e ! 2: 353c6f0783 Add tests for grouping by custom roles in ticket search charts
@@ -87,3 +87,4 @@
+}
+
+done_testing;
+
-: ------- > 3: 9e13721a92 Group by direct members of role groups for ticket search charts
-: ------- > 4: 19f954c329 Update tests for the support of grouping by user defined groups in charts

_______________________________________________
rt-commit mailing list
rt-commit@lists.bestpractical.com
http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-commit
rt branch, 4.4/chart-group-by-custom-roles, repushed [ In reply to ]
The branch 4.4/chart-group-by-custom-roles was deleted and repushed:
was 19f954c329614992907a16ca62bf3fb1a87c65fb
now 0ed6611b629718d0699b10980a7b8531cd67bcfa

1: c5b647ec47 = 1: c5b647ec47 Add grouping by custom roles for ticket search charts
2: 353c6f0783 = 2: 353c6f0783 Add tests for grouping by custom roles in ticket search charts
3: 9e13721a92 ! 3: f9acb355b3 Group by direct members of role groups for ticket search charts
@@ -53,7 +53,7 @@
+ my $princ = RT::Principal->new( $self->CurrentUser );
+ $princ->Load( $args{'VALUE'} ) if $args{'VALUE'};
+ return $self->loc('(no value)') unless $princ->Id;
-+ return $princ->Object->Name;
++ return $princ->IsGroup ? $self->loc( 'Group: [_1]', $princ->Object->Name ) : $princ->Object->Name;
+ }
+ else {
+ return $args{VALUE};
4: 19f954c329 ! 4: 6e2141330b Update tests for the support of grouping by user defined groups in charts
@@ -27,3 +27,4 @@
is( $m->content_type, "image/png" );
ok( length($m->content), "Has content" );

+
-: ------- > 5: 0ed6611b62 Hide "Total" row for not-distinct results in search chart to avoid confusion

_______________________________________________
rt-commit mailing list
rt-commit@lists.bestpractical.com
http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-commit