Mailing List Archive

The branch, 5.0/abort-ticket-create-page-if-no-queue has been created
at 838e0a105bc0a74fa087438f7344ba1f2f4eaa87 (commit)

- Log -----------------------------------------------------------------
commit 838e0a105bc0a74fa087438f7344ba1f2f4eaa87
Author: craig kaiser <craig@bestpractical.com>
Date: Mon Jun 22 09:21:00 2020 -0400

Abort ticket create if no queue can be loaded

diff --git a/html/RTIR/Create.html b/html/RTIR/Create.html
index 7d738d4b..7d224e21 100644
--- a/html/RTIR/Create.html
+++ b/html/RTIR/Create.html
@@ -432,11 +432,8 @@ unless ($Queue) {
}

my $QueueObj = RT::Queue->new( $session{'CurrentUser'} );
-$QueueObj->Load( $Queue );
-
-if (!$QueueObj->Name) {
- Abort( loc("Queue '[_1]' could not be loaded.",$Queue) );
- }
+$QueueObj->Load($Queue) || Abort(loc("Queue [_1] could not be loaded.", $Queue||''), Code => HTTP::Status::HTTP_BAD_REQUEST);
+$QueueObj->Disabled && Abort(loc("Cannot create tickets in a disabled queue."), Code => HTTP::Status::HTTP_NOT_FOUND);

$Lifecycle ||= $QueueObj->Lifecycle;


-----------------------------------------------------------------------
_______________________________________________
rt-commit mailing list
rt-commit@lists.bestpractical.com
http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-commit