Mailing List Archive

rt branch, 4.4/searching-retain-row-limit, repushed
The branch 4.4/searching-retain-row-limit was deleted and repushed:
was b47b4139137cf71ba6cb2de617538b1f630ade16
now ae9f845d2a5ca9c2cc79bd9a8c40271b99952e09

1: b47b413913 ! 1: ae9f845d2a Add default rows per page for search results from saved chart
@@ -1,6 +1,6 @@
Author: craig kaiser <craig@bestpractical.com>

- Add default rows per page for results from saved chart
+ Add default rows per page for search results from saved chart

The saved chart attribute does not save a rows per page value, resulting
in no value being provided on saved chart load. That means the search

_______________________________________________
rt-commit mailing list
rt-commit@lists.bestpractical.com
http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-commit
rt branch, 4.4/searching-retain-row-limit, repushed [ In reply to ]
The branch 4.4/searching-retain-row-limit was deleted and repushed:
was ae9f845d2a5ca9c2cc79bd9a8c40271b99952e09
now 2ca905bed602448e4eacd33283997c957c36a003

1: ae9f845d2a ! 1: 2ca905bed6 Add default rows per page for search results from saved chart
@@ -30,10 +30,13 @@
$current_search_menu->child( advanced =>
title => loc('Advanced'), path => "/Search/Edit.html$args" );
if ($has_query) {
-+ # If we load a saved chart we want to have a default sensible rows per page value
++ # If we load a saved chart we need to set a default RowsPerPage value
++ # or else when going to the results page from the saved chart the results
++ # set will have no pagination and be unlimited.
++ # We use 50 as the default value as it is the default value on the query builder page.
+ if ( $request_path =~ m{^/Search/Chart.html} && $final_query_args{'SavedChartSearchId'} ) {
+ unless ( defined $final_query_args{'RowsPerPage'} ) {
-+ $args =~ s/RowsPerPage=/RowsPerPage=10/;
++ $args =~ s/RowsPerPage=/RowsPerPage=50/;
+ }
+ }
+

_______________________________________________
rt-commit mailing list
rt-commit@lists.bestpractical.com
http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-commit