Mailing List Archive

experimental 1.19.9 tarball
Hi all,

as promised yesterday, I have uploaded an experimental tarball for
1.19.9. It is available at

http://download.rsyslog.com/rsyslog/rsyslog-1.19.9.tar.gz

It now is a single tarball again, but with a separate makefile for
ommysql. That makefile is integrated in the build process and being
activated by

./configure --enable-mysql

I would appreciate feedback from those of you doing packaging. Is this
format acceptable? I would like to release only if people are generally
happy with it.

Thanks,
Rainer
experimental 1.19.9 tarball [ In reply to ]
Hi Rainer,

> Hi all,
>
> as promised yesterday, I have uploaded an experimental tarball for
> 1.19.9. It is available at
>
> http://download.rsyslog.com/rsyslog/rsyslog-1.19.9.tar.gz
>
> It now is a single tarball again, but with a separate makefile for
> ommysql. That makefile is integrated in the build process and being
> activated by
>
> ./configure --enable-mysql
>
> I would appreciate feedback from those of you doing packaging. Is
> this format acceptable? I would like to release only if people are generally
> happy with it.

I downloaded the tarball and ran it against my spec (the ones I posed on the
wiki), and I get:

gcc -DHAVE_CONFIG_H -I. -I../.. -I/usr/include/mysql -g -pipe -m32
-march=i386 -mtune=pentium4 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64
-D_LARGEFILE_SOURCE -fno-strict-aliasing -I./../.. -O2 -g -pipe -m32
-march=i386 -mtune=pentium4 -W -Wall -Wformat-security -Wshadow -Wcast-align
-Wpointer-arith -Wmissing-format-attribute -g -MT ommysql_la-ommysql.lo -MD
-MP -MF .deps/ommysql_la-ommysql.Tpo -c ommysql.c -fPIC -DPIC -o
.libs/ommysql_la-ommysql.o
ommysql.c:27:28: ommysql-config.h: No such file or directory
In file included from ommysql.c:39:
../../syslogd.h:59: warning: "struct AllowedSenders" declared inside parameter
list
../../syslogd.h:59: warning: its scope is only this definition or declaration,
which is probably not what you want
make[2]: *** [ommysql_la-ommysql.lo] Error 1
make[2]: Leaving directory `/usr/src/redhat/BUILD/rsyslog-1.19.9/plugins/ommysql'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/usr/src/redhat/BUILD/rsyslog-1.19.9'
make: *** [all] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.88499 (%build)

Not sure what's wrong with it but I might take a look at it tomorrow after a
good nights rest.

Regards,

Michael.

> Thanks,
> Rainer
>
> _______________________________________________
> rsyslog mailing list
> http://lists.adiscon.net/mailman/listinfo/rsyslog
------- End of Original Message -------
experimental 1.19.9 tarball [ In reply to ]
2007/10/10, Rainer Gerhards <rgerhards at hq.adiscon.com>:
> Hi all,
>
> as promised yesterday, I have uploaded an experimental tarball for
> 1.19.9. It is available at
>
>
> I would appreciate feedback from those of you doing packaging. Is this
> format acceptable? I would like to release only if people are generally
> happy with it.
>

I hope I can test it tomorrow or on friday. I'll report back then.

Michael

--
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?
experimental 1.19.9 tarball [ In reply to ]
Excellent - from initial feedback I received, there still seems to be
some minor nits. I'll re-release the pilot soon, will post then.

Rainer

> -----Original Message-----
> From: rsyslog-bounces at lists.adiscon.com [mailto:rsyslog-
> bounces at lists.adiscon.com] On Behalf Of Michael Biebl
> Sent: Wednesday, October 10, 2007 5:44 PM
> To: rsyslog-users
> Subject: Re: [rsyslog] experimental 1.19.9 tarball
>
> 2007/10/10, Rainer Gerhards <rgerhards at hq.adiscon.com>:
> > Hi all,
> >
> > as promised yesterday, I have uploaded an experimental tarball for
> > 1.19.9. It is available at
> >
> >
> > I would appreciate feedback from those of you doing packaging. Is
> this
> > format acceptable? I would like to release only if people are
> generally
> > happy with it.
> >
>
> I hope I can test it tomorrow or on friday. I'll report back then.
>
> Michael
>
> --
> Why is it that all of the instruments seeking intelligent life in the
> universe are pointed away from Earth?
> _______________________________________________
> rsyslog mailing list
> http://lists.adiscon.net/mailman/listinfo/rsyslog
experimental 1.19.9 tarball [ In reply to ]
2007/10/10, Rainer Gerhards <rgerhards at hq.adiscon.com>:
> Excellent - from initial feedback I received, there still seems to be
> some minor nits. I'll re-release the pilot soon, will post then.

Ok, I had some time to review the changes. All in all I like, how it's
done know.

Attached you will find a patch which will cleanup/fix some issues:

1.) fix failing compilation of ommysql plugin (s/ommysql-config.h/config.h/)
2.) fix mysql configure check (although the default is no, we did
check for the mysql devel files)
3.) Create a separate Makefile.am for the doc files. This cleans up
the toplevel Makefile.am considerably and makes it much more readable
and maintainable. I guess everyone agrees ;-)
3b) Assign the html doc files to html_DATA. This means, they are
installed to $(hmtdir), which by autoconf standards is
$(prefix)/share/doc/$packagename/. If that is not wanted, just name
the variable html_files e.g.
4.) Reformat the SOURCES line to make it better readable and maintainable.

The patch is against the experimental 1.19.9 tarball.
It only patches configure.ac/Makefile.am, so you have to run
"autoreconf -vfi" to rebuild the auto* files.

Please review and apply.

Cheers,
Michael
--
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?
experimental 1.19.9 tarball [ In reply to ]
Michael Biebl wrote:
> Please review and apply.

please reattach ;) the email has no patch enclosed.

cheers,
raoul
--
____________________________________________________________________
DI (FH) Raoul Bhatia M.Sc. email. r.bhatia at ipax.at
Technischer Leiter

IPAX - Aloy Bhatia Hava OEG web. http://www.ipax.at
Barawitzkagasse 10/2/2/11 email. office at ipax.at
1190 Wien tel. +43 1 3670030
FN 277995t HG Wien fax. +43 1 3670030 15
____________________________________________________________________
experimental 1.19.9 tarball [ In reply to ]
2007/10/10, Raoul Bhatia [IPAX] <r.bhatia at ipax.at>:
> Michael Biebl wrote:
> > Please review and apply.
>
> please reattach ;) the email has no patch enclosed.

I definitely attached the patch, but maybe the list-server stripped it.

So lets try it again.
I case it doesn't also work this time you can also find the patch at

http://debs.michaelbiebl.de/rsyslog/rsyslog.patch

Cheers,
Michael
--
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?
experimental 1.19.9 tarball [ In reply to ]
The list server is *very* picky on what it allows (almost nothing). Its
kind of a "better save than sorry" setup...

Rainer

> -----Original Message-----
> From: rsyslog-bounces at lists.adiscon.com [mailto:rsyslog-
> bounces at lists.adiscon.com] On Behalf Of Michael Biebl
> Sent: Wednesday, October 10, 2007 8:39 PM
> To: rsyslog-users
> Subject: Re: [rsyslog] experimental 1.19.9 tarball
>
> 2007/10/10, Raoul Bhatia [IPAX] <r.bhatia at ipax.at>:
> > Michael Biebl wrote:
> > > Please review and apply.
> >
> > please reattach ;) the email has no patch enclosed.
>
> I definitely attached the patch, but maybe the list-server stripped
it.
>
> So lets try it again.
> I case it doesn't also work this time you can also find the patch at
>
> http://debs.michaelbiebl.de/rsyslog/rsyslog.patch
>
> Cheers,
> Michael
> --
> Why is it that all of the instruments seeking intelligent life in the
> universe are pointed away from Earth?
experimental 1.19.9 tarball [ In reply to ]
Hi Michael,

many thanks, this is a *very* useful patch, much appreciated. I just
applied it an re-created the experimental tarball. The new version is
available at the previous url at

http://download.rsyslog.com/rsyslog/rsyslog-1.19.9.tar.gz

I think I'll release tomorrow if I do not hear any show stopper until
then.

Thanks all for testing, comments and patches! (I so far applied
Michael's only, is it seems to cover everything else - but I'll do
further review now) :)

Rainer

On Wed, 2007-10-10 at 19:33 +0200, Michael Biebl wrote:
> 2007/10/10, Rainer Gerhards <rgerhards at hq.adiscon.com>:
> > Excellent - from initial feedback I received, there still seems to be
> > some minor nits. I'll re-release the pilot soon, will post then.
>
> Ok, I had some time to review the changes. All in all I like, how it's
> done know.
>
> Attached you will find a patch which will cleanup/fix some issues:
>
> 1.) fix failing compilation of ommysql plugin (s/ommysql-config.h/config.h/)
> 2.) fix mysql configure check (although the default is no, we did
> check for the mysql devel files)
> 3.) Create a separate Makefile.am for the doc files. This cleans up
> the toplevel Makefile.am considerably and makes it much more readable
> and maintainable. I guess everyone agrees ;-)
> 3b) Assign the html doc files to html_DATA. This means, they are
> installed to $(hmtdir), which by autoconf standards is
> $(prefix)/share/doc/$packagename/. If that is not wanted, just name
> the variable html_files e.g.
> 4.) Reformat the SOURCES line to make it better readable and maintainable.
>
> The patch is against the experimental 1.19.9 tarball.
> It only patches configure.ac/Makefile.am, so you have to run
> "autoreconf -vfi" to rebuild the auto* files.
>
> Please review and apply.
>
> Cheers,
> Michael
> _______________________________________________
> rsyslog mailing list
> http://lists.adiscon.net/mailman/listinfo/rsyslog
experimental 1.19.9 tarball [ In reply to ]
Michael Biebl wrote:
> 2007/10/10, Rainer Gerhards <rgerhards at hq.adiscon.com>:
>> Excellent - from initial feedback I received, there still seems to be
>> some minor nits. I'll re-release the pilot soon, will post then.
>
> Ok, I had some time to review the changes. All in all I like, how it's
> done know.
>
> Attached you will find a patch which will cleanup/fix some issues:
>
> 1.) fix failing compilation of ommysql plugin (s/ommysql-config.h/config.h/)
> 2.) fix mysql configure check (although the default is no, we did
> check for the mysql devel files)
> 3.) Create a separate Makefile.am for the doc files. This cleans up
> the toplevel Makefile.am considerably and makes it much more readable
> and maintainable. I guess everyone agrees ;-)
> 3b) Assign the html doc files to html_DATA. This means, they are
> installed to $(hmtdir), which by autoconf standards is
> $(prefix)/share/doc/$packagename/. If that is not wanted, just name
> the variable html_files e.g.

I would appreciate it :-)

> 4.) Reformat the SOURCES line to make it better readable and maintainable.
>
> The patch is against the experimental 1.19.9 tarball.
> It only patches configure.ac/Makefile.am, so you have to run
> "autoreconf -vfi" to rebuild the auto* files.
>
> Please review and apply.
>
> Cheers,
> Michael
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> rsyslog mailing list
> http://lists.adiscon.net/mailman/listinfo/rsyslog
experimental 1.19.9 tarball [ In reply to ]
Hi,

just a few additions to Michael's patch.

Rainer Gerhards wrote:
> Hi Michael,
>
> many thanks, this is a *very* useful patch, much appreciated. I just
> applied it an re-created the experimental tarball. The new version is
> available at the previous url at
>
> http://download.rsyslog.com/rsyslog/rsyslog-1.19.9.tar.gz
>
> I think I'll release tomorrow if I do not hear any show stopper until
> then.
>
> Thanks all for testing, comments and patches! (I so far applied
> Michael's only, is it seems to cover everything else - but I'll do
> further review now) :)
>
> Rainer
>
> On Wed, 2007-10-10 at 19:33 +0200, Michael Biebl wrote:
>> 2007/10/10, Rainer Gerhards <rgerhards at hq.adiscon.com>:
>>> Excellent - from initial feedback I received, there still seems to be
>>> some minor nits. I'll re-release the pilot soon, will post then.
>> Ok, I had some time to review the changes. All in all I like, how it's
>> done know.
>>
>> Attached you will find a patch which will cleanup/fix some issues:
>>
>> 1.) fix failing compilation of ommysql plugin (s/ommysql-config.h/config.h/)
>> 2.) fix mysql configure check (although the default is no, we did
>> check for the mysql devel files)
>> 3.) Create a separate Makefile.am for the doc files. This cleans up
>> the toplevel Makefile.am considerably and makes it much more readable
>> and maintainable. I guess everyone agrees ;-)
>> 3b) Assign the html doc files to html_DATA. This means, they are
>> installed to $(hmtdir), which by autoconf standards is
>> $(prefix)/share/doc/$packagename/. If that is not wanted, just name
>> the variable html_files e.g.
>> 4.) Reformat the SOURCES line to make it better readable and maintainable.
>>
>> The patch is against the experimental 1.19.9 tarball.
>> It only patches configure.ac/Makefile.am, so you have to run
>> "autoreconf -vfi" to rebuild the auto* files.
>>
>> Please review and apply.
>>
>> Cheers,
>> Michael
>> _______________________________________________
>> rsyslog mailing list
>> http://lists.adiscon.net/mailman/listinfo/rsyslog
>
> _______________________________________________
> rsyslog mailing list
> http://lists.adiscon.net/mailman/listinfo/rsyslog
experimental 1.19.9 tarball [ In reply to ]
The mailing list won't let attachments of anything other than (I think,
.txt) through (if at all). You can mail me privately, I'll post it (and
I bet you've also a site to post to, feel free to do that).

Thanks again all for your help - muuuuuch appreciated!

Rainer

> -----Original Message-----
> From: rsyslog-bounces at lists.adiscon.com [mailto:rsyslog-
> bounces at lists.adiscon.com] On Behalf Of theinric at redhat.com
> Sent: Thursday, October 11, 2007 12:37 PM
> To: rsyslog-users
> Subject: Re: [rsyslog] experimental 1.19.9 tarball
>
> Hi,
>
> just a few additions to Michael's patch.
>
> Rainer Gerhards wrote:
> > Hi Michael,
> >
> > many thanks, this is a *very* useful patch, much appreciated. I just
> > applied it an re-created the experimental tarball. The new version
is
> > available at the previous url at
> >
> > http://download.rsyslog.com/rsyslog/rsyslog-1.19.9.tar.gz
> >
> > I think I'll release tomorrow if I do not hear any show stopper
until
> > then.
> >
> > Thanks all for testing, comments and patches! (I so far applied
> > Michael's only, is it seems to cover everything else - but I'll do
> > further review now) :)
> >
> > Rainer
> >
> > On Wed, 2007-10-10 at 19:33 +0200, Michael Biebl wrote:
> >> 2007/10/10, Rainer Gerhards <rgerhards at hq.adiscon.com>:
> >>> Excellent - from initial feedback I received, there still seems to
> be
> >>> some minor nits. I'll re-release the pilot soon, will post then.
> >> Ok, I had some time to review the changes. All in all I like, how
> it's
> >> done know.
> >>
> >> Attached you will find a patch which will cleanup/fix some issues:
> >>
> >> 1.) fix failing compilation of ommysql plugin (s/ommysql-
> config.h/config.h/)
> >> 2.) fix mysql configure check (although the default is no, we did
> >> check for the mysql devel files)
> >> 3.) Create a separate Makefile.am for the doc files. This cleans up
> >> the toplevel Makefile.am considerably and makes it much more
> readable
> >> and maintainable. I guess everyone agrees ;-)
> >> 3b) Assign the html doc files to html_DATA. This means, they are
> >> installed to $(hmtdir), which by autoconf standards is
> >> $(prefix)/share/doc/$packagename/. If that is not wanted, just name
> >> the variable html_files e.g.
> >> 4.) Reformat the SOURCES line to make it better readable and
> maintainable.
> >>
> >> The patch is against the experimental 1.19.9 tarball.
> >> It only patches configure.ac/Makefile.am, so you have to run
> >> "autoreconf -vfi" to rebuild the auto* files.
> >>
> >> Please review and apply.
> >>
> >> Cheers,
> >> Michael
> >> _______________________________________________
> >> rsyslog mailing list
> >> http://lists.adiscon.net/mailman/listinfo/rsyslog
> >
> > _______________________________________________
> > rsyslog mailing list
> > http://lists.adiscon.net/mailman/listinfo/rsyslog
experimental 1.19.9 tarball [ In reply to ]
Sorry, didn't realised.

diff -up rsyslog-1.19.9/configure.ac.orig rsyslog-1.19.9/configure.ac
--- rsyslog-1.19.9/configure.ac.orig 2007-10-11 11:56:05.000000000 +0200
+++ rsyslog-1.19.9/configure.ac 2007-10-11 11:57:33.000000000 +0200
@@ -254,17 +254,23 @@ if test "x$enable_mysql" = "xyes"; then
[mysql/mysql.h],,
[AC_MSG_FAILURE([MySQL is missing])]
)
- AC_SUBST(LIBS_TMP,[$LIBS])
- AC_SEARCH_LIBS(
- [mysql_init],
+ AC_CHECK_PROG(
+ [HAVE_MYSQL_CONFIG],
+ [mysql_config],
+ [yes],,,
+ )
+ if test "x${HAVE_MYSQL_CONFIG}" != "xyes"; then
+ AC_MSG_FAILURE([mysql_config not found in PATH])
+ fi
+ AC_CHECK_LIB(
[mysqlclient],
+ [mysql_init],
[mysql_cflags=`mysql_config --cflags`
mysql_libs=`mysql_config --libs`
],
[AC_MSG_FAILURE([MySQL library is missing])],
[`mysql_config --libs`]
)
- AC_SUBST(LIBS,[$LIBS_TMP])
fi
AM_CONDITIONAL(ENABLE_MYSQL, test x$enable_mysql = xyes)
AC_SUBST(mysql_cflags)

Rainer Gerhards wrote:
> The mailing list won't let attachments of anything other than (I think,
> .txt) through (if at all). You can mail me privately, I'll post it (and
> I bet you've also a site to post to, feel free to do that).
>
> Thanks again all for your help - muuuuuch appreciated!
>
> Rainer
>
>> -----Original Message-----
>> From: rsyslog-bounces at lists.adiscon.com [mailto:rsyslog-
>> bounces at lists.adiscon.com] On Behalf Of theinric at redhat.com
>> Sent: Thursday, October 11, 2007 12:37 PM
>> To: rsyslog-users
>> Subject: Re: [rsyslog] experimental 1.19.9 tarball
>>
>> Hi,
>>
>> just a few additions to Michael's patch.
>>
>> Rainer Gerhards wrote:
>>> Hi Michael,
>>>
>>> many thanks, this is a *very* useful patch, much appreciated. I just
>>> applied it an re-created the experimental tarball. The new version
> is
>>> available at the previous url at
>>>
>>> http://download.rsyslog.com/rsyslog/rsyslog-1.19.9.tar.gz
>>>
>>> I think I'll release tomorrow if I do not hear any show stopper
> until
>>> then.
>>>
>>> Thanks all for testing, comments and patches! (I so far applied
>>> Michael's only, is it seems to cover everything else - but I'll do
>>> further review now) :)
>>>
>>> Rainer
>>>
>>> On Wed, 2007-10-10 at 19:33 +0200, Michael Biebl wrote:
>>>> 2007/10/10, Rainer Gerhards <rgerhards at hq.adiscon.com>:
>>>>> Excellent - from initial feedback I received, there still seems to
>> be
>>>>> some minor nits. I'll re-release the pilot soon, will post then.
>>>> Ok, I had some time to review the changes. All in all I like, how
>> it's
>>>> done know.
>>>>
>>>> Attached you will find a patch which will cleanup/fix some issues:
>>>>
>>>> 1.) fix failing compilation of ommysql plugin (s/ommysql-
>> config.h/config.h/)
>>>> 2.) fix mysql configure check (although the default is no, we did
>>>> check for the mysql devel files)
>>>> 3.) Create a separate Makefile.am for the doc files. This cleans up
>>>> the toplevel Makefile.am considerably and makes it much more
>> readable
>>>> and maintainable. I guess everyone agrees ;-)
>>>> 3b) Assign the html doc files to html_DATA. This means, they are
>>>> installed to $(hmtdir), which by autoconf standards is
>>>> $(prefix)/share/doc/$packagename/. If that is not wanted, just name
>>>> the variable html_files e.g.
>>>> 4.) Reformat the SOURCES line to make it better readable and
>> maintainable.
>>>> The patch is against the experimental 1.19.9 tarball.
>>>> It only patches configure.ac/Makefile.am, so you have to run
>>>> "autoreconf -vfi" to rebuild the auto* files.
>>>>
>>>> Please review and apply.
>>>>
>>>> Cheers,
>>>> Michael
>>>> _______________________________________________
>>>> rsyslog mailing list
>>>> http://lists.adiscon.net/mailman/listinfo/rsyslog
>>> _______________________________________________
>>> rsyslog mailing list
>>> http://lists.adiscon.net/mailman/listinfo/rsyslog
>
> _______________________________________________
> rsyslog mailing list
> http://lists.adiscon.net/mailman/listinfo/rsyslog
experimental 1.19.9 tarball [ In reply to ]
Hi Rainer,

> Hi Michael,
>
> many thanks, this is a *very* useful patch, much appreciated. I just
> applied it an re-created the experimental tarball. The new version is
> available at the previous url at
>
> http://download.rsyslog.com/rsyslog/rsyslog-1.19.9.tar.gz
>
> I think I'll release tomorrow if I do not hear any show stopper until
> then.
>
> Thanks all for testing, comments and patches! (I so far applied
> Michael's only, is it seems to cover everything else - but I'll do
> further review now) :)

With a small mod to my spec I was able to build both RPM's (rsyslog and
rsyslog-mysql).

I updated my rsyslog 1.19.7 installation and things seem to be running fine.

Thanks,

Michael.

> Rainer
>
> On Wed, 2007-10-10 at 19:33 +0200, Michael Biebl wrote:
> > 2007/10/10, Rainer Gerhards <rgerhards at hq.adiscon.com>:
> > > Excellent - from initial feedback I received, there still seems to be
> > > some minor nits. I'll re-release the pilot soon, will post then.
> >
> > Ok, I had some time to review the changes. All in all I like, how it's
> > done know.
> >
> > Attached you will find a patch which will cleanup/fix some issues:
> >
> > 1.) fix failing compilation of ommysql plugin (s/ommysql-config.h/config.h/)
> > 2.) fix mysql configure check (although the default is no, we did
> > check for the mysql devel files)
> > 3.) Create a separate Makefile.am for the doc files. This cleans up
> > the toplevel Makefile.am considerably and makes it much more readable
> > and maintainable. I guess everyone agrees ;-)
> > 3b) Assign the html doc files to html_DATA. This means, they are
> > installed to $(hmtdir), which by autoconf standards is
> > $(prefix)/share/doc/$packagename/. If that is not wanted, just name
> > the variable html_files e.g.
> > 4.) Reformat the SOURCES line to make it better readable and maintainable.
> >
> > The patch is against the experimental 1.19.9 tarball.
> > It only patches configure.ac/Makefile.am, so you have to run
> > "autoreconf -vfi" to rebuild the auto* files.
> >
> > Please review and apply.
> >
> > Cheers,
> > Michael
> > _______________________________________________
> > rsyslog mailing list
> > http://lists.adiscon.net/mailman/listinfo/rsyslog
>
> _______________________________________________
> rsyslog mailing list
> http://lists.adiscon.net/mailman/listinfo/rsyslog
------- End of Original Message -------
experimental 1.19.9 tarball [ In reply to ]
I just applied this patch, testing a bit. Will re-release experimental
tarball later today.

Rainer

On Thu, 2007-10-11 at 12:43 +0200, theinric at redhat.com wrote:
> Sorry, didn't realised.
>
> diff -up rsyslog-1.19.9/configure.ac.orig rsyslog-1.19.9/configure.ac
> --- rsyslog-1.19.9/configure.ac.orig 2007-10-11 11:56:05.000000000 +0200
> +++ rsyslog-1.19.9/configure.ac 2007-10-11 11:57:33.000000000 +0200
> @@ -254,17 +254,23 @@ if test "x$enable_mysql" = "xyes"; then
> [mysql/mysql.h],,
> [AC_MSG_FAILURE([MySQL is missing])]
> )
> - AC_SUBST(LIBS_TMP,[$LIBS])
> - AC_SEARCH_LIBS(
> - [mysql_init],
> + AC_CHECK_PROG(
> + [HAVE_MYSQL_CONFIG],
> + [mysql_config],
> + [yes],,,
> + )
> + if test "x${HAVE_MYSQL_CONFIG}" != "xyes"; then
> + AC_MSG_FAILURE([mysql_config not found in PATH])
> + fi
> + AC_CHECK_LIB(
> [mysqlclient],
> + [mysql_init],
> [mysql_cflags=`mysql_config --cflags`
> mysql_libs=`mysql_config --libs`
> ],
> [AC_MSG_FAILURE([MySQL library is missing])],
> [`mysql_config --libs`]
> )
> - AC_SUBST(LIBS,[$LIBS_TMP])
> fi
> AM_CONDITIONAL(ENABLE_MYSQL, test x$enable_mysql = xyes)
> AC_SUBST(mysql_cflags)
>
> Rainer Gerhards wrote:
> > The mailing list won't let attachments of anything other than (I think,
> > .txt) through (if at all). You can mail me privately, I'll post it (and
> > I bet you've also a site to post to, feel free to do that).
> >
> > Thanks again all for your help - muuuuuch appreciated!
> >
> > Rainer
> >
> >> -----Original Message-----
> >> From: rsyslog-bounces at lists.adiscon.com [mailto:rsyslog-
> >> bounces at lists.adiscon.com] On Behalf Of theinric at redhat.com
> >> Sent: Thursday, October 11, 2007 12:37 PM
> >> To: rsyslog-users
> >> Subject: Re: [rsyslog] experimental 1.19.9 tarball
> >>
> >> Hi,
> >>
> >> just a few additions to Michael's patch.
> >>
> >> Rainer Gerhards wrote:
> >>> Hi Michael,
> >>>
> >>> many thanks, this is a *very* useful patch, much appreciated. I just
> >>> applied it an re-created the experimental tarball. The new version
> > is
> >>> available at the previous url at
> >>>
> >>> http://download.rsyslog.com/rsyslog/rsyslog-1.19.9.tar.gz
> >>>
> >>> I think I'll release tomorrow if I do not hear any show stopper
> > until
> >>> then.
> >>>
> >>> Thanks all for testing, comments and patches! (I so far applied
> >>> Michael's only, is it seems to cover everything else - but I'll do
> >>> further review now) :)
> >>>
> >>> Rainer
> >>>
> >>> On Wed, 2007-10-10 at 19:33 +0200, Michael Biebl wrote:
> >>>> 2007/10/10, Rainer Gerhards <rgerhards at hq.adiscon.com>:
> >>>>> Excellent - from initial feedback I received, there still seems to
> >> be
> >>>>> some minor nits. I'll re-release the pilot soon, will post then.
> >>>> Ok, I had some time to review the changes. All in all I like, how
> >> it's
> >>>> done know.
> >>>>
> >>>> Attached you will find a patch which will cleanup/fix some issues:
> >>>>
> >>>> 1.) fix failing compilation of ommysql plugin (s/ommysql-
> >> config.h/config.h/)
> >>>> 2.) fix mysql configure check (although the default is no, we did
> >>>> check for the mysql devel files)
> >>>> 3.) Create a separate Makefile.am for the doc files. This cleans up
> >>>> the toplevel Makefile.am considerably and makes it much more
> >> readable
> >>>> and maintainable. I guess everyone agrees ;-)
> >>>> 3b) Assign the html doc files to html_DATA. This means, they are
> >>>> installed to $(hmtdir), which by autoconf standards is
> >>>> $(prefix)/share/doc/$packagename/. If that is not wanted, just name
> >>>> the variable html_files e.g.
> >>>> 4.) Reformat the SOURCES line to make it better readable and
> >> maintainable.
> >>>> The patch is against the experimental 1.19.9 tarball.
> >>>> It only patches configure.ac/Makefile.am, so you have to run
> >>>> "autoreconf -vfi" to rebuild the auto* files.
> >>>>
> >>>> Please review and apply.
> >>>>
> >>>> Cheers,
> >>>> Michael
> >>>> _______________________________________________
> >>>> rsyslog mailing list
> >>>> http://lists.adiscon.net/mailman/listinfo/rsyslog
> >>> _______________________________________________
> >>> rsyslog mailing list
> >>> http://lists.adiscon.net/mailman/listinfo/rsyslog
> >
> > _______________________________________________
> > rsyslog mailing list
> > http://lists.adiscon.net/mailman/listinfo/rsyslog
>
> _______________________________________________
> rsyslog mailing list
> http://lists.adiscon.net/mailman/listinfo/rsyslog
experimental 1.19.9 tarball [ In reply to ]
OK, I have changed this location. If someone objects that, please speak
up now.

Thanks,
Rainer

On Thu, 2007-10-11 at 12:34 +0200, Peter Vrabec wrote:
> Michael Biebl wrote:
> > 2007/10/10, Rainer Gerhards <rgerhards at hq.adiscon.com>:
> >> Excellent - from initial feedback I received, there still seems to be
> >> some minor nits. I'll re-release the pilot soon, will post then.
> >
> > Ok, I had some time to review the changes. All in all I like, how it's
> > done know.
> >
> > Attached you will find a patch which will cleanup/fix some issues:
> >
> > 1.) fix failing compilation of ommysql plugin (s/ommysql-config.h/config.h/)
> > 2.) fix mysql configure check (although the default is no, we did
> > check for the mysql devel files)
> > 3.) Create a separate Makefile.am for the doc files. This cleans up
> > the toplevel Makefile.am considerably and makes it much more readable
> > and maintainable. I guess everyone agrees ;-)
> > 3b) Assign the html doc files to html_DATA. This means, they are
> > installed to $(hmtdir), which by autoconf standards is
> > $(prefix)/share/doc/$packagename/. If that is not wanted, just name
> > the variable html_files e.g.
>
> I would appreciate it :-)
>
> > 4.) Reformat the SOURCES line to make it better readable and maintainable.
> >
> > The patch is against the experimental 1.19.9 tarball.
> > It only patches configure.ac/Makefile.am, so you have to run
> > "autoreconf -vfi" to rebuild the auto* files.
> >
> > Please review and apply.
> >
> > Cheers,
> > Michael
> >
> >
> > ------------------------------------------------------------------------
> >
> > _______________________________________________
> > rsyslog mailing list
> > http://lists.adiscon.net/mailman/listinfo/rsyslog
>
> _______________________________________________
> rsyslog mailing list
> http://lists.adiscon.net/mailman/listinfo/rsyslog