Mailing List Archive

[PATCH] junos.pm: filter negative temperatures in ShowChassisEnvironment
One of our switches is in an outdoor cabinet. It gets below 0 sometimes so we see output like this:

# Temp FPC 0 GEPHY1 OK
# FPC 0 GEPHY2 OK
# FPC 0 GEPHY3 OK
- # FPC 0 GEPHY4 OK -5 degrees C / 23 degrees F
+ # FPC 0 GEPHY4 OK
#

The attached patch fixes ShowChassisEnvironment so it matches the - sign.
Re: [PATCH] junos.pm: filter negative temperatures in ShowChassisEnvironment [ In reply to ]
Ironically, we rely on RANCID to tell us when our cabinets get too cold on such devices.
Mostly because our NMS is hopeless, and can't do it (Enterprise! Closed source!), so it never occurred to me to submit a patch for this.

However, some devices (namely, EX2200's) don't understand zero, or sub-zero degrees and report it as N/A.
I've attached a patch to cover this circumstance.

# Class Item Status
# Power FPC 0 Power Supply 0 OK
# Temp FPC 0 GEPHY1 OK
- # FPC 0 GEPHY2 OK N/A
+ # FPC 0 GEPHY2 OK
# FPC 0 GEPHY3 OK
# FPC 0 GEPHY4 OK
#

-----Original Message-----
From: Rancid-discuss [mailto:rancid-discuss-bounces@shrubbery.net] On Behalf Of Anderson, Charles R
Sent: Tuesday, February 19, 2019 6:50 AM
To: rancid-discuss@shrubbery.net
Subject: [rancid] [PATCH] junos.pm: filter negative temperatures in ShowChassisEnvironment

One of our switches is in an outdoor cabinet. It gets below 0 sometimes so we see output like this:

# Temp FPC 0 GEPHY1 OK
# FPC 0 GEPHY2 OK
# FPC 0 GEPHY3 OK
- # FPC 0 GEPHY4 OK -5 degrees C / 23 degrees F
+ # FPC 0 GEPHY4 OK
#

The attached patch fixes ShowChassisEnvironment so it matches the - sign.
Re: [PATCH] junos.pm: filter negative temperatures in ShowChassisEnvironment [ In reply to ]
My example below WAS from an EX2200. We have some others that always report -10 (even in toasty closets)--I wonder if that is off-scale low due to a sensor failure? I have also seen N/A in 2016, but not lately. What software version are you running? We are running 12.3R12-S2 on this particular outdoor EX2200. I can try to find out what version we were running in 2016 when we last saw N/A. I just saw your comment in the patch that N/A only appeared for a temperature in the range -1 to 0.

On Wed, Feb 20, 2019 at 08:54:39AM -0800, Emille Blanc wrote:
> Ironically, we rely on RANCID to tell us when our cabinets get too cold on such devices.
> Mostly because our NMS is hopeless, and can't do it (Enterprise! Closed source!), so it never occurred to me to submit a patch for this.
>
> However, some devices (namely, EX2200's) don't understand zero, or sub-zero degrees and report it as N/A.
> I've attached a patch to cover this circumstance.
>
> # Class Item Status
> # Power FPC 0 Power Supply 0 OK
> # Temp FPC 0 GEPHY1 OK
> - # FPC 0 GEPHY2 OK N/A
> + # FPC 0 GEPHY2 OK
> # FPC 0 GEPHY3 OK
> # FPC 0 GEPHY4 OK
> #
>
> -----Original Message-----
> From: Rancid-discuss [mailto:rancid-discuss-bounces@shrubbery.net] On Behalf Of Anderson, Charles R
> Sent: Tuesday, February 19, 2019 6:50 AM
> To: rancid-discuss@shrubbery.net
> Subject: [rancid] [PATCH] junos.pm: filter negative temperatures in ShowChassisEnvironment
>
> One of our switches is in an outdoor cabinet. It gets below 0 sometimes so we see output like this:
>
> # Temp FPC 0 GEPHY1 OK
> # FPC 0 GEPHY2 OK
> # FPC 0 GEPHY3 OK
> - # FPC 0 GEPHY4 OK -5 degrees C / 23 degrees F
> + # FPC 0 GEPHY4 OK
> #
>
> The attached patch fixes ShowChassisEnvironment so it matches the - sign.

_______________________________________________
Rancid-discuss mailing list
Rancid-discuss@shrubbery.net
http://www.shrubbery.net/mailman/listinfo/rancid-discuss
Re: [PATCH] junos.pm: filter negative temperatures in ShowChassisEnvironment [ In reply to ]
These are all from an EX2200-C-12T-2G's, running 12.3R12.4
We're stuck at that release for the 2200-C's, as 15.x bricks them in our environment (TSB17138 does warn to not use 15.x).

> I just saw your comment in the patch that N/A only appeared for a temperature in the range -1 to 0.

Correct - last I dug into this, it only reports N/A at 0 (zero), and -1 degrees. It always struck me as an odd cosmetic.

-----Original Message-----
From: Rancid-discuss [mailto:rancid-discuss-bounces@shrubbery.net] On Behalf Of Anderson, Charles R
Sent: Wednesday, February 20, 2019 9:20 AM
To: rancid-discuss@shrubbery.net
Subject: Re: [rancid] [PATCH] junos.pm: filter negative temperatures in ShowChassisEnvironment

My example below WAS from an EX2200. We have some others that always report -10 (even in toasty closets)--I wonder if that is off-scale low due to a sensor failure? I have also seen N/A in 2016, but not lately. What software version are you running? We are running 12.3R12-S2 on this particular outdoor EX2200. I can try to find out what version we were running in 2016 when we last saw N/A. I just saw your comment in the patch that N/A only appeared for a temperature in the range -1 to 0.

On Wed, Feb 20, 2019 at 08:54:39AM -0800, Emille Blanc wrote:
> Ironically, we rely on RANCID to tell us when our cabinets get too cold on such devices.
> Mostly because our NMS is hopeless, and can't do it (Enterprise! Closed source!), so it never occurred to me to submit a patch for this.
>
> However, some devices (namely, EX2200's) don't understand zero, or sub-zero degrees and report it as N/A.
> I've attached a patch to cover this circumstance.
>
> # Class Item Status
> # Power FPC 0 Power Supply 0 OK
> # Temp FPC 0 GEPHY1 OK
> - # FPC 0 GEPHY2 OK N/A
> + # FPC 0 GEPHY2 OK
> # FPC 0 GEPHY3 OK
> # FPC 0 GEPHY4 OK
> #
>
> -----Original Message-----
> From: Rancid-discuss [mailto:rancid-discuss-bounces@shrubbery.net] On Behalf Of Anderson, Charles R
> Sent: Tuesday, February 19, 2019 6:50 AM
> To: rancid-discuss@shrubbery.net
> Subject: [rancid] [PATCH] junos.pm: filter negative temperatures in ShowChassisEnvironment
>
> One of our switches is in an outdoor cabinet. It gets below 0 sometimes so we see output like this:
>
> # Temp FPC 0 GEPHY1 OK
> # FPC 0 GEPHY2 OK
> # FPC 0 GEPHY3 OK
> - # FPC 0 GEPHY4 OK -5 degrees C / 23 degrees F
> + # FPC 0 GEPHY4 OK
> #
>
> The attached patch fixes ShowChassisEnvironment so it matches the - sign.

_______________________________________________
Rancid-discuss mailing list
Rancid-discuss@shrubbery.net
http://www.shrubbery.net/mailman/listinfo/rancid-discuss

_______________________________________________
Rancid-discuss mailing list
Rancid-discuss@shrubbery.net
http://www.shrubbery.net/mailman/listinfo/rancid-discuss
Re: [PATCH] junos.pm: filter negative temperatures in ShowChassisEnvironment [ In reply to ]
so -2 or lower works?

On Wed, Feb 20, 2019 at 12:37 PM Emille Blanc
<emille@abccommunications.com> wrote:
>
> These are all from an EX2200-C-12T-2G's, running 12.3R12.4
> We're stuck at that release for the 2200-C's, as 15.x bricks them in our environment (TSB17138 does warn to not use 15.x).
>
> > I just saw your comment in the patch that N/A only appeared for a temperature in the range -1 to 0.
>
> Correct - last I dug into this, it only reports N/A at 0 (zero), and -1 degrees. It always struck me as an odd cosmetic.
>
> -----Original Message-----
> From: Rancid-discuss [mailto:rancid-discuss-bounces@shrubbery.net] On Behalf Of Anderson, Charles R
> Sent: Wednesday, February 20, 2019 9:20 AM
> To: rancid-discuss@shrubbery.net
> Subject: Re: [rancid] [PATCH] junos.pm: filter negative temperatures in ShowChassisEnvironment
>
> My example below WAS from an EX2200. We have some others that always report -10 (even in toasty closets)--I wonder if that is off-scale low due to a sensor failure? I have also seen N/A in 2016, but not lately. What software version are you running? We are running 12.3R12-S2 on this particular outdoor EX2200. I can try to find out what version we were running in 2016 when we last saw N/A. I just saw your comment in the patch that N/A only appeared for a temperature in the range -1 to 0.
>
> On Wed, Feb 20, 2019 at 08:54:39AM -0800, Emille Blanc wrote:
> > Ironically, we rely on RANCID to tell us when our cabinets get too cold on such devices.
> > Mostly because our NMS is hopeless, and can't do it (Enterprise! Closed source!), so it never occurred to me to submit a patch for this.
> >
> > However, some devices (namely, EX2200's) don't understand zero, or sub-zero degrees and report it as N/A.
> > I've attached a patch to cover this circumstance.
> >
> > # Class Item Status
> > # Power FPC 0 Power Supply 0 OK
> > # Temp FPC 0 GEPHY1 OK
> > - # FPC 0 GEPHY2 OK N/A
> > + # FPC 0 GEPHY2 OK
> > # FPC 0 GEPHY3 OK
> > # FPC 0 GEPHY4 OK
> > #
> >
> > -----Original Message-----
> > From: Rancid-discuss [mailto:rancid-discuss-bounces@shrubbery.net] On Behalf Of Anderson, Charles R
> > Sent: Tuesday, February 19, 2019 6:50 AM
> > To: rancid-discuss@shrubbery.net
> > Subject: [rancid] [PATCH] junos.pm: filter negative temperatures in ShowChassisEnvironment
> >
> > One of our switches is in an outdoor cabinet. It gets below 0 sometimes so we see output like this:
> >
> > # Temp FPC 0 GEPHY1 OK
> > # FPC 0 GEPHY2 OK
> > # FPC 0 GEPHY3 OK
> > - # FPC 0 GEPHY4 OK -5 degrees C / 23 degrees F
> > + # FPC 0 GEPHY4 OK
> > #
> >
> > The attached patch fixes ShowChassisEnvironment so it matches the - sign.
>
> _______________________________________________
> Rancid-discuss mailing list
> Rancid-discuss@shrubbery.net
> http://www.shrubbery.net/mailman/listinfo/rancid-discuss
>
> _______________________________________________
> Rancid-discuss mailing list
> Rancid-discuss@shrubbery.net
> http://www.shrubbery.net/mailman/listinfo/rancid-discuss

_______________________________________________
Rancid-discuss mailing list
Rancid-discuss@shrubbery.net
http://www.shrubbery.net/mailman/listinfo/rancid-discuss
Re: [PATCH] junos.pm: filter negative temperatures in ShowChassisEnvironment [ In reply to ]
I'm fairly certain -2 and below does work - but can't find evidence to support that presently.
I'll fire off a search in my outlook archive to grind away over lunch to confirm.

-----Original Message-----
From: Aaron Dudek [mailto:adudek16@gmail.com]
Sent: Wednesday, February 20, 2019 9:56 AM
To: Emille Blanc
Cc: Anderson, Charles R; rancid-discuss@shrubbery.net
Subject: Re: [rancid] [PATCH] junos.pm: filter negative temperatures in ShowChassisEnvironment

so -2 or lower works?

On Wed, Feb 20, 2019 at 12:37 PM Emille Blanc
<emille@abccommunications.com> wrote:
>
> These are all from an EX2200-C-12T-2G's, running 12.3R12.4
> We're stuck at that release for the 2200-C's, as 15.x bricks them in our environment (TSB17138 does warn to not use 15.x).
>
> > I just saw your comment in the patch that N/A only appeared for a temperature in the range -1 to 0.
>
> Correct - last I dug into this, it only reports N/A at 0 (zero), and -1 degrees. It always struck me as an odd cosmetic.
>
> -----Original Message-----
> From: Rancid-discuss [mailto:rancid-discuss-bounces@shrubbery.net] On Behalf Of Anderson, Charles R
> Sent: Wednesday, February 20, 2019 9:20 AM
> To: rancid-discuss@shrubbery.net
> Subject: Re: [rancid] [PATCH] junos.pm: filter negative temperatures in ShowChassisEnvironment
>
> My example below WAS from an EX2200. We have some others that always report -10 (even in toasty closets)--I wonder if that is off-scale low due to a sensor failure? I have also seen N/A in 2016, but not lately. What software version are you running? We are running 12.3R12-S2 on this particular outdoor EX2200. I can try to find out what version we were running in 2016 when we last saw N/A. I just saw your comment in the patch that N/A only appeared for a temperature in the range -1 to 0.
>
> On Wed, Feb 20, 2019 at 08:54:39AM -0800, Emille Blanc wrote:
> > Ironically, we rely on RANCID to tell us when our cabinets get too cold on such devices.
> > Mostly because our NMS is hopeless, and can't do it (Enterprise! Closed source!), so it never occurred to me to submit a patch for this.
> >
> > However, some devices (namely, EX2200's) don't understand zero, or sub-zero degrees and report it as N/A.
> > I've attached a patch to cover this circumstance.
> >
> > # Class Item Status
> > # Power FPC 0 Power Supply 0 OK
> > # Temp FPC 0 GEPHY1 OK
> > - # FPC 0 GEPHY2 OK N/A
> > + # FPC 0 GEPHY2 OK
> > # FPC 0 GEPHY3 OK
> > # FPC 0 GEPHY4 OK
> > #
> >
> > -----Original Message-----
> > From: Rancid-discuss [mailto:rancid-discuss-bounces@shrubbery.net] On Behalf Of Anderson, Charles R
> > Sent: Tuesday, February 19, 2019 6:50 AM
> > To: rancid-discuss@shrubbery.net
> > Subject: [rancid] [PATCH] junos.pm: filter negative temperatures in ShowChassisEnvironment
> >
> > One of our switches is in an outdoor cabinet. It gets below 0 sometimes so we see output like this:
> >
> > # Temp FPC 0 GEPHY1 OK
> > # FPC 0 GEPHY2 OK
> > # FPC 0 GEPHY3 OK
> > - # FPC 0 GEPHY4 OK -5 degrees C / 23 degrees F
> > + # FPC 0 GEPHY4 OK
> > #
> >
> > The attached patch fixes ShowChassisEnvironment so it matches the - sign.
>
> _______________________________________________
> Rancid-discuss mailing list
> Rancid-discuss@shrubbery.net
> http://www.shrubbery.net/mailman/listinfo/rancid-discuss
>
> _______________________________________________
> Rancid-discuss mailing list
> Rancid-discuss@shrubbery.net
> http://www.shrubbery.net/mailman/listinfo/rancid-discuss

_______________________________________________
Rancid-discuss mailing list
Rancid-discuss@shrubbery.net
http://www.shrubbery.net/mailman/listinfo/rancid-discuss
Re: [PATCH] junos.pm: filter negative temperatures in ShowChassisEnvironment [ In reply to ]
Wed, Feb 20, 2019 at 10:05:16AM -0800, Emille Blanc:
> I'm fairly certain -2 and below does work - but can't find evidence to support that presently.
> I'll fire off a search in my outlook archive to grind away over lunch to confirm.

beause its treating a signed interger as unsighned...and -1 = fire?

i'm more inclined to take Anderson's patch; drop any temps. rancid does not
make for a good monitoring tool of things such as temps. can you not use a
secondary NMS to cover the data points that the primary is incapable of?

> -----Original Message-----
> From: Aaron Dudek [mailto:adudek16@gmail.com]
> Sent: Wednesday, February 20, 2019 9:56 AM
> To: Emille Blanc
> Cc: Anderson, Charles R; rancid-discuss@shrubbery.net
> Subject: Re: [rancid] [PATCH] junos.pm: filter negative temperatures in ShowChassisEnvironment
>
> so -2 or lower works?
>
> On Wed, Feb 20, 2019 at 12:37 PM Emille Blanc
> <emille@abccommunications.com> wrote:
> >
> > These are all from an EX2200-C-12T-2G's, running 12.3R12.4
> > We're stuck at that release for the 2200-C's, as 15.x bricks them in our environment (TSB17138 does warn to not use 15.x).
> >
> > > I just saw your comment in the patch that N/A only appeared for a temperature in the range -1 to 0.
> >
> > Correct - last I dug into this, it only reports N/A at 0 (zero), and -1 degrees. It always struck me as an odd cosmetic.
> >
> > -----Original Message-----
> > From: Rancid-discuss [mailto:rancid-discuss-bounces@shrubbery.net] On Behalf Of Anderson, Charles R
> > Sent: Wednesday, February 20, 2019 9:20 AM
> > To: rancid-discuss@shrubbery.net
> > Subject: Re: [rancid] [PATCH] junos.pm: filter negative temperatures in ShowChassisEnvironment
> >
> > My example below WAS from an EX2200. We have some others that always report -10 (even in toasty closets)--I wonder if that is off-scale low due to a sensor failure? I have also seen N/A in 2016, but not lately. What software version are you running? We are running 12.3R12-S2 on this particular outdoor EX2200. I can try to find out what version we were running in 2016 when we last saw N/A. I just saw your comment in the patch that N/A only appeared for a temperature in the range -1 to 0.
> >
> > On Wed, Feb 20, 2019 at 08:54:39AM -0800, Emille Blanc wrote:
> > > Ironically, we rely on RANCID to tell us when our cabinets get too cold on such devices.
> > > Mostly because our NMS is hopeless, and can't do it (Enterprise! Closed source!), so it never occurred to me to submit a patch for this.
> > >
> > > However, some devices (namely, EX2200's) don't understand zero, or sub-zero degrees and report it as N/A.
> > > I've attached a patch to cover this circumstance.
> > >
> > > # Class Item Status
> > > # Power FPC 0 Power Supply 0 OK
> > > # Temp FPC 0 GEPHY1 OK
> > > - # FPC 0 GEPHY2 OK N/A
> > > + # FPC 0 GEPHY2 OK
> > > # FPC 0 GEPHY3 OK
> > > # FPC 0 GEPHY4 OK
> > > #
> > >
> > > -----Original Message-----
> > > From: Rancid-discuss [mailto:rancid-discuss-bounces@shrubbery.net] On Behalf Of Anderson, Charles R
> > > Sent: Tuesday, February 19, 2019 6:50 AM
> > > To: rancid-discuss@shrubbery.net
> > > Subject: [rancid] [PATCH] junos.pm: filter negative temperatures in ShowChassisEnvironment
> > >
> > > One of our switches is in an outdoor cabinet. It gets below 0 sometimes so we see output like this:
> > >
> > > # Temp FPC 0 GEPHY1 OK
> > > # FPC 0 GEPHY2 OK
> > > # FPC 0 GEPHY3 OK
> > > - # FPC 0 GEPHY4 OK -5 degrees C / 23 degrees F
> > > + # FPC 0 GEPHY4 OK
> > > #
> > >
> > > The attached patch fixes ShowChassisEnvironment so it matches the - sign.
> >
> > _______________________________________________
> > Rancid-discuss mailing list
> > Rancid-discuss@shrubbery.net
> > http://www.shrubbery.net/mailman/listinfo/rancid-discuss
> >
> > _______________________________________________
> > Rancid-discuss mailing list
> > Rancid-discuss@shrubbery.net
> > http://www.shrubbery.net/mailman/listinfo/rancid-discuss
>
> _______________________________________________
> Rancid-discuss mailing list
> Rancid-discuss@shrubbery.net
> http://www.shrubbery.net/mailman/listinfo/rancid-discuss

_______________________________________________
Rancid-discuss mailing list
Rancid-discuss@shrubbery.net
http://www.shrubbery.net/mailman/listinfo/rancid-discuss
Re: [PATCH] junos.pm: filter negative temperatures in ShowChassisEnvironment [ In reply to ]
Oh, I have no problem with Charles' patch. I just wanted to point out that in our environment we see "N/A" for some devices, so wanted to add that in.

We just never bothered to patch either circumstance on our side, as it's rather convenient.

We are long overdue for a better NMS, but time...

-----Original Message-----
From: heasley [mailto:heas@shrubbery.net]
Sent: Wednesday, February 20, 2019 10:52 AM
To: Emille Blanc
Cc: Aaron Dudek; rancid-discuss@shrubbery.net
Subject: Re: [rancid] [PATCH] junos.pm: filter negative temperatures in ShowChassisEnvironment

Wed, Feb 20, 2019 at 10:05:16AM -0800, Emille Blanc:
> I'm fairly certain -2 and below does work - but can't find evidence to support that presently.
> I'll fire off a search in my outlook archive to grind away over lunch to confirm.

beause its treating a signed interger as unsighned...and -1 = fire?

i'm more inclined to take Anderson's patch; drop any temps. rancid does not
make for a good monitoring tool of things such as temps. can you not use a
secondary NMS to cover the data points that the primary is incapable of?

> -----Original Message-----
> From: Aaron Dudek [mailto:adudek16@gmail.com]
> Sent: Wednesday, February 20, 2019 9:56 AM
> To: Emille Blanc
> Cc: Anderson, Charles R; rancid-discuss@shrubbery.net
> Subject: Re: [rancid] [PATCH] junos.pm: filter negative temperatures in ShowChassisEnvironment
>
> so -2 or lower works?
>
> On Wed, Feb 20, 2019 at 12:37 PM Emille Blanc
> <emille@abccommunications.com> wrote:
> >
> > These are all from an EX2200-C-12T-2G's, running 12.3R12.4
> > We're stuck at that release for the 2200-C's, as 15.x bricks them in our environment (TSB17138 does warn to not use 15.x).
> >
> > > I just saw your comment in the patch that N/A only appeared for a temperature in the range -1 to 0.
> >
> > Correct - last I dug into this, it only reports N/A at 0 (zero), and -1 degrees. It always struck me as an odd cosmetic.
> >
> > -----Original Message-----
> > From: Rancid-discuss [mailto:rancid-discuss-bounces@shrubbery.net] On Behalf Of Anderson, Charles R
> > Sent: Wednesday, February 20, 2019 9:20 AM
> > To: rancid-discuss@shrubbery.net
> > Subject: Re: [rancid] [PATCH] junos.pm: filter negative temperatures in ShowChassisEnvironment
> >
> > My example below WAS from an EX2200. We have some others that always report -10 (even in toasty closets)--I wonder if that is off-scale low due to a sensor failure? I have also seen N/A in 2016, but not lately. What software version are you running? We are running 12.3R12-S2 on this particular outdoor EX2200. I can try to find out what version we were running in 2016 when we last saw N/A. I just saw your comment in the patch that N/A only appeared for a temperature in the range -1 to 0.
> >
> > On Wed, Feb 20, 2019 at 08:54:39AM -0800, Emille Blanc wrote:
> > > Ironically, we rely on RANCID to tell us when our cabinets get too cold on such devices.
> > > Mostly because our NMS is hopeless, and can't do it (Enterprise! Closed source!), so it never occurred to me to submit a patch for this.
> > >
> > > However, some devices (namely, EX2200's) don't understand zero, or sub-zero degrees and report it as N/A.
> > > I've attached a patch to cover this circumstance.
> > >
> > > # Class Item Status
> > > # Power FPC 0 Power Supply 0 OK
> > > # Temp FPC 0 GEPHY1 OK
> > > - # FPC 0 GEPHY2 OK N/A
> > > + # FPC 0 GEPHY2 OK
> > > # FPC 0 GEPHY3 OK
> > > # FPC 0 GEPHY4 OK
> > > #
> > >
> > > -----Original Message-----
> > > From: Rancid-discuss [mailto:rancid-discuss-bounces@shrubbery.net] On Behalf Of Anderson, Charles R
> > > Sent: Tuesday, February 19, 2019 6:50 AM
> > > To: rancid-discuss@shrubbery.net
> > > Subject: [rancid] [PATCH] junos.pm: filter negative temperatures in ShowChassisEnvironment
> > >
> > > One of our switches is in an outdoor cabinet. It gets below 0 sometimes so we see output like this:
> > >
> > > # Temp FPC 0 GEPHY1 OK
> > > # FPC 0 GEPHY2 OK
> > > # FPC 0 GEPHY3 OK
> > > - # FPC 0 GEPHY4 OK -5 degrees C / 23 degrees F
> > > + # FPC 0 GEPHY4 OK
> > > #
> > >
> > > The attached patch fixes ShowChassisEnvironment so it matches the - sign.
> >
> > _______________________________________________
> > Rancid-discuss mailing list
> > Rancid-discuss@shrubbery.net
> > http://www.shrubbery.net/mailman/listinfo/rancid-discuss
> >
> > _______________________________________________
> > Rancid-discuss mailing list
> > Rancid-discuss@shrubbery.net
> > http://www.shrubbery.net/mailman/listinfo/rancid-discuss
>
> _______________________________________________
> Rancid-discuss mailing list
> Rancid-discuss@shrubbery.net
> http://www.shrubbery.net/mailman/listinfo/rancid-discuss

_______________________________________________
Rancid-discuss mailing list
Rancid-discuss@shrubbery.net
http://www.shrubbery.net/mailman/listinfo/rancid-discuss
Re: [PATCH] junos.pm: filter negative temperatures in ShowChassisEnvironment [ In reply to ]
It seems that I can't reproduce this behavior after moving to 12.3R12-S12
On that basis, I would say the 'N/A' patch I proposed is irrelevant;

Class Item Status Measurement
Power FPC 0 Power Supply 0 OK
Temp FPC 0 GEPHY1 OK 0 degrees C / 32 degrees F
FPC 0 GEPHY2 OK 0 degrees C / 32 degrees F
FPC 0 GEPHY3 OK 0 degrees C / 32 degrees F
FPC 0 GEPHY4 OK -1 degrees C / 30 degrees F

Sorry for the noise!

-----Original Message-----
From: Rancid-discuss [mailto:rancid-discuss-bounces@shrubbery.net] On Behalf Of Emille Blanc
Sent: Wednesday, February 20, 2019 10:56 AM
To: heasley
Cc: rancid-discuss@shrubbery.net
Subject: Re: [rancid] [PATCH] junos.pm: filter negative temperatures in ShowChassisEnvironment

Oh, I have no problem with Charles' patch. I just wanted to point out that in our environment we see "N/A" for some devices, so wanted to add that in.

We just never bothered to patch either circumstance on our side, as it's rather convenient.

We are long overdue for a better NMS, but time...

-----Original Message-----
From: heasley [mailto:heas@shrubbery.net]
Sent: Wednesday, February 20, 2019 10:52 AM
To: Emille Blanc
Cc: Aaron Dudek; rancid-discuss@shrubbery.net
Subject: Re: [rancid] [PATCH] junos.pm: filter negative temperatures in ShowChassisEnvironment

Wed, Feb 20, 2019 at 10:05:16AM -0800, Emille Blanc:
> I'm fairly certain -2 and below does work - but can't find evidence to support that presently.
> I'll fire off a search in my outlook archive to grind away over lunch to confirm.

beause its treating a signed interger as unsighned...and -1 = fire?

i'm more inclined to take Anderson's patch; drop any temps. rancid does not
make for a good monitoring tool of things such as temps. can you not use a
secondary NMS to cover the data points that the primary is incapable of?

> -----Original Message-----
> From: Aaron Dudek [mailto:adudek16@gmail.com]
> Sent: Wednesday, February 20, 2019 9:56 AM
> To: Emille Blanc
> Cc: Anderson, Charles R; rancid-discuss@shrubbery.net
> Subject: Re: [rancid] [PATCH] junos.pm: filter negative temperatures in ShowChassisEnvironment
>
> so -2 or lower works?
>
> On Wed, Feb 20, 2019 at 12:37 PM Emille Blanc
> <emille@abccommunications.com> wrote:
> >
> > These are all from an EX2200-C-12T-2G's, running 12.3R12.4
> > We're stuck at that release for the 2200-C's, as 15.x bricks them in our environment (TSB17138 does warn to not use 15.x).
> >
> > > I just saw your comment in the patch that N/A only appeared for a temperature in the range -1 to 0.
> >
> > Correct - last I dug into this, it only reports N/A at 0 (zero), and -1 degrees. It always struck me as an odd cosmetic.
> >
> > -----Original Message-----
> > From: Rancid-discuss [mailto:rancid-discuss-bounces@shrubbery.net] On Behalf Of Anderson, Charles R
> > Sent: Wednesday, February 20, 2019 9:20 AM
> > To: rancid-discuss@shrubbery.net
> > Subject: Re: [rancid] [PATCH] junos.pm: filter negative temperatures in ShowChassisEnvironment
> >
> > My example below WAS from an EX2200. We have some others that always report -10 (even in toasty closets)--I wonder if that is off-scale low due to a sensor failure? I have also seen N/A in 2016, but not lately. What software version are you running? We are running 12.3R12-S2 on this particular outdoor EX2200. I can try to find out what version we were running in 2016 when we last saw N/A. I just saw your comment in the patch that N/A only appeared for a temperature in the range -1 to 0.
> >
> > On Wed, Feb 20, 2019 at 08:54:39AM -0800, Emille Blanc wrote:
> > > Ironically, we rely on RANCID to tell us when our cabinets get too cold on such devices.
> > > Mostly because our NMS is hopeless, and can't do it (Enterprise! Closed source!), so it never occurred to me to submit a patch for this.
> > >
> > > However, some devices (namely, EX2200's) don't understand zero, or sub-zero degrees and report it as N/A.
> > > I've attached a patch to cover this circumstance.
> > >
> > > # Class Item Status
> > > # Power FPC 0 Power Supply 0 OK
> > > # Temp FPC 0 GEPHY1 OK
> > > - # FPC 0 GEPHY2 OK N/A
> > > + # FPC 0 GEPHY2 OK
> > > # FPC 0 GEPHY3 OK
> > > # FPC 0 GEPHY4 OK
> > > #
> > >
> > > -----Original Message-----
> > > From: Rancid-discuss [mailto:rancid-discuss-bounces@shrubbery.net] On Behalf Of Anderson, Charles R
> > > Sent: Tuesday, February 19, 2019 6:50 AM
> > > To: rancid-discuss@shrubbery.net
> > > Subject: [rancid] [PATCH] junos.pm: filter negative temperatures in ShowChassisEnvironment
> > >
> > > One of our switches is in an outdoor cabinet. It gets below 0 sometimes so we see output like this:
> > >
> > > # Temp FPC 0 GEPHY1 OK
> > > # FPC 0 GEPHY2 OK
> > > # FPC 0 GEPHY3 OK
> > > - # FPC 0 GEPHY4 OK -5 degrees C / 23 degrees F
> > > + # FPC 0 GEPHY4 OK
> > > #
> > >
> > > The attached patch fixes ShowChassisEnvironment so it matches the - sign.
> >
> > _______________________________________________
> > Rancid-discuss mailing list
> > Rancid-discuss@shrubbery.net
> > http://www.shrubbery.net/mailman/listinfo/rancid-discuss
> >
> > _______________________________________________
> > Rancid-discuss mailing list
> > Rancid-discuss@shrubbery.net
> > http://www.shrubbery.net/mailman/listinfo/rancid-discuss
>
> _______________________________________________
> Rancid-discuss mailing list
> Rancid-discuss@shrubbery.net
> http://www.shrubbery.net/mailman/listinfo/rancid-discuss

_______________________________________________
Rancid-discuss mailing list
Rancid-discuss@shrubbery.net
http://www.shrubbery.net/mailman/listinfo/rancid-discuss

_______________________________________________
Rancid-discuss mailing list
Rancid-discuss@shrubbery.net
http://www.shrubbery.net/mailman/listinfo/rancid-discuss