Mailing List Archive

PATCH: fix ripd version send
Hello,

This patch reverse unneeded change which broke per interface rip version
selection. Current quagga ignores this setting and uses global ripd
version value when sending update. Please notice that, even now, type of
socket (mulitacast/broadcast) is selected based on per interface version
so we can end up with RIPv2 broadcast on unicast capable device or RIPv1
multicast announce!

diff -Nur quagga-0.96.4-orig/ripd/ripd.c quagga-0.96.4/ripd/ripd.c
--- quagga-0.96.4-orig/ripd/ripd.c 2003-11-17 10:15:18.000000000 +0100
+++ quagga-0.96.4/ripd/ripd.c 2003-11-19 21:44:51.000000000 +0100
@@ -2288,7 +2288,7 @@
if (IS_RIP_DEBUG_EVENT)
zlog_info ("multicast announce on %s ", ifp->name);

- rip_output_process (ifp, NULL, NULL, route_type, rip->version_send,
+ rip_output_process (ifp, NULL, NULL, route_type, version,
saddr);
return;
}
@@ -2317,7 +2317,7 @@
inet_ntoa (to.sin_addr), ifp->name);

rip_output_process (ifp, connected->address, &to, route_type,
- rip->version_send, saddr);
+ version, saddr);
}
}
}

Best regards,

Krzysztof Olêdzki