Mailing List Archive: Re: [zebra 20372] Re: maximum-prefix

On Mon, 2003-08-25 at 14:25, Ruud de Rooij wrote:
> This means that if you do not want to receive any prefixes at all, you'd
> set maximum-prefix to 0 on Cisco and to 1 on Zebra. If you want to
> receive exactly 1 prefix, you need to set it to 2 on Zebra, etc.
>
> Personally, I regard this as a bug in Zebra.

Fortunately it's a one character fix. I'm not going to bounce all my BGP
sessions to correct this in my running binaries, but here's the patch.

% cvs diff bgpd/bgp_route.c
Index: bgpd/bgp_route.c
===================================================================
RCS file: /var/cvsroot/quagga/bgpd/bgp_route.c,v
retrieving revision 1.5
diff -r1.5 bgp_route.c
873c873
< if (peer->pcount[afi][safi] >= peer->pmax[afi][safi])
---
> if (peer->pcount[afi][safi] > peer->pmax[afi][safi])

--
Jeff S Wheeler <jsw@five-elements.com>

On Wed, 27 Aug 2003, Jeff S Wheeler wrote:

> % cvs diff bgpd/bgp_route.c
> Index: bgpd/bgp_route.c
> ===================================================================
> RCS file: /var/cvsroot/quagga/bgpd/bgp_route.c,v
> retrieving revision 1.5
> diff -r1.5 bgp_route.c
> 873c873
> < if (peer->pcount[afi][safi] >= peer->pmax[afi][safi])
> ---
> > if (peer->pcount[afi][safi] > peer->pmax[afi][safi])

its more than just that - kunihiro has reverted that in zebra.org and
applied more extensive changes (merged to quagga also).

> --
> Jeff S Wheeler <jsw@five-elements.com>

regards,
--
Paul Jakma paul@clubi.ie paul@jakma.org Key ID: 64A2FF6A
warning: do not ever send email to spam@dishone.st
Fortune:
Between infinite and short there is a big difference.
-- G.H. Gonnet