Mailing List Archive: Submitting patch

Submitting patch

Dec 9, 2016, 9:15 AM

Post #1 of 4 (806 views)

Hi all,

I was thinking of making following changes while processing summary lsa in ospf.

[demt@bgl-ads-2457]/nobackup/demt/quagaa/ospfd>git diff -u ospf_ia.c
diff --git a/ospfd/ospf_ia.c b/ospfd/ospf_ia.c
index b2d0fae..4121c18 100644
--- a/ospfd/ospf_ia.c
+++ b/ospfd/ospf_ia.c
@@ -250,6 +250,11 @@ process_summary_lsa (struct ospf_area *area,
struct route_table *rt,
p.prefixlen == 0)
return 0; /* Ignore summary default from a stub area */

+ /* Ignore summary lsa in non_backbone_area */
+ if (!OSPF_IS_AREA_BACKBONE(A))
+ return 0;
+
+

I think we should not process summary lsa's in non_backbone area. As
this may create unnecessary loops.
I'm new to this, please point me to next steps. if you think diff is needed.

--
Devarajegowda,
Software Engineer
Cisco Systems
Bangalore

_______________________________________________
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev

Re: Submitting patch [ In reply to ]

devaraj411mgowda at gmail

Dec 9, 2016, 12:11 PM

Post #2 of 4 (799 views)

Permalink

Oops my mistake

[demt@bgl-ads-2457]/nobackup/demt/quagaa/ospfd>git diff -u ospf_ia.c
diff --git a/ospfd/ospf_ia.c b/ospfd/ospf_ia.c
index b2d0fae..f6a2b9b 100644
--- a/ospfd/ospf_ia.c
+++ b/ospfd/ospf_ia.c
@@ -250,6 +250,11 @@ process_summary_lsa (struct ospf_area *area,
struct route_table *rt,
p.prefixlen == 0)
return 0; /* Ignore summary default from a stub area */

+ /* Ignore summary lsa in non_backbone_area */
+ if (!OSPF_IS_AREA_BACKBONE(area))
+ return 0;
+
+

On Fri, Dec 9, 2016 at 10:45 PM, Devaraj Gowda
<devaraj411mgowda@gmail.com> wrote:
> Hi all,
>
> I was thinking of making following changes while processing summary lsa in ospf.
>
> [demt@bgl-ads-2457]/nobackup/demt/quagaa/ospfd>git diff -u ospf_ia.c
> diff --git a/ospfd/ospf_ia.c b/ospfd/ospf_ia.c
> index b2d0fae..4121c18 100644
> --- a/ospfd/ospf_ia.c
> +++ b/ospfd/ospf_ia.c
> @@ -250,6 +250,11 @@ process_summary_lsa (struct ospf_area *area,
> struct route_table *rt,
> p.prefixlen == 0)
> return 0; /* Ignore summary default from a stub area */
>
> + /* Ignore summary lsa in non_backbone_area */
> + if (!OSPF_IS_AREA_BACKBONE(A))
> + return 0;
> +
> +
>
> I think we should not process summary lsa's in non_backbone area. As
> this may create unnecessary loops.
> I'm new to this, please point me to next steps. if you think diff is needed.
>
> --
> Devarajegowda,
> Software Engineer
> Cisco Systems
> Bangalore

--
Devarajegowda,
Software Engineer
Cisco Systems
Bangalore

_______________________________________________
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev

Re: Submitting patch [ In reply to ]

devaraj411mgowda at gmail

Dec 9, 2016, 1:00 PM

Post #3 of 4 (797 views)

Permalink

diff --git a/ospfd/ospf_ia.c b/ospfd/ospf_ia.c
index b2d0fae..331e4bc 100644
--- a/ospfd/ospf_ia.c
+++ b/ospfd/ospf_ia.c
@@ -250,6 +250,9 @@ process_summary_lsa (struct ospf_area *area,
struct route_table *rt,
p.prefixlen == 0)
return 0; /* Ignore summary default from a stub area */

+ if (!OSPF_IS_AREA_BACKBONE(area))
+ return 0; /* Ignore summary lsa in non_backbone_area */
+
abr.family = AF_INET;
abr.prefix = sl->header.adv_router;
abr.prefixlen = IPV4_MAX_BITLEN;

On Fri, Dec 9, 2016 at 10:45 PM, Devaraj Gowda
<devaraj411mgowda@gmail.com> wrote:
> Hi all,
>
> I was thinking of making following changes while processing summary lsa in ospf.
>
> [demt@bgl-ads-2457]/nobackup/demt/quagaa/ospfd>git diff -u ospf_ia.c
> diff --git a/ospfd/ospf_ia.c b/ospfd/ospf_ia.c
> index b2d0fae..4121c18 100644
> --- a/ospfd/ospf_ia.c
> +++ b/ospfd/ospf_ia.c
> @@ -250,6 +250,11 @@ process_summary_lsa (struct ospf_area *area,
> struct route_table *rt,
> p.prefixlen == 0)
> return 0; /* Ignore summary default from a stub area */
>
> + /* Ignore summary lsa in non_backbone_area */
> + if (!OSPF_IS_AREA_BACKBONE(A))
> + return 0;
> +
> +
>
> I think we should not process summary lsa's in non_backbone area. As
> this may create unnecessary loops.
> I'm new to this, please point me to next steps. if you think diff is needed.
>
> --
> Devarajegowda,
> Software Engineer
> Cisco Systems
> Bangalore

--
Devarajegowda,
Software Engineer
Cisco Systems
Bangalore

_______________________________________________
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev

Re: Submitting patch [ In reply to ]

devaraj411mgowda at gmail

Dec 9, 2016, 1:20 PM

Post #4 of 4 (798 views)

Permalink

demt@bgl-ads-2457]/nobackup/demt/quagaa/ospfd>git diff -u ospf_ia.c
diff --git a/ospfd/ospf_ia.c b/ospfd/ospf_ia.c
index b2d0fae..331e4bc 100644
--- a/ospfd/ospf_ia.c
+++ b/ospfd/ospf_ia.c
@@ -250,6 +250,9 @@ process_summary_lsa (struct ospf_area *area,
struct route_table *rt,
p.prefixlen == 0)
return 0; /* Ignore summary default from a stub area */

+ if (!OSPF_IS_AREA_BACKBONE(area))
+ return 0; /* Ignore summary lsa in non_backbone_area */
+
abr.family = AF_INET;
abr.prefix = sl->header.adv_router;
abr.prefixlen = IPV4_MAX_BITLEN;

On Fri, Dec 9, 2016 at 10:45 PM, Devaraj Gowda
<devaraj411mgowda@gmail.com> wrote:
> Hi all,
>
> I was thinking of making following changes while processing summary lsa in ospf.
>
> [demt@bgl-ads-2457]/nobackup/demt/quagaa/ospfd>git diff -u ospf_ia.c
> diff --git a/ospfd/ospf_ia.c b/ospfd/ospf_ia.c
> index b2d0fae..4121c18 100644
> --- a/ospfd/ospf_ia.c
> +++ b/ospfd/ospf_ia.c
> @@ -250,6 +250,11 @@ process_summary_lsa (struct ospf_area *area,
> struct route_table *rt,
> p.prefixlen == 0)
> return 0; /* Ignore summary default from a stub area */
>
> + /* Ignore summary lsa in non_backbone_area */
> + if (!OSPF_IS_AREA_BACKBONE(A))
> + return 0;
> +
> +
>
> I think we should not process summary lsa's in non_backbone area. As
> this may create unnecessary loops.
> I'm new to this, please point me to next steps. if you think diff is needed.
>
> --
> Devarajegowda,
> Software Engineer
> Cisco Systems
> Bangalore

--
Devarajegowda,
Software Engineer
Cisco Systems
Bangalore

_______________________________________________
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev