Mailing List Archive: Re: [quagga-users 14524] quagga 1.1 seems to have completely broken ospf6

Iâ€™ve reproduced the issue and created a topology test for it.

Thanks to Jan Hugo Prins for his time to help me debug this. Donâ€™t know
why this didnâ€™t trigger an error in my RFC compliance tests)

Test is requires a Ubuntu 16.04 with Mininet installed

Python script for the test and documentation is in the git at
https://git.netdef.org/scm/netdef/topotests.git

Iâ€™m going to add this test to my CI system AFTER the code is fixed
(otherwise every patch submission will be flagged as bad)

Regards,
Martin Winter

PS: I have not spent time in any bisect or any search for the bad
commit. I hope someone else here takes overâ€¦

PSS: Iâ€™m working on topology tests for some time and Iâ€™m planning to add
more to the automated tests. Working on some BGP tests as well and
want to add several tests with route-map and redistribution etc to it.
Suggestions welcomeâ€¦

On 15 Nov 2016, at 23:51, Nicolas DEFFAYET wrote:

> On Tue, 2016-11-15 at 15:12 -0800, Martin Winter wrote:
>
> Hello Martin,
>
>> Can you clarify on the â€œbrokenâ€ in 1.1.0?
>
> https://bugzilla.quagga.net/show_bug.cgi?id=885
> https://bugzilla.quagga.net/show_bug.cgi?id=886
>
>> - FreeBSD Version?
>
> FreeBSD 11.0 but it's not related to FreeBSD because users have reported
> the same issue on Linux.
>
>> - Broken = no neighbors formed? No routes in routing table?
>
> Neighbors are formed but no routes in routing table.
>
> Between 1.0.20160315 and 1.1.0 the following commit have been done:
> ospf6d: fix off-by-one on display of spf reasons
> ospf6d: don't access nexthops out of bounds
> ospf6d: Fix double increment of Sequence Number
> ospf6d: Fix loss of hello's on interface
> ospf6d: Adding the initialization check in ospfv3_clean()
> ospf6d: Fixing a couple of issues with ospf6_route_remo...
> ospf6d: LA (local-address) bit related inter-op fix.
> ospf6d: We should accept long form of "no redistribute"
> ospf6d: Add the missing ospf6 running check in show...
> ospf6d: Support for 'clear ipv6 ospf6 interface [ifname]
> opsf6d: Update router-LSA when nbr's interface-ID changes
> ospf6d, ripd, vtysh: Fix "no set metric" for ospf6...
> ospf6d: implement admin distance
>
> One of this commit break ospf6d.
>
> Thanks
>
> --
> Nicolas DEFFAYET
>

_______________________________________________
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev

Martin, all,

2016-11-17 12:28 GMT+01:00 Martin Winter <mwinter@opensourcerouting.org>:
> Iâ€™ve reproduced the issue and created a topology test for it.
>
> Thanks to Jan Hugo Prins for his time to help me debug this. Donâ€™t know
> why this didnâ€™t trigger an error in my RFC compliance tests)
>
> Test is requires a Ubuntu 16.04 with Mininet installed
>
> Python script for the test and documentation is in the git at
> https://git.netdef.org/scm/netdef/topotests.git
>
> Iâ€™m going to add this test to my CI system AFTER the code is fixed
> (otherwise every patch submission will be flagged as bad)
>
> Regards,
> Martin Winter
>
>
> PS: I have not spent time in any bisect or any search for the bad
> commit. I hope someone else here takes overâ€¦

After upgrading to Quagga 1.1.0, we also have problems with ospf6 on
Linux (routes are not calculated anymore).
Reverting this patch fixes the problem for us (but no idea why):

e509af86e357 ("opsf6d: Update router-LSA when nbr's interface-ID changes")

Regards,

Julien

_______________________________________________
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev